FriendsOfFlarum Polls

datitisev

Wlork Well, that was helpful testing! My code didn't work with Flarum setups that utilized SQL table prefixes. That should be resolved with my last changes. Before trying them out, either have a v1 setup or purge the extension (I split a migration file into two, so that'd run again and cause issues). I do remember composer sometimes being finicky with updating dev branches that are required, so I don't know if running that command again will update successfully or not.

Wlork

datitisev

Glad I could help you !

I created polls in v1
FoF Polls v1 enabled. No Purge.
I typed these two commands in order.

No problem with SQL !

However, the v1 polls have disappeared. BUT ! By deactivating FoF Polls (no purge) and reactivating it, the polls reappeared in v2 🙂 !

I've noticed a small issue with v2 polls. When I edit a poll, I have to refresh the page to see modifications.

I don't know if this is a bug or if it's intentional ? If it's intentional, then everything's fine.

Tomorrow I'll do some more test. It's getting late here 😛

datitisev

Wlork This is my fault for bundling those changes with that PR, I thought I had separated them into the other one to be honest. But that's good, because those are not breaking issues and just simple regressions. Thank you, though.

Wlork BUT ! By deactivating FoF Polls (no purge) and reactivating it, the polls reappeared in v2 🙂 !

You probably needed a cache clear. You were using the old code which had polls associated with discussions, of which it found none once the move to post association was made.

EDIT: I've fixed the issue with the vote count remaining. The issue regarding changes to the poll is fixed in the 2nd PR, which if you want to test, you can do with composer require fof/polls:dev-ds/more-breaking-v2-changes (contains v2 DB breaking changes from ds/move-polls-posts)

Wlork

@datitisev

I tried again and no problem with SQL 🙂
However, you need to remember to deactivate (no purge !) and reactivate extension FoF Polls to "transform" v1 polls into v2

And I was able to test more v2 polls.

Bugs :

Affected : everyone

If we make any changes (title, answers, images, options, end date, etc.) to our survey, we have to refresh the page manually to see the changes.

You've made changes to the way you edit a poll (and I like it). I think this bug comes from this modification, because v1 doesn't have this problem.

Affected : those who don't have "View results without voting" permission.

If we cancel our vote (our last choice, in the case of multiple answers), the count (%) remains. You'll have to refresh the page manually to reset it to zero.

I haven't noticed any other issues 🙂

If you want me to test v2 polls in its entirety, I'll do it 🙂

Wlork

datitisev You probably needed a cache clear. You were using the old code which had polls associated with discussions, of which it found none once the move to post association was made.

That's right, just clear the cache 🙂

Wlork Affected : everyone
If we make any changes (title, answers, images, options, end date, etc.) to our survey, we have to refresh the page manually to see the changes.

You've made changes to the way you edit a poll (and I like it). I think this bug comes from this modification, because v1 doesn't have this problem.

Fixed ! 🙂

Other issue :

However, when you add a poll to an existing post, you have to manually refresh the page to see it appear....

datitisev I've fixed the issue with the vote count remaining.

Fixed 🙂

Others issues :

When you delete a post, the poll(s) are not hidden.
member can create a poll in discussion or on one of its existing posts but don't have the permission to create a poll in a post.

Due to the permission issue, I wasn't able to test further. Let me know when you update the test extension 🙂

Eldenroot

Oshvam definitely needed!!!

datitisev

Wlork I fixed those issues, except maybe the last? I thought I remembered reproducing that permission issue, but I no longer can (even when I revert my changes). I also did a lot of other permissions / visibility scoping changes, so who knows.

If you find anything else, could you start a review comment on the PR itself? I'd rather move the conversation there so we're not spamming this discussion even more with a one-on-one conversation 😅.

Thank you for all this testing though 🙏 really appreciated.

Wlork

datitisev I fixed those issues, except maybe the last? I thought I remembered reproducing that permission issue, but I no longer can (even when I revert my changes). I also did a lot of other permissions / visibility scoping changes, so who knows.

I confirme, everything has been fixed 🙂 except :

member can create a poll in discussion or on one of its existing posts but don't have the permission to create a poll in a post.

This is the only problem I can see 🙁

As admin, I don't have an issue. I can create a poll in a discussion, in a post or in an existing post.

As a member, I can create a poll in a discussion or in an existing post. But I can't create a poll in a post.... I have to write something first, validate my answer and then "Add poll" (like an existing discussion).

datitisev If you find anything else, could you start a review comment on the PR itself? I'd rather move the conversation there so we're not spamming this discussion even more with a one-on-one conversation 😅.

😅 I don't use Githud much, but I'll think about it next time.

datitisev Thank you for all this testing though 🙏 really appreciated.

It's normal to help you, you're already doing an amazing work 🙂 !

datitisev

Wlork I was able to reproduce with the post edit perm set to until next reply. I modified the permission check to only check for editing perms if the post exists (i.e. not when posting one). Should be working now.

Wlork

datitisev I posted on GitHud : FriendsOfFlarum/polls74

😉

datitisev

2.0.0

🛑 BACKUP BEFORE UPGRADING TO THIS VERSION 🛑
This version contains database refactors that make the data incompatible with 1.x if you try to downgrade.
If you encounter errors, you WILL need to have a backup of all the polls tables available to go back to 1.4.2. Permission names have also changed, so a backup of group_permissions would also be helpful.

Massive thanks to @Wlork for their help testing all these changes!

Upgrading

Save a backup of your database -- mostly the polls, poll_votes, poll_options, and group_permissions tables -- before continuing. If you don't have any polls in your forum and haven't configured polls permissions, you can skip this step.

The migration process will delete polls in discussions that don't have associated first posts (discussion's first_post_id = null and no post exists with number = 1). These polls would not have been visible in v1, and so removing them should (theoretically) not cause any visible data loss - check the Flarum log after migrating to see if any polls were deleted.

composer remove reflar/polls # only if you have it installed - otherwise it won't upgrade to v2
composer require fof/polls
php flarum migrate
php flarum cache:clear

Changelog

Drop flatpickr (FriendsOfFlarum/polls72)
Create posts with polls (FriendsOfFlarum/polls73)
Move voters button next to heading
Add polls to existing posts
Separate edit permission into own created polls & polls in own posts
- To be able to edit a poll, one of the following conditions must be true:
  - User has poll moderating permission (edit & remove polls)
  - User can edit post, created poll, poll hasn't ended, and user has edit own polls permission
  - User can edit post, created post, poll hasn't ended, and user has edit polls in own posts permission
- If post editing permission is set to reply, and user cannot edit their post (because a reply was posted) and doesn't have the poll moderate permission, they won't be able to edit the polls in said post

Full Changelog: FriendsOfFlarum/polls1.4.2 → 2.0.0

Wlork

datitisev Massive thanks to @Wlork for their help testing all these changes!

🤝

Thanks to you for making these changes, it's a big update ! 😃

Oshvam

datitisev When I run

composer require fof/polls
php flarum migrate
php flarum cache:clear

It does not update. I still see the previous version of fof/polls. Is there a step I missed?

Steve33

datitisev whitemode does not look good.

Wlork

@datitisev

We've detected a bug.

When we create a poll in a non existing discussion or post, when we want to modify the poll before you send the message, the end date is automatically set. Impossible to delete. If we delete it, it comes back with 01/01/1970.....

You have to cancel everything and restart the creation of discussion or post without modifying the poll in order to pass.

I could be wrong, but that would explain the weird bug I had during the test.

datitisev

2.0.1

Add setting to change max options allowed in polls
Fix poll end date set to 0 (start of Unix time is 1970) when editing a poll before posting (Wlork)
Add 'hide votes' option until poll has ended
- Nobody can see vote count or voters if the poll has not ended (this includes admin & owner for now)
Fix poll end date being able to be set past 2038 -- SQL column currently maxes out at 2038/01/18
Convert poll options into single settings column
- Since we don't query DB using these options, they can just be a JSON field to decrease the amt of columns
- The old columns will remain until it's clear that the migration works well and that they can be removed w/o issue

Wlork

datitisev Thank you so much !

I've seen your FriendsOfFlarum/polls76

I'll give my opinion later this week (in Github)

m4v3rick

Flarum core: 1.8.1
PHP version: 8.2.8
MySQL version: 10.3.39-MariaDB-0+deb10u1

My composer.json contains following lines

"reflar/polls": "^1.3",
 "fof/polls": "*",

If I try
composer require fof/polls

I get

Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - Root composer.json requires reflar/polls ^1.3 -> satisfiable by reflar/polls[1.3.0, ..., 1.3.4].
    - reflar/polls[1.3.0, ..., 1.3.4] require flarum/core ^0.1.0-beta.8 -> found flarum/core[v0.1.0-beta.8, ..., v0.1.0-beta.16] but it does not match your minimum-stability.

Use the option --with-all-dependencies (-W) to allow upgrades, downgrades and removals for packages currently locked to specific versions.
You can also try re-running composer require with an explicit version constraint, e.g. "composer require fof/polls:*" to figure out if any version is installable, or "composer require fof/polls:^2.1" if you know which you need.

Do I need to remove reflar/polls? Or try
composer require fof/polls:*

Thanks!

datitisev

m4v3rick If you've used reflar/polls in the past, you'll want to remove it BUT install fof/polls ^1 (through composer require fof/polls ^1. Then, after enabling the extension, you can run the require command again without the version constraint.

If you haven't used reflar/polls before (as in enabled, not just had installed & disabled), then you can just remove it without issue and go straight to fof/polls v2.

Hope this makes sense.

datitisev

2.1.0

Make help text sticky
Add 'vote' button for multiple votes at once w/o vote change perm
- This UI only appears if the user cannot change votes & can vote for multiple options, allowing them to select all options they want to vote for before sending the data to Flarum
Add poll option to prevent users from changing their vote

NOTE: It seems seeing the options you yourself voted now might be hard - or even impossible - after this change, since it removes the checkboxes. I'll see about making it clearer what you voted for vs others, but I don't have time for it today.

datitisev

2.1.1

Clearly show voted-for options again
Use mix-blend-mode to make option text more readable
- Depending on the primary & secondary colors your forum uses (and light/dark mode), this might make it look better or worse. It can be disabled through a setting in the admin panel.
Adjust some other colors to not be hardcoded

Screenshots

Custom Mixing Options

if you wish to select a custom mixing option yourself (because eg. one of them looks better with your setup), you can do so with custom LESS.

.Post-poll .PollOptions .PollAnswer {
    &-checkbox, &-text {
        & when (@config-dark-mode =true) {
            mix-blend-mode: <value in dark mode>;
        }
        & when (@config-dark-mode =false) {
            mix-blend-mode: <value in light mode>;
        }
    }
}

Wlork

@datitisev

I have a question about 2.1.0

I have a question:

If I put "change votes" permission to members.
If I disable "change votes" option when creating a poll.

Members can change their votes ? As Admin, I can do it.... Is this normal ?

datitisev

Wlork In Flarum, admins generally have permission to do anything. Members shouldn't be able to change their votes in that poll, but admins will be able to unless explicitly stated. I don't know what option makes the most sense here.

« Previous Page Next Page »