FriendsOfFlarum Subscribed

nitaaikumar

Ralkage The emails for new discussions show this message but there are no contents of the first post, only the 3 dashes. Same issue like the pretty email extension. Is it the expected behavior or a bug? It would be good if the whole contents of the first of a new discussion are included in the sent email. Just like the full content shown in default reply emails. Thanks.


Additionally, you can find the contents of the first post in this new discussion below
--

Ralkage

nitaaikumar possibly a bug, would need to investigate 🙂

What email provider are you using to receive email?

nitaaikumar

Ralkage What email provider are you using to receive email?

Yes please. Gmail. The full benefit of having the new subscription option for all all new discussions in this extension is if we receive the full first post by email. It would make it so convenient of not having to come to the forum to read it. I am using the Amazon SES php mail driver. Should I change it to the default mail and check too? Most probably it may be happening for that to. Thanks.

nitaaikumar

Ralkage possibly a bug, would need to investigate

@datitisev has found and fixed the issue for the Pretty Mail extension. Beta 9 removed the contentHtml attribute which is used in the post content for the Subscribed emails. Could you also please replace it with the default attribute found in Flarums's non-html emails which show the full content ie: $blueprint->post->contentHtml to $blueprint->post->formatContent() in the Subscribe extension templates too please?

As per my request here and @jordanjay29's suggestion, can you please add an option to subscribe by email to new posts which go into the approval queue also? It will a great boon to us the admins and mods of forums who have users who post via approval.

Ok @datitisev is kindly doing this now. Thanks.

datitisev

0.2.0

!! REQUIRES FLARUM BETA 10
Subscribe to unapproved posts - receive notifications when a post is created that needs approval
- requires flarum/approval
- notifications disappear when post is approved/deleted
Move notifications to queues
Fix discussion & post visibility issues (hopefully)
Use display name for notifications instead of username
Do not send discussion created notifications to users that have already read the first post
- for e.g. mods that approve discussions, this would result in a notification of a discussion they had already looked at
Properly show post content in emails

Updating

composer require fof/subscribed

nitaaikumar

datitisev Thanks so much. Where is this setting to subscribe by email to the unapproved posts for the admins or mods? I can't see in the Profile or Permissions. Or is it automatically switched on for admins and mods which is great if it is. Will check if the unapproved new discussion emails will stop going to the users who have subscribed to receive all discussions by email and whether they get its full text by email. Please do fix the Follow Tags extension also so that unapproved posts emails don't go the users who have followed a tag at your convenience. Thanks again.

nitaaikumar

datitisev Ok I have tested your kind updates. Now we are receiving the full text of the new discussion first posts by email. And also after this first post of a new discussion is approved, the other users who have subscribed to all new discussions are also getting its full text by email. Approval emails are coming to the admin with full text of both new discussions and new posts. It is so perfect now.

There is only one bug now with approval. When a reply post is approved, the follow tag users subscribed to all the posts in the discussions of the tag they follow are no longer getting that approved post by email, not even an email. Just like they get when the first post in a new discussion is approved. So the Subscribed extension is fixed now. But there is this bug remaining in the Follow Tags extension with regards to approval.

nitaaikumar

datitisev A further follow up. Actually, with Follow Tags 0.3.1 update, all email notfications to other users of the posts in the dicussions of the followed tag have stopped, including even the ones which don't go into the approval queue. Sorry if I am posting in the wrong extension thread, but since these new updates to both the extensions are approval related, I thought it will be easier to post here itself.

datitisev

nitaaikumar in the permissions it should be found at the bottom of the moderate section. Make sure the extension did update to 0.2.0 though.

nitaaikumar

datitisev Ok now I see it now after refreshing cache. Thanks. Will test all and let you know.

datitisev

nitaaikumar all email notfications to other users of the posts in the dicussions of the followed tag have stopped

Not sure about this... email is handled by Flarum notifications. If the web notifications are working, then it is not an extension problem unless you see errors related to the blade files. 🤷‍♂️.

Post notifications are also only sent if the user has read the last post on the discussion, if that's what you are referring to.

[deleted]

Well, I have just tested FoF Subscribed 0.2.0 (with Flarum beta 10), but post/discussion in email is not visible.

discussionCreatedblade.php has this lines:

Additionally, you can find the contents of the first post in this new discussion below
---

{{ $blueprint->discussion->firstPost->content }}

but text/content below --- is clipped...

Also, in domain.com/settings we now have a new option which is showed like this:
fof-subscribed.forum.settings.notify_post_unapproved_label

datitisev

[deleted] You might have to clear the cache for it to properly work... Pretty sure I added the locale string before tagging.

nitaaikumar

[deleted] It is working for me. It is showing the full text of the first post of a new discussion in Pretty Mail.

[deleted]

datitisev You might have to clear the cache

Hm... Cleared. But still the same...

nitaaikumar

[deleted] Oh yes, now I am also not getting the full text of new discussions.

nitaaikumar

datitisev Post notifications are also only sent if the user has read the last post on the discussion, if that's what you are referring to.

Oh you mean if an user has not read the last post of a discussion, then the email notifications about a new post in that discussion won't go to them even if they are subscribed to all posts in the discussions of a particular tag?

datitisev

nitaaikumar Oh I apologize, I have been mixing Follow Tags with Subscribed 😂. That would be correct, yes, but for fof/follow-tags. This extension only has individual post notifs for unapproved posts.

nitaaikumar

datitisev Thanks I got it. And it works. Now only thing the full text of the post is still not appearing in "Created a new discussion" emails as @[deleted] pointed out.

datitisev

0.2.3

0.2.1 Remove debug log
0.2.2 Fix post content for new discussions email not showing
0.2.3 Fix constructor of new discussion blueprint possibly erroring when deleting/restoring discussions

Updating

composer require fof/subscribed

nitaaikumar

datitisev Thanks, full post content of new discussions now showing in emails.

nitaaikumar

datitisev Thank you so much. A few more bugs have been introduced. I am testing with the latest versions for both extensions. Emails have stopped coming to admin for replies going to the approval queue. However, admin approval emails are coming fine for new discussions going to the approval queue. Also after approval, emails for replies are not going to the other users subscribed via Follow Tags like they were going before I updated to the latest Follow Tags version I think (I am not 100% sure). New discussions are going by email after approval to those who are subscribed. Please fix these reply approval issues.

« Previous Page Next Page »