FriendsOfFlarum Ban IPs

luceos

yinlangzi do you have entries in the posts table under the ip_address column?

yinlangzi

luceos cool,i find ip address in the sql list,thanks。

datitisev

yinlangzi What service have you chosen in the settings? ALso - where are you getting/seeing "can't get user's ip" text

Littlegolden

Is it wrong here? Should it be "unblock other users using this IP at the same time", right?
en.yml#L61

fof-ban-ips:
  lib:
    ban_ip_confirmation: Are you sure you want to unban this user and all other users not banned by other IPs?

datitisev

Littlegolden When you unban an IP, you also unban other users that only have used that banned IP. However, if another user has two banned IPs, and one of them is unbanned, they'll remain banned because they still have one banned IP.

Littlegolden

datitisev I see. tx

datitisev

0.2.0

Add support for Flarum beta 13
- Requires beta 12 or later

Updating

composer require fof/ban-ips

Littlegolden

datitisev There is no 0.2.0 package released.
https://github.com/FriendsOfFlarum/ban-ips/releases

datitisev

Littlegolden Oh whoops 🤦. Fixed now.

hrvoje_hr

Despite allowing moderators in permission to view and ban IP's, they don't see the option to ban IP.

datitisev

hrvoje_hr The option shouldn't appear on users that also have the ability to ban IPs. In other words, you cannot ban someone that has permission to ban people.

Ralkage

m4v3rick yes, that does make sense to make that permission work outside of the Admin CP especially for groups who can't view the Admin CP altogether 🙂

Feel free to submit a PR or wait until we have time to enhance this specific feature.

djalmasi the Banned IP list is currently only viewable in the Admin CP unfortunately 🙁 But, for your other issue, the one where you can't see the Ban IP button, are you trying to ban a user who is part of a group that cannot ban IP's? Please refer to datitisev's post with regards to what I'm asking 🙂

Can you also post the output of php flarum info ran from the root directory of your Flarum install? This can help with troubleshooting while knowing what other extensions you might have installed that could be conflicting.

hrvoje_hr

I know that, but maybe I wasn't clear. Moderators can't ban any user IP's even when they are allowed to do that under the permissions tab.

datitisev

hrvoje_hr Hm, odd... Can you be more specific? Do they see the button to ban IPs? Do they get a permission error when they try to do so?

hrvoje_hr

datitisev they don't see Ban IP buttons. Neither on the post options, either on the profile.

tankerkiller125

hrvoje_hr Is there possibly a API Cache thing going on here? Do you use any services like Cloudflare?

m4v3rick

Same problem here:
"View banned IP address list" and "Ban IP(s)" for Supermods, but they can't view the list. Of course, they can't go into the backend, which they shouldn't, but there could be a seperate Ban IP(s) List for them if the right has been gained.

djalmasi

Still same problem 🙁 If i allow the permission Eg on admin group, the admin can't ban, didn't see the button and didn't see the banned ip lists.

djalmasi

Ralkage
I allowed the permission, but the button does not appear.

And if i open the menu, with a default serveradmin group.

m4v3rick

Ralkage Feel free to submit a PR or wait until we have time to enhance this specific feature.

Thanks for your answer. Right now I'm fine with waiting. We agreed on an internal workflow in the meantime.

Ralkage

djalmasi yep, you are indeed correct, this is a bug.

@datitisev I was able to reproduce this locally by creating a new group, giving that group the ability to ban users, assign a user to that new group, used FoF Impersonate to log in as that user who has this special group assigned to them, and alas no "Ban IP" button under PostControls for just banning normal users/members without this permission.

Edit: Even though this new group has the permission to Ban IP's via PostControls, canBanIP still returns false for whatever reason. The canBanIP user attribute, on the other hand, is set to true for this user I was testing with.

Only thing I can really think of right now is that this can be removed since there's already a canBanIP attribute via the UserSerializer that is already used for the permissions check. I'm not even sure how that post attribute is even able to return true in code or even changed in the UI. This line can also be changed to where !post.canBanIP is changed to !user.canBanIP which is the same permission check that is done in the UserControls section.

clarkwinkelmann

aaronlbpeterman are you referring to the issue described by Ralkage above? Can someone create a GitHub issue with the description so we don't forget to tackle it?

« Previous Page Next Page »