FriendsOfFlarum Drafts

BMoney

I also have the same, “You do not have permission to do that” error that others are getting. Even after I created a post from a saved draft, the draft still stays in the queue and is unable to be deleted.

[deleted]

I hope someone will find a quick fix 😃

Kyrne

0.1.4

Various bug fixes
Moved position of save button to right next to composer view controls.

Thanks to @nxta for this update!

nxta

Happy to give back.

Here's how it looks

I hadn't read this discussion before. I do not recognize the latest bugs being discussed here. Please see if maybe this update fixes it?

edit: Actually I think this fixes everything you discussed @[deleted] @BMoney @collins

nitaaikumar

nxta @Kyrne Thanks a lot for this update. I had to disable the extension due to these bugs and had to write longer posts in an external editor and then copy and paste. No more, thanks to both of you! Now I can write them and publish them later, i.e. scheduling is back is some form.

[deleted]

Thanks for the update, but my problem remains - still not able to delete drafts...

Kyrne

theportablegeek therealsujitk [deleted]

I wasn't able to reproduce this bug on my end, but I had a guess on what the issue was. Try updating this extension to 0.1.5 to see if that fixes your issue.

nitaaikumar

I am not able to see the floppy save button on mobiles. Maybe because I have added some custom css suggested here about fixing mobile composer issues? I can delete drafts now @[deleted]

[deleted]

nitaaikumar I am not able to see the floppy save button on mobiles.

I saw it in bottom right corner when draft is minimised

tolgaaaltas

[deleted] I bet casual users never can't find this. 😃

nxta

Flarum core has a CSS rule saying "On mobile, hide all composer controls except the back control".

As a workaround, right now you can get the button to show with this custom css

@media (max-width: 767px) {
    .normal .ComposerBody-header>li:first-child {
        margin-left: 75px;
        margin-right: 75px;
    }

    .Composer:not(.minimized) .Composer-controls li.item-save-draft {
        display: block;
        position: absolute !important;
        z-index: 1001;
        top: 0 !important;
        left: 35px;

        >.Button {
            height: 46px;
            padding: 13px !important;
        }
    }
}

It's not something I would want to add to the extension. Rather it should be changed in core since it prevents being able to extend the composer controls.

<vodka>
I'm afraid Flarum's CSS is a serious mess that doesn't implement any of the principles of extensibility that Flarum stands for. As impressed as I am with the backend architecture, I'm shocked at the lack thereof in the front-end, the way CSS is applied specifically. The sheer number of dead rules and uses of !important show that.
</vodka>

nxta

Quoting myself from another discussion, because just dropping this there doesn't allow for further discussion. Also I want to suggest a solution.

nxta <vodka>
I'm afraid Flarum's CSS is a serious mess that doesn't implement any of the principles of extensibility that Flarum stands for. As impressed as I am with the backend architecture, I'm shocked at the lack thereof in the front-end, the way CSS is applied specifically. The sheer number of dead rules and uses of !important show that.
</vodka>

What I personally think would fit Flarum like a glove is this

Harry Roberts' ITCSS - Inverted Triangle CSS architecture - https://itcss.io/
Rico Sta Cruz' RSCSS - For naming conventions - https://rscss.io/

Please check out these resources as they do a really good job of explaining it, much better than I could in a post.

Having worked according to these principles for years, working with Flarum feels like a step back, comparable to switching from OOP programming to procedural.

Recently I asked about the Mithril version and it seems that there is some work being done on a overhaul of the front-end. I hope you will also take the CSS architecture into account.

To keep an ever developing CSS codebase that a bunch of different people contribute to managable, you're going to need an architecture that supports that. Right now every extension allows devs to append CSS and it's wild west from there.

This is my opinion ofcourse. Considering what Flarum is today and how it stands for extensibility, if I had to overhaul its front-end from scratch, this would be my way to go. My two cents.

Dafterz

Amazing Extension! very nice because its running well on my flarum 🥳

[deleted]

I had issues with this extension, removed it (and manually deleted database table) and I wanted to use/test it with beta 12.

I got this error message after installation:

[2020-03-10 08:40:57] production.ERROR: PDOException: SQLSTATE[42S02]: Base table or view not found: 1146 Table 'TABLENAME.fl19_drafts' doesn't exist in /home/xxx/xxx/vendor/doctrine/dbal/lib/Doctrine/DBAL/Driver/PDOConnection.php:61 Stack trace: #0 /home/xxx/xxx/vendor/doctrine/dbal/lib/Doctrine/DBAL/Driver/PDOConnection.php(61): PDO->prepare('select * from...', Array)
#1 /home/xxx/xxx/vendor/illuminate/database/Connection.php(326): Doctrine\DBAL\Driver\PDOConnection->prepare('select * from ...') #2 /home/xxx/xxx/vendor/illuminate/database/Connection.php(657): Illuminate\Database\Connection->Illuminate\Database\{closure}('select * from...', Array)
#3 /home/xxx/xxx/vendor/illuminate/database/Connection.php(624): Illuminate\Database\Connection->runQueryCallback('select * from ...', Array, Object(Closure)) #4 /home/xxx/xxx/vendor/illuminate/database/Connection.php(333): Illuminate\Database\Connection->run('select * from...', Array, Object(Closure))
#5 /home/xxx/xxx/vendor/illuminate/database/Query/Builder.php(2095): Illuminate\Database\Connection->select('select * from ...', Array, true) #6 /home/xxx/xxx/vendor/illuminate/database/Query/Builder.php(2083): Illuminate\Database\Query\Builder->runSelect() #7 /home/xxx/xxx/vendor/illuminate/database/Query/Builder.php(2569): Illuminate\Database\Query\Builder->Illuminate\Database\Query\{closure}() #8 /home/xxx/xxx/vendor/illuminate/database/Query/Builder.php(2084): Illuminate\Database\Query\Builder->onceWithColumns(Array, Object(Closure)) #9 /home/xxx/xxx/vendor/illuminate/database/Eloquent/Builder.php(519): Illuminate\Database\Query\Builder->get(Array) (...)

What can I do to fix this?

clarkwinkelmann

[deleted] if you manually deleted an extension's table, you should also manually remove the rows in migrations that go with those tables. You can check the extension column of migrations to see which migrations belong to which extension.

[deleted]

clarkwinkelmann if you manually deleted an extension's table, you should also manually remove the rows in migrations that go with those tables. You can check

Found it... But I really can't find the way to delete it... ❓️

clarkwinkelmann

[deleted] older versions of phpMyAdmin are not able to delete rows that don't have a primary key. You will have to use SQL commands.

If you manually rolled back all of them, you can delete them in one go with delete from migrations where extension = 'fof-drafts' via the SQL tab.

[deleted]

Oh, man! 😀
I don't know what to say! Thank you is the least I can say, really...

4 rows affected. (Query took 0.0091 seconds.)
delete from TABLEPREFIX_migrations where extension = 'fof-drafts'

php flarum migrate php flarum cache:clear must be used too...

However, I have an old problem - drafts can't be deleted or saved (it always shows empty content).

😀

therealsujitk

I can't delete my draft

theportablegeek

Hey Flarum Folks (and @Kyrne ),

Just wondering if you can help, as I seem to be running into the same issue as therealsujitk , where I am able to create drafts and post them, but they do not disappear, and I can't delete them...

I get a

"You don't have permission to do that"

error.

Here is what appears in my debug view:

POST https://subdomain.domain.TLD/api/drafts/1

{
  "errors": [
    {
      "status": "403",
      "code": "permission_denied",
      "detail": "Flarum\\User\\Exception\\PermissionDeniedException in /home/~/public_html/~/vendor/fof/drafts/src/Command/DeleteDraftHandler.php:36\nStack trace:\n#0 /home/~/public_html/~/vendor/illuminate/bus/Dispatcher.php(90): FoF\\Drafts\\Command\\DeleteDraftHandler->handle(Object(FoF\\Drafts\\Command\\DeleteDraft))\n#1 /home/~/public_html/~/vendor/illuminate/pipeline/Pipeline.php(128): Illuminate\\Bus\\Dispatcher->Illuminate\\Bus\\{closure}(Object(FoF\\Drafts\\Command\\DeleteDraft))\n#2 /home/~/public_html/~/vendor/illuminate/pipeline/Pipeline.php(104): Illuminate\\Pipeline\\Pipeline->Illuminate\\Pipeline\\{closure}(Object(FoF\\Drafts\\Command\\DeleteDraft))\n#3 /home/~/public_html/~/vendor/illuminate/bus/Dispatcher.php(98): Illuminate\\Pipeline\\Pipeline->then(Object(Closure))\n#4 /home/~/public_html/~/vendor/illuminate/bus/Dispatcher.php(76): Illuminate\\Bus\\Dispatcher->dispatchNow(Object(FoF\\Drafts\\Command\\DeleteDraft))\n#5 /home/~/public_html/~/vendor/fof/drafts/src/Api/Controller/DeleteDraftController.php(42): Illuminate\\Bus\\Dispatcher->dispatch(Object(FoF\\Drafts\\Command\\DeleteDraft))\n#6 /home/~/public_html/~/vendor/flarum/core/src/Api/Controller/AbstractDeleteController.php(24): FoF\\Drafts\\Api\\Controller\\DeleteDraftController->delete(Object(Laminas\\Diactoros\\ServerRequest))\n#7 /home/~/public_html/~/vendor/flarum/core/src/Http/RouteHandlerFactory.php(38): Flarum\\Api\\Controller\\AbstractDeleteController->handle(Object(Laminas\\Diactoros\\ServerRequest))\n#8 /home/~/public_html/~/vendor/flarum/core/src/Http/Middleware/DispatchRoute.php(65): Flarum\\Http\\RouteHandlerFactory->Flarum\\Http\\{closure}(Object(Laminas\\Diactoros\\ServerRequest), Array)\n#9 /home/~/public_html/~/vendor/laminas/laminas-stratigility/src/Next.php(61): Flarum\\Http\\Middleware\\DispatchRoute->process(Object(Laminas\\Diactoros\\ServerRequest), Object(Closure))\n#10 /home/~/public_html/~/vendor/flarum/core/src/Http/Middleware/SetLocale.php(50): Laminas\\Stratigility\\Next->handle(Object(Laminas\\Diactoros\\ServerRequest))\n#11 /home/~/public_html/~/vendor/laminas/laminas-stratigility/src/Next.php(61): Flarum\\Http\\Middleware\\SetLocale->process(Object(Laminas\\Diactoros\\ServerRequest), Object(Laminas\\Stratigility\\Next))\n#12 /home/~/public_html/~/vendor/flarum/core/src/Http/Middleware/CheckCsrfToken.php(31): Laminas\\Stratigility\\Next->handle(Object(Laminas\\Diactoros\\ServerRequest))\n#13 /home/~/public_html/~/vendor/laminas/laminas-stratigility/src/Next.php(61): Flarum\\Http\\Middleware\\CheckCsrfToken->process(Object(Laminas\\Diactoros\\ServerRequest), Object(Laminas\\Stratigility\\Next))\n#14 /home/~/public_html/~/vendor/flarum/core/src/Http/Middleware/AuthenticateWithHeader.php(55): Laminas\\Stratigility\\Next->handle(Object(Laminas\\Diactoros\\ServerRequest))\n#15 /home/~/public_html/~/vendor/laminas/laminas-stratigility/src/Next.php(61): Flarum\\Http\\Middleware\\AuthenticateWithHeader->process(Object(Laminas\\Diactoros\\ServerRequest), Object(Laminas\\Stratigility\\Next))\n#16 /home/~/public_html/~/vendor/flarum/core/src/Http/Middleware/AuthenticateWithSession.php(32): Laminas\\Stratigility\\Next->handle(Object(Laminas\\Diactoros\\ServerRequest))\n#17 /home/~/public_html/~/vendor/laminas/laminas-stratigility/src/Next.php(61): Flarum\\Http\\Middleware\\AuthenticateWithSession->process(Object(Laminas\\Diactoros\\ServerRequest), Object(Laminas\\Stratigility\\Next))\n#18 /home/~/public_html/~/vendor/flarum/core/src/Http/Middleware/RememberFromCookie.php(51): Laminas\\Stratigility\\Next->handle(Object(Laminas\\Diactoros\\ServerRequest))\n#19 /home/~/public_html/~/vendor/laminas/laminas-stratigility/src/Next.php(61): Flarum\\Http\\Middleware\\RememberFromCookie->process(Object(Laminas\\Diactoros\\ServerRequest), Object(Laminas\\Stratigility\\Next))\n#20 /home/~/public_html/~/vendor/flarum/core/src/Http/Middleware/StartSession.php(61): Laminas\\Stratigility\\Next->handle(Object(Laminas\\Diactoros\\ServerRequest))\n#21 /home/~/public_html/~/vendor/laminas/laminas-stratigility/src/Next.php(61): Flarum\\Http\\Middleware\\StartSession->process(Object(Laminas\\Diactoros\\ServerRequest), Object(Laminas\\Stratigility\\Next))\n#22 /home/~/public_html/~/vendor/flarum/core/src/Api/Middleware/FakeHttpMethods.php(29): Laminas\\Stratigility\\Next->handle(Object(Laminas\\Diactoros\\ServerRequest))\n#23 /home/~/public_html/~/vendor/laminas/laminas-stratigility/src/Next.php(61): Flarum\\Api\\Middleware\\FakeHttpMethods->process(Object(Laminas\\Diactoros\\ServerRequest), Object(Laminas\\Stratigility\\Next))\n#24 /home/~/public_html/~/vendor/flarum/core/src/Http/Middleware/ParseJsonBody.php(28): Laminas\\Stratigility\\Next->handle(Object(Laminas\\Diactoros\\ServerRequest))\n#25 /home/~/public_html/~/vendor/laminas/laminas-stratigility/src/Next.php(61): Flarum\\Http\\Middleware\\ParseJsonBody->process(Object(Laminas\\Diactoros\\ServerRequest), Object(Laminas\\Stratigility\\Next))\n#26 /home/~/public_html/~/vendor/flarum/core/src/Http/Middleware/HandleErrors.php(57): Laminas\\Stratigility\\Next->handle(Object(Laminas\\Diactoros\\ServerRequest))\n#27 /home/~/public_html/~/vendor/laminas/laminas-stratigility/src/Next.php(61): Flarum\\Http\\Middleware\\HandleErrors->process(Object(Laminas\\Diactoros\\ServerRequest), Object(Laminas\\Stratigility\\Next))\n#28 /home/~/public_html/~/vendor/laminas/laminas-stratigility/src/MiddlewarePipe.php(84): Laminas\\Stratigility\\Next->handle(Object(Laminas\\Diactoros\\ServerRequest))\n#29 /home/~/public_html/~/vendor/middlewares/request-handler/src/RequestHandler.php(84): Laminas\\Stratigility\\MiddlewarePipe->process(Object(Laminas\\Diactoros\\ServerRequest), Object(Laminas\\Stratigility\\Next))\n#30 /home/~/public_html/~/vendor/laminas/laminas-stratigility/src/Next.php(61): Middlewares\\RequestHandler->process(Object(Laminas\\Diactoros\\ServerRequest), Object(Laminas\\Stratigility\\Next))\n#31 /home/~/public_html/~/vendor/middlewares/base-path-router/src/BasePathRouter.php(97): Laminas\\Stratigility\\Next->handle(Object(Laminas\\Diactoros\\ServerRequest))\n#32 /home/~/public_html/~/vendor/laminas/laminas-stratigility/src/Next.php(61): Middlewares\\BasePathRouter->process(Object(Laminas\\Diactoros\\ServerRequest), Object(Laminas\\Stratigility\\Next))\n#33 /home/~/public_html/~/vendor/laminas/laminas-stratigility/src/Middleware/OriginalMessages.php(42): Laminas\\Stratigility\\Next->handle(Object(Laminas\\Diactoros\\ServerRequest))\n#34 /home/~/public_html/~/vendor/laminas/laminas-stratigility/src/Next.php(61): Laminas\\Stratigility\\Middleware\\OriginalMessages->process(Object(Laminas\\Diactoros\\ServerRequest), Object(Laminas\\Stratigility\\Next))\n#35 /home/~/public_html/~/vendor/middlewares/base-path/src/BasePath.php(53): Laminas\\Stratigility\\Next->handle(Object(Laminas\\Diactoros\\ServerRequest))\n#36 /home/~/public_html/~/vendor/laminas/laminas-stratigility/src/Next.php(61): Middlewares\\BasePath->process(Object(Laminas\\Diactoros\\ServerRequest), Object(Laminas\\Stratigility\\Next))\n#37 /home/~/public_html/~/vendor/laminas/laminas-stratigility/src/MiddlewarePipe.php(84): Laminas\\Stratigility\\Next->handle(Object(Laminas\\Diactoros\\ServerRequest))\n#38 /home/~/public_html/~/vendor/laminas/laminas-stratigility/src/MiddlewarePipe.php(73): Laminas\\Stratigility\\MiddlewarePipe->process(Object(Laminas\\Diactoros\\ServerRequest), Object(Laminas\\Stratigility\\EmptyPipelineHandler))\n#39 /home/~/public_html/~/vendor/laminas/laminas-httphandlerrunner/src/RequestHandlerRunner.php(96): Laminas\\Stratigility\\MiddlewarePipe->handle(Object(Laminas\\Diactoros\\ServerRequest))\n#40 /home/~/public_html/~/vendor/flarum/core/src/Http/Server.php(42): Laminas\\HttpHandlerRunner\\RequestHandlerRunner->run()\n#41 /home/~/public_html/~/index.php(22): Flarum\\Http\\Server->listen()\n#42 {main}"
    }
  ]
}

therealsujitk

Kyrne Yup, it's fixed now!

Some ideas for future releases:

Would be great if the drafts feature was available for posts too.
Would be great if drafts were saved automatically when typed so that the user can continue the draft incase the browser crashes for some reason.

theportablegeek

Kyrne You are amazing 🙏 🙏 🙏

Kyrne

therealsujitk will def add at least the second one when I have some time.

« Previous Page Next Page »