FriendsOfFlarum Drafts

clarkwinkelmann

[deleted] older versions of phpMyAdmin are not able to delete rows that don't have a primary key. You will have to use SQL commands.

If you manually rolled back all of them, you can delete them in one go with delete from migrations where extension = 'fof-drafts' via the SQL tab.

[deleted]

Oh, man! 😀
I don't know what to say! Thank you is the least I can say, really...

4 rows affected. (Query took 0.0091 seconds.)
delete from TABLEPREFIX_migrations where extension = 'fof-drafts'

php flarum migrate php flarum cache:clear must be used too...

However, I have an old problem - drafts can't be deleted or saved (it always shows empty content).

😀

therealsujitk

I can't delete my draft

theportablegeek

Hey Flarum Folks (and @Kyrne ),

Just wondering if you can help, as I seem to be running into the same issue as therealsujitk , where I am able to create drafts and post them, but they do not disappear, and I can't delete them...

I get a

"You don't have permission to do that"

error.

Here is what appears in my debug view:

POST https://subdomain.domain.TLD/api/drafts/1

{
  "errors": [
    {
      "status": "403",
      "code": "permission_denied",
      "detail": "Flarum\\User\\Exception\\PermissionDeniedException in /home/~/public_html/~/vendor/fof/drafts/src/Command/DeleteDraftHandler.php:36\nStack trace:\n#0 /home/~/public_html/~/vendor/illuminate/bus/Dispatcher.php(90): FoF\\Drafts\\Command\\DeleteDraftHandler->handle(Object(FoF\\Drafts\\Command\\DeleteDraft))\n#1 /home/~/public_html/~/vendor/illuminate/pipeline/Pipeline.php(128): Illuminate\\Bus\\Dispatcher->Illuminate\\Bus\\{closure}(Object(FoF\\Drafts\\Command\\DeleteDraft))\n#2 /home/~/public_html/~/vendor/illuminate/pipeline/Pipeline.php(104): Illuminate\\Pipeline\\Pipeline->Illuminate\\Pipeline\\{closure}(Object(FoF\\Drafts\\Command\\DeleteDraft))\n#3 /home/~/public_html/~/vendor/illuminate/bus/Dispatcher.php(98): Illuminate\\Pipeline\\Pipeline->then(Object(Closure))\n#4 /home/~/public_html/~/vendor/illuminate/bus/Dispatcher.php(76): Illuminate\\Bus\\Dispatcher->dispatchNow(Object(FoF\\Drafts\\Command\\DeleteDraft))\n#5 /home/~/public_html/~/vendor/fof/drafts/src/Api/Controller/DeleteDraftController.php(42): Illuminate\\Bus\\Dispatcher->dispatch(Object(FoF\\Drafts\\Command\\DeleteDraft))\n#6 /home/~/public_html/~/vendor/flarum/core/src/Api/Controller/AbstractDeleteController.php(24): FoF\\Drafts\\Api\\Controller\\DeleteDraftController->delete(Object(Laminas\\Diactoros\\ServerRequest))\n#7 /home/~/public_html/~/vendor/flarum/core/src/Http/RouteHandlerFactory.php(38): Flarum\\Api\\Controller\\AbstractDeleteController->handle(Object(Laminas\\Diactoros\\ServerRequest))\n#8 /home/~/public_html/~/vendor/flarum/core/src/Http/Middleware/DispatchRoute.php(65): Flarum\\Http\\RouteHandlerFactory->Flarum\\Http\\{closure}(Object(Laminas\\Diactoros\\ServerRequest), Array)\n#9 /home/~/public_html/~/vendor/laminas/laminas-stratigility/src/Next.php(61): Flarum\\Http\\Middleware\\DispatchRoute->process(Object(Laminas\\Diactoros\\ServerRequest), Object(Closure))\n#10 /home/~/public_html/~/vendor/flarum/core/src/Http/Middleware/SetLocale.php(50): Laminas\\Stratigility\\Next->handle(Object(Laminas\\Diactoros\\ServerRequest))\n#11 /home/~/public_html/~/vendor/laminas/laminas-stratigility/src/Next.php(61): Flarum\\Http\\Middleware\\SetLocale->process(Object(Laminas\\Diactoros\\ServerRequest), Object(Laminas\\Stratigility\\Next))\n#12 /home/~/public_html/~/vendor/flarum/core/src/Http/Middleware/CheckCsrfToken.php(31): Laminas\\Stratigility\\Next->handle(Object(Laminas\\Diactoros\\ServerRequest))\n#13 /home/~/public_html/~/vendor/laminas/laminas-stratigility/src/Next.php(61): Flarum\\Http\\Middleware\\CheckCsrfToken->process(Object(Laminas\\Diactoros\\ServerRequest), Object(Laminas\\Stratigility\\Next))\n#14 /home/~/public_html/~/vendor/flarum/core/src/Http/Middleware/AuthenticateWithHeader.php(55): Laminas\\Stratigility\\Next->handle(Object(Laminas\\Diactoros\\ServerRequest))\n#15 /home/~/public_html/~/vendor/laminas/laminas-stratigility/src/Next.php(61): Flarum\\Http\\Middleware\\AuthenticateWithHeader->process(Object(Laminas\\Diactoros\\ServerRequest), Object(Laminas\\Stratigility\\Next))\n#16 /home/~/public_html/~/vendor/flarum/core/src/Http/Middleware/AuthenticateWithSession.php(32): Laminas\\Stratigility\\Next->handle(Object(Laminas\\Diactoros\\ServerRequest))\n#17 /home/~/public_html/~/vendor/laminas/laminas-stratigility/src/Next.php(61): Flarum\\Http\\Middleware\\AuthenticateWithSession->process(Object(Laminas\\Diactoros\\ServerRequest), Object(Laminas\\Stratigility\\Next))\n#18 /home/~/public_html/~/vendor/flarum/core/src/Http/Middleware/RememberFromCookie.php(51): Laminas\\Stratigility\\Next->handle(Object(Laminas\\Diactoros\\ServerRequest))\n#19 /home/~/public_html/~/vendor/laminas/laminas-stratigility/src/Next.php(61): Flarum\\Http\\Middleware\\RememberFromCookie->process(Object(Laminas\\Diactoros\\ServerRequest), Object(Laminas\\Stratigility\\Next))\n#20 /home/~/public_html/~/vendor/flarum/core/src/Http/Middleware/StartSession.php(61): Laminas\\Stratigility\\Next->handle(Object(Laminas\\Diactoros\\ServerRequest))\n#21 /home/~/public_html/~/vendor/laminas/laminas-stratigility/src/Next.php(61): Flarum\\Http\\Middleware\\StartSession->process(Object(Laminas\\Diactoros\\ServerRequest), Object(Laminas\\Stratigility\\Next))\n#22 /home/~/public_html/~/vendor/flarum/core/src/Api/Middleware/FakeHttpMethods.php(29): Laminas\\Stratigility\\Next->handle(Object(Laminas\\Diactoros\\ServerRequest))\n#23 /home/~/public_html/~/vendor/laminas/laminas-stratigility/src/Next.php(61): Flarum\\Api\\Middleware\\FakeHttpMethods->process(Object(Laminas\\Diactoros\\ServerRequest), Object(Laminas\\Stratigility\\Next))\n#24 /home/~/public_html/~/vendor/flarum/core/src/Http/Middleware/ParseJsonBody.php(28): Laminas\\Stratigility\\Next->handle(Object(Laminas\\Diactoros\\ServerRequest))\n#25 /home/~/public_html/~/vendor/laminas/laminas-stratigility/src/Next.php(61): Flarum\\Http\\Middleware\\ParseJsonBody->process(Object(Laminas\\Diactoros\\ServerRequest), Object(Laminas\\Stratigility\\Next))\n#26 /home/~/public_html/~/vendor/flarum/core/src/Http/Middleware/HandleErrors.php(57): Laminas\\Stratigility\\Next->handle(Object(Laminas\\Diactoros\\ServerRequest))\n#27 /home/~/public_html/~/vendor/laminas/laminas-stratigility/src/Next.php(61): Flarum\\Http\\Middleware\\HandleErrors->process(Object(Laminas\\Diactoros\\ServerRequest), Object(Laminas\\Stratigility\\Next))\n#28 /home/~/public_html/~/vendor/laminas/laminas-stratigility/src/MiddlewarePipe.php(84): Laminas\\Stratigility\\Next->handle(Object(Laminas\\Diactoros\\ServerRequest))\n#29 /home/~/public_html/~/vendor/middlewares/request-handler/src/RequestHandler.php(84): Laminas\\Stratigility\\MiddlewarePipe->process(Object(Laminas\\Diactoros\\ServerRequest), Object(Laminas\\Stratigility\\Next))\n#30 /home/~/public_html/~/vendor/laminas/laminas-stratigility/src/Next.php(61): Middlewares\\RequestHandler->process(Object(Laminas\\Diactoros\\ServerRequest), Object(Laminas\\Stratigility\\Next))\n#31 /home/~/public_html/~/vendor/middlewares/base-path-router/src/BasePathRouter.php(97): Laminas\\Stratigility\\Next->handle(Object(Laminas\\Diactoros\\ServerRequest))\n#32 /home/~/public_html/~/vendor/laminas/laminas-stratigility/src/Next.php(61): Middlewares\\BasePathRouter->process(Object(Laminas\\Diactoros\\ServerRequest), Object(Laminas\\Stratigility\\Next))\n#33 /home/~/public_html/~/vendor/laminas/laminas-stratigility/src/Middleware/OriginalMessages.php(42): Laminas\\Stratigility\\Next->handle(Object(Laminas\\Diactoros\\ServerRequest))\n#34 /home/~/public_html/~/vendor/laminas/laminas-stratigility/src/Next.php(61): Laminas\\Stratigility\\Middleware\\OriginalMessages->process(Object(Laminas\\Diactoros\\ServerRequest), Object(Laminas\\Stratigility\\Next))\n#35 /home/~/public_html/~/vendor/middlewares/base-path/src/BasePath.php(53): Laminas\\Stratigility\\Next->handle(Object(Laminas\\Diactoros\\ServerRequest))\n#36 /home/~/public_html/~/vendor/laminas/laminas-stratigility/src/Next.php(61): Middlewares\\BasePath->process(Object(Laminas\\Diactoros\\ServerRequest), Object(Laminas\\Stratigility\\Next))\n#37 /home/~/public_html/~/vendor/laminas/laminas-stratigility/src/MiddlewarePipe.php(84): Laminas\\Stratigility\\Next->handle(Object(Laminas\\Diactoros\\ServerRequest))\n#38 /home/~/public_html/~/vendor/laminas/laminas-stratigility/src/MiddlewarePipe.php(73): Laminas\\Stratigility\\MiddlewarePipe->process(Object(Laminas\\Diactoros\\ServerRequest), Object(Laminas\\Stratigility\\EmptyPipelineHandler))\n#39 /home/~/public_html/~/vendor/laminas/laminas-httphandlerrunner/src/RequestHandlerRunner.php(96): Laminas\\Stratigility\\MiddlewarePipe->handle(Object(Laminas\\Diactoros\\ServerRequest))\n#40 /home/~/public_html/~/vendor/flarum/core/src/Http/Server.php(42): Laminas\\HttpHandlerRunner\\RequestHandlerRunner->run()\n#41 /home/~/public_html/~/index.php(22): Flarum\\Http\\Server->listen()\n#42 {main}"
    }
  ]
}

Kyrne

theportablegeek therealsujitk [deleted]

I wasn't able to reproduce this bug on my end, but I had a guess on what the issue was. Try updating this extension to 0.1.5 to see if that fixes your issue.

therealsujitk

Kyrne Yup, it's fixed now!

Some ideas for future releases:

Would be great if the drafts feature was available for posts too.
Would be great if drafts were saved automatically when typed so that the user can continue the draft incase the browser crashes for some reason.

theportablegeek

Kyrne You are amazing 🙏 🙏 🙏

Kyrne

therealsujitk will def add at least the second one when I have some time.

[deleted]

Ver 0.1.5. solved my problems 😀 thanks!!!

fakruzaruret

I wrote long article and I forget session time duration. I clicked to save draft then the editor was closed and flarum gave me error (Oops.. Somethings went wrong ... ) and success (Draft saved) notification together. But my article has gone because editor was closed. I could not save. Can we prevent closing of editor window. You can try this. Sign in to flarum which draft ext. is enabled and open two tabs. Then write sometings and sign out on second tab. After this save your post by draft. You will see.

Ralkage

fakruzaruret maybe an auto-save feature after X amount of time? Your situation seems very unique as session timeouts do happen from time to time and I believe this feature suggestion should solve your issue.

fakruzaruret

Ralkage can I block closing of editor window without using close button (X) ?

iPurpl3x

This extension seems broken on beta 13, when posting a previously created draft, nothing happens, it's just gone. No error.

IanM

0.1.6

Improve UI of using drafts:

Load drafts list when opening the composer; this way, we avoid a situation where a new draft is being saved, no drafts have been loaded, and the user is presented with an empty draft list in the header.
Load draft count on page load separately from the draft list itself: this means that the count is always accurate.
Don't close the composer when saving drafts; this is behavior not used in any other product (imagine if Microsoft Word shut down whenever you pressed save).
When a new draft is created, save it as the composer component's stored draft, so that future saves will be treated as updates
Prevent duplicate save messages; ensure that the save message disappears and reappears when updating a draft so that the user clearly sees that the change was successsful, and not a left-over save message
Right now, the drafts dropdown is only shown if there are already cached drafts saved. However, this doesn't really work, since drafts aren't downloaded by default. Now, the dropdown button will always be shown, and the list of drafts will be loaded by clicking on it, as always.

Updating

composer require fof/drafts
php flarum cache:clear

Thank you @askvortsov for your work on this! 🙂

Operator

IanM imagine if Microsoft Word shut down whenever you pressed save

😂

Thoughtful update and fixes...
👏🏽@IanM
👏🏽@askvortsov

fakruzaruret

IanM Perfect!!!!!!

Ghost_chu

So there has a bug in 0.1.6.
Guest will receive the No Permission error while plugin trying to pull drafts list when they not logged in.

askvortsov

I'll open a PR to fix this, must have been introduced accidentally with the UI changes yesterday.

fakruzaruret

askvortsov Could you give an avarage time for the next release?

We get No Permission error 😀 I follow your improvements on github and you are great. Also next release solve the all problems.

sakibarifin

askvortsov Can't uninstall it. It says something went wrong error.

« Previous Page Next Page »