Premium WordPress Integration

clarkwinkelmann

hrvoje_hr ah yes Nightmode has been listed as incompatible in my documentation for a long time https://kilowhat.net/flarum/extensions/wordpress#compatibility

I'm surprised to hear it worked before. From what I've studied Night Mode is fundamentally incompatible with any extension that creates custom frontends, which include this Wordpress extension, my Backoffice extension and my Mithril2Html extension.

Still I'm surprised I didn't experience the issue when visiting your website. Was Nightmode temporarily disabled? Or maybe it has something to do with my system preferred theme and the auto mode of Nightmode, or just the fact I was logged out.

Unfortunately there is currently no way to make Nightmode compatible. A complete rewrite of Nightmode is needed.

hrvoje_hr

clarkwinkelmann Still I'm surprised I didn't experience the issue when visiting your website. Was Nightmode temporarily disabled?

Depends on when you visited my website. It's been deactivated for the last few hours, from 8 PM CET. Before, on 1.3 and earlier Flarum versions they both coexisted for two years without any issues. Through the CSS I forced all iframe comments elements into the day mode.

But after 1.3 > 1.6 Flarum upgrade yesterday, the comments iframe malfunctioned. Can there be a way to keep Night Mode on Flarum, but completely disable it in comments integration?

clarkwinkelmann

hrvoje_hr I'm not entirely sure where things stand with this. I would have to install Nighmode on my test forum and see what's wrong nowadays.

This is the issue I was originally referring to but I see it has been marked as fixed since version 1.2 of Nightmode FriendsOfFlarum/nightmode47

I see there were some important changes in both Nightmode versions 1.2 and 1.4. Maybe this was originally fixed and then broken again?

Do you know which version of Nightmode you were running prior to the update?

hrvoje_hr

clarkwinkelmann Do you know which version of Nightmode you were running prior to the update?

The previous one was 1.2.2. with Flarum 1.3. Before upgrading on Flarum 1.3 I was on Flarum Beta-16 with FoF Night Mode 0.4.0

hrvoje_hr

Does anyone have an issue when new WordPress comments threads on Flarum are automatically marked as read (greyed out) to users?

clarkwinkelmann

hrvoje_hr what's your setting for "Set the summary post as the last post of new discussions" under Comments integration?

If I remember correctly, when that setting is Off, discussions won't have a last post information and Flarum will show them like read discussions. This setting also impacts the sorting of discussions in the list.

https://kilowhat.net/flarum/extensions/wordpress#set-the-summary-post-as-the-last-post-of-new-discussions

hrvoje_hr

That was the first I checked, it's on. This issue occurred after I upgraded Flarum from 1.3 to 1.6

clarkwinkelmann

Version 1.7.6 - December 13, 2022

Fix "WordPress" case in the extension name, documentation and English translations. The namespaces and attributes are unchanged and keep their lowercase "p".
Fix new comment threads with no replies not showing as unread in Flarum discussion list. It will now show as unread + zero replies which Flarum would not natively do.

This problem appeared in version 1.7.4 when the reply count was fixed for new discussions.

hrvoje_hr this should fix the issue. Thanks for your report! It wasn't actually caused by the Flarum update, but by the change I made in a previous version to fix the reply count.

hrvoje_hr

clarkwinkelmann it works, thank you!

cpluscc

@clarkwinkelmann
It seems that this extension is not compatible with php 8.0.
The dependency symfony/dom-crawler ⁴.0 requires php 7.3.The latest version of it is.v6.0
Here is the error.

Problem 1
    - kilowhat/flarum-ext-wordpress[1.7.0, ..., 1.7.6] require symfony/dom-crawler ^4.0 -> found symfony/dom-crawler[v4.0.0, ..., v4.4.45] but these were not loaded, likely because it conflicts with another require.
    - Root composer.json requires kilowhat/flarum-ext-wordpress ^1.7 -> satisfiable by kilowhat/flarum-ext-wordpress[1.7.0, ..., 1.7.6].
You can also try re-running composer require with an explicit version constraint, e.g. "composer require kilowhat/flarum-ext-wordpress:*" to figure out if any version is installable, or "composer require kilowhat/flarum-ext-wordpress:^2.1" if you know which you need.

Installation failed, reverting ./composer.json and ./composer.lock to their original content.

clarkwinkelmann

cpluscc can you share the entire Composer output, and maybe the output of composer why-not kilowhat/flarum-ext-wordpress 1.7 and php flarum info ? The output you shared makes no mention of a PHP version issue. Maybe it's a conflict between the dependencies required by different extensions.

I am not aware of any issue running this extension on PHP 8.0 or 8.1. I am pretty sure I worked on the last few updates on my PHP 8.1 dev setup. I just tried installing the extension on my PHP 8.0 dev setup and didn't encounter any issue. PHP 8.2 might be an issue, but I think the problems are with Flarum core and are already being addressed in Flarum version 1.7. I can try again this weekend on my PHP 8.1 computer if needed, but I'm really not seeing any issue dependency-wise. symfony/dom-crawler@v4.4.45 requires php: >=7.1.3 which will allow with 8.0 and 8.1 just fine.

Please delete the GitHub repository and Packagist repo you created with a copy of my source code, or I will have to reach out to GitHub to take it down. It's fine with me if you would like to maintain a private fork as long as an Extiverse license is active, but it must be only used and accessible within your organization.

cpluscc

Anyone?

hrvoje_hr

cpluscc I'm also waiting for this to upgrade my server on PHP 8

cpluscc

clarkwinkelmann
flarum/flarum - requires kilowhat/flarum-ext-wordpress (v1.7.6)
kilowhat/flarum-ext-wordpress 1.7.0 requires league/html-to-markdown (⁴.10)
flarum/flarum - requires league/html-to-markdown (⁵.1)
kilowhat/flarum-ext-wordpress 1.7.0 requires symfony/dom-crawler (⁴.0)
flarum/flarum - does not require symfony/dom-crawler (but v6.0.19 is installed)

cpluscc

clarkwinkelmann I'm so sorry, I have deleted them.

hrvoje_hr

While you're here, do you plan to support Wordpress Multisite/Network function?

clarkwinkelmann

cpluscc can you share the content of your composer.json file (the one in the root folder of Flarum). Maybe you have manually installed a specific version of a dependency?

I'm really not sure what might be wrong otherwise. You could try deleting the composer.lock (.lock, not .json) file and vendor folder, and run composer install again to try getting a fresh version of everything or a clearer error message. This might cause some extensions or Flarum to update if you aren't already on the latest version. Make a backup of those files first in case there is an actual incompatibility so you can rollback.

hrvoje_hr

@clarkwinkelmann could you change the way we choose where to place commens threds?

Now, that option is selected on the Flarum side, but in my case, it would be better in Wordpress settings.

I have multisite Wordpress (two sites on the same database). Everything works great out of the box, but I would like to place comments from another site in ther own tag.

clarkwinkelmann

hrvoje_hr I'll see what I can do. Placing the setting on the Flarum side was easier as I can get access to the list of tags, but I could add an "advanced" setting in Wordpress where a tag slug can be typed instead.

hrvoje_hr

clarkwinkelmann hi, do you have any eta for that? And let me know if additional commission is needed

« Previous Page Next Page »