Link Decisions

Pherinos

Good work but unable to translate it with Linguist:

tolgaaaltas

Pherinos so sad for me.

clarkwinkelmann

Pherinos tolgaaaltas it's expected as the text is hard-coded in English https://github.com/zerosonesfun/link-decisions/blob/master/extend.php#L26

010101

tolgaaaltas Pherinos
I can hopefully, maybe, make this translatable by following the instructions here. I’ll mess around with this later.

🙂

Pherinos

tolgaaaltas so sad for me.

Don't be sad! It's a good work and I expected it! 👍👍👍

010101

Pherinos tolgaaaltas

OK. I am all about doing the best I can to make my extensions usable for everyone. But, I’m not a professional, highly skilled developer. 🙂 So, for now, I have at least made it so that everything in the pop up modal can be manually translated by directly editing the extension’s extend.php file. @Pherinos as you saw, you already could do this with the main text. But, you could not change the text for the buttons. Now you can. And so my friends, here are the steps to translate this extension:

First update to the latest version of this extension which right now is 1.1. After that, do the following:

Go to Flarum’s vendor folder and find the zerosonesfun folder.
Go into the link-decisions folder.
Open extend.php.
Lines 26, 27, 31, and 32 contain the text for the pop up as well as the button text. Line 26 is the title, 27 is the smaller text, 31 is the confirm button and 32 is the cancel button. Edit the text in between the single or double quotes and save the file. Be careful: don’t accidentally erase a quote or remove the html link code in line 27.
You may or may not need to clear caches.

Pherinos

clarkwinkelmann Yes, I changed the texts, but how to change the texts of the Confirm and Cancel buttons???

swal({ title: 'Ce lien va s\'ouvrir dans un nouvel onglet ou une nouvelle fenêtre', text: 'Non merci, <a href="' + getLink + '" target="_self">ouvrir dans l\'onglet courant</a>.', html: true, type: "warning", confirmButtonColor: '#2ecc71', showCancelButton: true, showConfirmButton: true,

Ralkage

010101 well, to be fair, Flarum does support both front-end client and server-side translation but it's a bit tricky to tackle either or with the way you developed this extension. Now, that doesn't mean it can't be converted to a full-fledge extension without having to inject both the CSS and JS into the document header and footer respectfully.

For inspiration, you can take a look at how @Kyrne developed ReFlar/SweetAlerts and adapt it to this extension to get you a similar solution if you'd like? I'd also be willing to help you as I believe this would be a learning experience for both of us 😉

010101

Ralkage Maybe. I’d love to... but... I don’t have a proper developer environment and so it’s pretty cumbersome for me. I did this on a Chromebook. Actually, I did the latest update right on my iPhone. 😮🤪

I create things for my forum using the tools I have (which isn’t much) and if it works, is error free, I think others might be able to use it, and I’m feeling generous, I share it.

We’ll see how the beginning of this year goes... maybe I’ll get a new computer this year.

[deleted]

010101 Thanks a lot!

010101

Version 1.2

Now only external links are targeted which makes more sense (IMO).
Conflicts with my Pop Up BBCode and SM2 Audio extension fixed.
Any external link in your forum will now have the class "External-link" added. This is to make point number one work, but also you now have a way to target external links with CSS/LESS should you want to make external links look different.

To update:

composer update zerosonesfun/link-decisions

See original post for instructions on how to customize (which includes using another language).

Kylo

010101 it's not working and just refreshing the page when i click the link (tested on localhost).

Edit: it was looking for the resources at the base URL rather than Flarum forum itself so i fixed it and still not working. No errors, no nothing.

Littlegolden

Hope you can add translation keys.

010101

Littlegolden I'll be very honest. It's not likely that will happen any time soon.

Short story: See this post.

Long story: I don't have a proper developer environment at this time. So, I can only code online via a basic text editor (very old-school). I was able to do this latest update because of the fact that all I needed to do was add some extra JavaScript; which can be done online right in GitHub. But, anything more complex (such as the transpilation required to make extensions more Flarumized) requires a better set up than what I've got. Although, I did it once using tools in the cloud provided by Google - still it wasn't the best set up.

therealsujitk

Would be cool if you made a feature that allowed admins or users to chose whether the want the link to be opened in a new page by default or ask every time.

010101

Kylo Yeah, that’s true. I made this for my forum originally and my forum is installed at the main domain level. As in at myforum.com.

But if you updated that and the URLs are now pointing to the resources correctly then it sounds like a caching issue?

Kylo

010101 here's the fixed extension with locale support so maybe someone else could give it a try? :

https://github.com/the-turk/link-decisions/tree/locale

@jordanjay29 this discussion should be tagged with Dev for now

010101

Kylo Oh, if you’ve completely redone the extension then I definitely can’t help. It could be the way the JavaScript is being loaded in your version of the extension.

Unless you’re saying that your version does work. Then that’s cool. If it works and folks would rather use your version then yes, this thread can be marked as dev. Then you may start a new thread tagged extension; that’s cool with me. I’m happy to turn the keys over to you so to speak. 😎

However, my version isn’t broken and works. Folks may see it working here:
https://www.sitbreathe.be/d/15-audio-heart-lotus-by-shindhu

jordanjay29

010101 Kylo The major qualifications for being in the Extensions tag are being compatible/working on the current version of Flarum, and that the author considers it ready for release. There's no requirements for certain coding/interface styles or translation support for general extensions, though we'd certainly love to see all extensions provide consistency, some devs simply offer their extensions as-is. There are no rules or conventions being violated here.

We'll leave it up to the community to determine if they wish to endorse or install this extension at their own convenience.

Kylo

010101 i have no intention like STEALING your extension so be cool, i fixed it added locale support and created a pull request on GitHub because THIS IS THE WAY HOW OPEN SOURCE WORKS. So merge it or not, it's completely up to you, i'm okay with my own version.

rob006

Kylo You should probably release your fork as separate extension, since it fixes some fundamental issues with upstream version. This is also the way how open source works. 🙂

010101 However, my version isn’t broken and works. Folks may see it working here:
https://www.sitbreathe.be/d/15-audio-heart-lotus-by-shindhu

Well, it does no work for me on Firefox - it always opens links in current tab.

010101

Kylo 🙂I know how open source works. But, I wouldn’t be able to maintain your version. So if it’s better, your version should become “the” version. I was being sincere. You should take over if that version works better. But, if you don’t want to, that’s cool too. I’ll test your version later and make it the “official” version if it works ok. But again, I won’t be able to update or do much with it.

Kylo

rob006 sorry, that's not gonna happen. I won't support my fork anyways.

010101

rob006 Well, it does no work for me on Firefox - it always opens links in current tab.

Are you sure? I don’t have a PC so I can’t test a windows version of Firefox, but I just tested with Firefox for iPhone and it works great. Green button opens site in a new tab/window.

Also, I don’t think the new version Kylo made would fix that unless the JavaScript was completely rewritten? I could be wrong though.