Flarum Categories

askvortsov

DursunCan Can you update the plugin or share external CSS codes?

Is this happening on hover? If so I'll be able to fix that shortly (I have a suspicion as to whats causing it), if not, I might need more info. Could you send a link to your website?

DursunCan

askvortsov https://forum.sourceturk.net

askvortsov Is this happening on hover?

yes

askvortsov

DursunCan
Fixed in v0.1.10 (latest version), thanks for reporting!

Kyrne

This is so cool! Awesome work @askvortsov

DursunCan

askvortsov A few more missing caught my attention. The title of the discussion does not appear on the main label. Username is not visible in the sub-tag. Colors are not compatible with night mode and day mode. Note; I do not use colors on the tags.

night mode:

day mode:

askvortsov

askvortsov I'll set that particular link up to go to the most recent post vs just to the discussion (although worth noting that the behavior I have now is how the default Tags grid handles it too, but going to last post is definitely better)

This is gonna have to wait until my proposed fix to the tags extension gets merged. I don't want to return contents/info about hidden discussions to the public forum.

JesusIsGodAlmighty

Interesting - cool! The Possibilities... hmmm

askvortsov

DursunCan A few more missing caught my attention. The title of the discussion does not appear on the main label. Username is not visible in the sub-tag.

Huh sorry about that, I was testing with dark mod eon in settings, and it seems like night mode behaves differently, I'll get that all fixed soon.

DursunCan Colors are not compatible with night mode and day mode.

I'm assuming the issue is the off-white background for child tags. If so, I'll see what I can do (I can definitely make it compatible with dark mode, but will need to see how night mode works under the surface). If that's not the issue, please let me know more about the incompatibility

Ralkage

askvortsov night mode just needs some TLC, it's not really 100% up-to-par with the actual Dark Mode theme that's in Flarum's core by default 😉

askvortsov

V0.2.0

Added full support for Night Mode (please note that day mode when appearance is set to light in admin settings will not work due to an issue in Night Mode)
Added a dark background for child tags when in dark mode / night mode
Added a setting to display child tag icons without a circular background (in this case those icons will be the tag color) @jordanjay29

DursunCan

askvortsov Finally, we need correction for night mode here.

askvortsov

DursunCan Fixed in v0.2.1! I think we may have finally gotten all the bugs... 🤞

UaMV

I notice that when using this in conjunction with Byōbu, that the category shows the associated private message tag as having 0 Discussions | 0 Posts even when there are, in fact, discussions and posts in that private message bin. I'm not sure whether this would be a fix needed in Byōbu or in this extension. Are you able to reproduce this or might it be an issue on my end?

askvortsov

UaMV Should be fixed now, can you try upgrading to v0.2.3? Also, as an FYI, the lastPostedDiscussion is a bit buggy, but that's an upstream issue with tags, and will need to be fixed there (I've already made a PR).

UaMV

It appears that categories do not currently have any notice that they contain new posts unread by the user. Is this correct? If so, and if Flarum allows, it'd be great to see this considered/added as an enhancement.

askvortsov Also, thanks for this fix. Working great on my end.

askvortsov

UaMV It appears that categories do not currently have any notice that they contain new posts unread by the user. Is this correct? If so, and if Flarum allows, it'd be great to see this considered/added as an enhancement.

I think that could be cool! Do you have any thoughts/ideas as to how the interface could look?

UaMV

askvortsov Something like this might be enough to help distinguish.

Highlighting Category New Posts

The All Discussion page adds notification of new posts to the right of each discussion, so I expect that is where people would most likely look for new discussions posted in a category. This might call for a different icon. Not sure. Then, to help that bar stand out, you could simply adjust the box-shadow to darken it and lift it from the page a bit. Optionally, you could add an inset box-shadow with a border of the same color as the bar to set it apart a bit more – might make it too busy, though.

Could possibly add the word New or Unread under the icon and number to better define what that means.

askvortsov

UaMV Hmm I like this! One concern is the count though: If there's millions of unread posts, it would be database resource-heavy to calculate that for each tag. It would also take up a lot more space than this design proposes.

One idea I had was adding a shaded dot next to the discussion count, post count, and most recent discussion title to signify that it's unread (it'd be a binary (exists unread vs no unread) as opposed to a count though. What would you think about that?

jordanjay29

I like the border indicator UaMV, that looks innovative.

The traditional method would just be changing the icon itself to fade/brighten or change appearance to indicate something new.

I'm also fine with just a binary indicator and not a count.

clarkwinkelmann

askvortsov binary or count, I'd guess it will have the same complexity. If you do implement tag read status, you might as well store the count and provide an option to switch between the two options visually.

I however can't think of any resource-friendly way to see if any discussion in the tag is not read. This can't easily be cached, so it would have to be counted every time it's requested. Also if it's returned via the tags serializer, you'll need to trigger a tag refresh when the page is accessed if you want to always provide the most up to date information. In contrast the "last post" information of tags is currently never updated until you trigger a full page refresh.

UaMV

I don't know enough about the resources needed for something like this, but definitely like the idea of it. I did notice that there is no such indication on the Tags page, either, so doesn't surprise me that there is probably some hurdle here.

askvortsov What would you think about that?

jordanjay29 I like the border indicator UaMV, that looks innovative.

I'd be all for some sort of visual indication w/o the count. All Discussions makes a pretty good distinction between discussions w/ unread posts and those fullly read. In addition to the binary indicator (i.e. unfilled/filled quote bubble), it also boldens and blackens the text. I think I'd like to see some sort of strengthening of the category (in addition to any binary icon) to mirror that. Whether that is a inset box-shadow/border (matching the text color) as shown above or a lifted bar or something else, I don't know.

If you do opt to go one of those routes, this is the CSS I applied here to mock that up…

/* for the lifted bar */
box-shadow: 0 2px 5px 0 rgba(0,0,0,0.58), 0 4px 10px 0 rgba(0,0,0,0.45);

/* for the bordered bar */
border: 2px solid rgb(41,106,127);
box-shadow: 0 2px 4px 0 rgba(0,0,0,0.18), 0 3px 10px 0 rgba(0,0,0,0.15), inset 0 0 0 4px;

« Previous Page Next Page »