Hi @askvortsov! I hope you're doing fine.
When enabling Sentry extension, I can see following deprecation error everytime when opening any discussion. As the "error" is being reported to Sentry asynchronously, it delays the page load time noticeably - but other than that, it's just a deprecation warning and no other impact seen.
I just wanted to let you know:
[2022-09-08 02:47:44] flarum.ERROR: ErrorException: Accessing static trait property Askvortsov\FlarumPWA\PWATrait::$SIZES is deprecated, it should only be accessed on a class using the trait in vendor/askvortsov/flarum-pwa/extend.php:74
Stack trace:
#0 vendor/askvortsov/flarum-pwa/extend.php(74): FoF\Sentry\SentryServiceProvider->handleError()
#1 vendor/flarum/core/src/Api/Serializer/AbstractSerializer.php(95): Flarum\Extension\Extension->Askvortsov\FlarumPWA\{closure}()
#2 vendor/sycho/json-api/src/Resource.php(183): Flarum\Api\Serializer\AbstractSerializer->getAttributes()
#3 vendor/sycho/json-api/src/Resource.php(81): Tobscure\JsonApi\Resource->getAttributes()
#4 vendor/sycho/json-api/src/Document.php(188): Tobscure\JsonApi\Resource->toArray()
#5 vendor/sycho/json-api/src/Document.php(232): Tobscure\JsonApi\Document->toArray()
#6 vendor/flarum/core/src/Api/JsonApiResponse.php(27): Tobscure\JsonApi\Document->jsonSerialize()
#7 vendor/flarum/core/src/Api/Controller/AbstractSerializeController.php(134): Flarum\Api\JsonApiResponse->__construct()
#8 vendor/flarum/core/src/Http/RouteHandlerFactory.php(41): Flarum\Api\Controller\AbstractSerializeController->handle()
#9 vendor/flarum/core/src/Http/Middleware/ExecuteRoute.php(27): Flarum\Http\RouteHandlerFactory->Flarum\Http\{closure}()
#10 vendor/laminas/laminas-stratigility/src/Next.php(49): Flarum\Http\Middleware\ExecuteRoute->process()
#11 vendor/fof/sentry/src/Middleware/HandleErrorsWithSentry.php(39): Laminas\Stratigility\Next->handle()
#12 vendor/laminas/laminas-stratigility/src/Next.php(49): FoF\Sentry\Middleware\HandleErrorsWithSentry->process()
#13 vendor/kilowhat/flarum-ext-audit-pro/src/Middlewares/ExtendSetPermissionController.php(19): Laminas\Stratigility\Next->handle()
#14 vendor/laminas/laminas-stratigility/src/Next.php(49): Kilowhat\Audit\Middlewares\ExtendSetPermissionController->process()
#15 vendor/flarum/core/src/Api/Middleware/ThrottleApi.php(33): Laminas\Stratigility\Next->handle()
#16 vendor/laminas/laminas-stratigility/src/Next.php(49): Flarum\Api\Middleware\ThrottleApi->process()
#17 vendor/flarum/core/src/Http/Middleware/ResolveRoute.php(67): Laminas\Stratigility\Next->handle()
#18 vendor/laminas/laminas-stratigility/src/Next.php(49): Flarum\Http\Middleware\ResolveRoute->process()
#19 vendor/flarum/core/src/Http/Middleware/SetLocale.php(51): Laminas\Stratigility\Next->handle()
#20 vendor/laminas/laminas-stratigility/src/Next.php(49): Flarum\Http\Middleware\SetLocale->process()
#21 vendor/flarum/core/src/Http/Middleware/HandleErrors.php(57): Laminas\Stratigility\Next->handle()
#22 vendor/laminas/laminas-stratigility/src/Next.php(49): Flarum\Http\Middleware\HandleErrors->process()
#23 vendor/laminas/laminas-stratigility/src/MiddlewarePipe.php(75): Laminas\Stratigility\Next->handle()
#24 vendor/laminas/laminas-stratigility/src/MiddlewarePipe.php(64): Laminas\Stratigility\MiddlewarePipe->process()
#25 vendor/flarum/core/src/Api/Client.php(145): Laminas\Stratigility\MiddlewarePipe->handle()
#26 vendor/flarum/core/src/Api/Client.php(95): Flarum\Api\Client->send()
#27 vendor/flarum/core/src/Frontend/Frontend.php(69): Flarum\Api\Client->get()
#28 vendor/flarum/core/src/Frontend/Frontend.php(50): Flarum\Frontend\Frontend->getForumDocument()
#29 vendor/flarum/core/src/Frontend/Controller.php(32): Flarum\Frontend\Frontend->document()
#30 vendor/flarum/core/src/Http/RouteHandlerFactory.php(41): Flarum\Frontend\Controller->handle()
#31 vendor/flarum/core/src/Http/Middleware/ExecuteRoute.php(27): Flarum\Http\RouteHandlerFactory->Flarum\Http\{closure}()
#32 vendor/laminas/laminas-stratigility/src/Next.php(49): Flarum\Http\Middleware\ExecuteRoute->process()
#33 vendor/fof/discussion-language/src/Middleware/AddLanguageFilter.php(49): Laminas\Stratigility\Next->handle()
#34 vendor/laminas/laminas-stratigility/src/Next.php(49): FoF\DiscussionLanguage\Middleware\AddLanguageFilter->process()
#35 vendor/fof/oauth/src/Middleware/ErrorHandler.php(50): Laminas\Stratigility\Next->handle()
#36 vendor/laminas/laminas-stratigility/src/Next.php(49): FoF\OAuth\Middleware\ErrorHandler->process()
#37 vendor/fof/pwned-passwords/src/Middleware/CheckPasswordReset.php(60): Laminas\Stratigility\Next->handle()
#38 vendor/laminas/laminas-stratigility/src/Next.php(49): FoF\PwnedPasswords\Middleware\CheckPasswordReset->process()
#39 vendor/fof/pwned-passwords/src/Middleware/CheckLoginPassword.php(54): Laminas\Stratigility\Next->handle()
#40 vendor/laminas/laminas-stratigility/src/Next.php(49): FoF\PwnedPasswords\Middleware\CheckLoginPassword->process()
#41 vendor/fof/pwned-passwords/src/Middleware/PreventPwnedPassword.php(62): Laminas\Stratigility\Next->handle()
#42 vendor/laminas/laminas-stratigility/src/Next.php(49): FoF\PwnedPasswords\Middleware\PreventPwnedPassword->process()
#43 vendor/fof/sentry/src/Middleware/HandleErrorsWithSentry.php(39): Laminas\Stratigility\Next->handle()
#44 vendor/laminas/laminas-stratigility/src/Next.php(49): FoF\Sentry\Middleware\HandleErrorsWithSentry->process()
#45 vendor/fof/stopforumspam/src/Middleware/RegisterMiddleware.php(76): Laminas\Stratigility\Next->handle()
#46 vendor/laminas/laminas-stratigility/src/Next.php(49): FoF\StopForumSpam\Middleware\RegisterMiddleware->process()
#47 vendor/fof/terms/src/Middlewares/RegisterMiddleware.php(59): Laminas\Stratigility\Next->handle()
#48 vendor/laminas/laminas-stratigility/src/Next.php(49): FoF\Terms\Middlewares\RegisterMiddleware->process()
#49 vendor/kilowhat/flarum-ext-audit-pro/src/Middlewares/SetLoggerActor.php(28): Laminas\Stratigility\Next->handle()
#50 vendor/laminas/laminas-stratigility/src/Next.php(49): Kilowhat\Audit\Middlewares\SetLoggerActor->process()
#51 vendor/flarum/core/src/Http/Middleware/ContentTypeOptionsHeader.php(21): Laminas\Stratigility\Next->handle()
#52 vendor/laminas/laminas-stratigility/src/Next.php(49): Flarum\Http\Middleware\ContentTypeOptionsHeader->process()
#53 vendor/flarum/core/src/Http/Middleware/ReferrerPolicyHeader.php(30): Laminas\Stratigility\Next->handle()
#54 vendor/laminas/laminas-stratigility/src/Next.php(49): Flarum\Http\Middleware\ReferrerPolicyHeader->process()
#55 vendor/flarum/core/src/Http/Middleware/FlarumPromotionHeader.php(30): Laminas\Stratigility\Next->handle()
#56 vendor/laminas/laminas-stratigility/src/Next.php(49): Flarum\Http\Middleware\FlarumPromotionHeader->process()
#57 vendor/flarum/core/src/Http/Middleware/ShareErrorsFromSession.php(57): Laminas\Stratigility\Next->handle()
#58 vendor/laminas/laminas-stratigility/src/Next.php(49): Flarum\Http\Middleware\ShareErrorsFromSession->process()
#59 vendor/flarum/core/src/Http/Middleware/CheckCsrfToken.php(36): Laminas\Stratigility\Next->handle()
#60 vendor/laminas/laminas-stratigility/src/Next.php(49): Flarum\Http\Middleware\CheckCsrfToken->process()
#61 vendor/flarum/core/src/Http/Middleware/ResolveRoute.php(67): Laminas\Stratigility\Next->handle()
#62 vendor/laminas/laminas-stratigility/src/Next.php(49): Flarum\Http\Middleware\ResolveRoute->process()
#63 vendor/flarum/core/src/Http/Middleware/SetLocale.php(51): Laminas\Stratigility\Next->handle()
#64 vendor/laminas/laminas-stratigility/src/Next.php(49): Flarum\Http\Middleware\SetLocale->process()
#65 vendor/flarum/core/src/Http/Middleware/AuthenticateWithSession.php(31): Laminas\Stratigility\Next->handle()
#66 vendor/laminas/laminas-stratigility/src/Next.php(49): Flarum\Http\Middleware\AuthenticateWithSession->process()
#67 vendor/flarum/core/src/Http/Middleware/RememberFromCookie.php(52): Laminas\Stratigility\Next->handle()
#68 vendor/laminas/laminas-stratigility/src/Next.php(49): Flarum\Http\Middleware\RememberFromCookie->process()
#69 vendor/flarum/core/src/Http/Middleware/StartSession.php(61): Laminas\Stratigility\Next->handle()
#70 vendor/laminas/laminas-stratigility/src/Next.php(49): Flarum\Http\Middleware\StartSession->process()
#71 vendor/flarum/core/src/Http/Middleware/CollectGarbage.php(46): Laminas\Stratigility\Next->handle()
#72 vendor/laminas/laminas-stratigility/src/Next.php(49): Flarum\Http\Middleware\CollectGarbage->process()
#73 vendor/flarum/core/src/Http/Middleware/ParseJsonBody.php(28): Laminas\Stratigility\Next->handle()
#74 vendor/laminas/laminas-stratigility/src/Next.php(49): Flarum\Http\Middleware\ParseJsonBody->process()
#75 vendor/flarum/core/src/Http/Middleware/HandleErrors.php(57): Laminas\Stratigility\Next->handle()
#76 vendor/laminas/laminas-stratigility/src/Next.php(49): Flarum\Http\Middleware\HandleErrors->process()
#77 vendor/flarum/core/src/Http/Middleware/InjectActorReference.php(25): Laminas\Stratigility\Next->handle()
#78 vendor/laminas/laminas-stratigility/src/Next.php(49): Flarum\Http\Middleware\InjectActorReference->process()
#79 vendor/fof/merge-discussions/src/Middleware/Redirection.php(28): Laminas\Stratigility\Next->handle()
#80 vendor/laminas/laminas-stratigility/src/Next.php(49): FoF\MergeDiscussions\Middleware\Redirection->process()
#81 vendor/laminas/laminas-stratigility/src/MiddlewarePipe.php(75): Laminas\Stratigility\Next->handle()
#82 vendor/middlewares/request-handler/src/RequestHandler.php(84): Laminas\Stratigility\MiddlewarePipe->process()
#83 vendor/laminas/laminas-stratigility/src/Next.php(49): Middlewares\RequestHandler->process()
#84 vendor/middlewares/base-path-router/src/BasePathRouter.php(101): Laminas\Stratigility\Next->handle()
#85 vendor/laminas/laminas-stratigility/src/Next.php(49): Middlewares\BasePathRouter->process()
#86 vendor/laminas/laminas-stratigility/src/Middleware/OriginalMessages.php(36): Laminas\Stratigility\Next->handle()
#87 vendor/laminas/laminas-stratigility/src/Next.php(49): Laminas\Stratigility\Middleware\OriginalMessages->process()
#88 vendor/middlewares/base-path/src/BasePath.php(73): Laminas\Stratigility\Next->handle()
#89 vendor/laminas/laminas-stratigility/src/Next.php(49): Middlewares\BasePath->process()
#90 vendor/flarum/core/src/Http/Middleware/ProcessIp.php(24): Laminas\Stratigility\Next->handle()
#91 vendor/laminas/laminas-stratigility/src/Next.php(49): Flarum\Http\Middleware\ProcessIp->process()
#92 vendor/laminas/laminas-stratigility/src/MiddlewarePipe.php(75): Laminas\Stratigility\Next->handle()
#93 vendor/laminas/laminas-stratigility/src/MiddlewarePipe.php(64): Laminas\Stratigility\MiddlewarePipe->process()
#94 vendor/laminas/laminas-httphandlerrunner/src/RequestHandlerRunner.php(96): Laminas\Stratigility\MiddlewarePipe->handle()
#95 vendor/flarum/core/src/Http/Server.php(44): Laminas\HttpHandlerRunner\RequestHandlerRunner->run()
#96 public/index.php(26): Flarum\Http\Server->listen()
#97 {main}