Avatar upload still doesnt work in beta 5 (Windows)

Highstrike

I've already posted here.
I don't see the point of initiating another topic of the same subject on github.

Waiting for developer reply.

PS: Switching to linux is not a solution for me.

jordanjay29

Highstrike Convert the image format from TMP to PNG or JPG and you should be fine.

Averell

jordanjay29 This is not the problem. I have also a Windows installation and the same problem. I tried with the three supported formats (png, jpg, gif), and right extensions, and I get always the same message about the tmp extension.
I guess Flarum is building a temporary image with the tmp extension, and after that the program is lost in Windows which relies on extensions to get the file type.

jordanjay29

Hmm, I noticed you're using PHP 7.0. This could be another regression issue that 7.0 introduces for Flarum. Could you try switching your PHP version to 5.5/5.6? Wamp should include one of those.

Highstrike

jordanjay29 Same issue with PHP 5.6.11

Averell

jordanjay29 Same problem in PHP 5.6

Highstrike

Yep, I don't upload an avatar with .tmp extension either.
It gets the .tmp extension when it's moved into "project\storage\tmp\" and then it doesn't know the original extension anymore.

Also please note I am not comfortable on changing vendor files that are 3rd party and not flarum, like I don't want to change "vendor\intervention\image\src\Intervention\Image"

jordanjay29

Averell Highstrike Okay, sounds like this is something to take a look at. Feel free to open a new issue at Github, or I can do it for you.

Highstrike

jordanjay29 I would apreciate it if you would open an issue on our behalf. Thank you.

In the meantime I want to start using this forum but without avatars it's a real downer, you know?

datitisev

Highstrike Yeah, just look at Dominion's ?
Sorry for your problems.

jordanjay29

Highstrike Please subscribe to the issue.

Highstrike

jordanjay29 Thanks, I'll keep an eye on it ?

Averell

Changing line 84 of :
flarum\vendor\flarum\core\src\Core\Command\UploadAvatarHandler.php
from

$tmpFile = tempnam($this->app->storagePath().'/tmp', 'avatar');

$tmpFile = tempnam($this->app->storagePath().'/jpg', 'avatar');

should do the trick for jpg files, but doesn't... Temporary file has still the tmp extension. Perhaps this file is not used directly ?
But it is only a dirty workaround. Extension should be changed to the source file extension.
Sorry if I don't have time to investigate

Highstrike

Averell I believe that what you changed was actually the directory name ?
Thanks for trying though!

EDIT
I believe the issue is at line 99

        $manager->make($tmpFile)->fit(100, 100)->save();

This is where the Exception happens

Averell

Highstrike This is where the Exception happens

right, but the $tmpFile variable is defined on line 84.
But the value /jpg is not recognized : after this change the tmp file is no longer built.
I just suppose the issue is somewhere in this area.

jordanjay29

Highstrike This is where the Exception happens

Exception lines can be deceiving, sometimes the error actually occurs elsewhere, but that's just where it's called in runtime.

Highstrike

Averell According to the examples in http://image.intervention.io/api/make, in the "make" method you shouldn't put files that end up as temporary files.

I just did a var_dump of $tmpFile and it was something like "project/storage/tmp/ava9E18.tmp" which is wrong.

7h3ev1l

Lol, i never had this issue.

Highstrike

jordanjay29 True, but that is the line that invokes the Intervention Image 3rd party library

EDIT
Alright, I think on linux when you upload a file it doesn't change extension because the code on line 99 takes that file, shrinks it into 100x100 and then saves it once again.

Problem is, on windows the uploaded file has it's extension changed from .jpg or .png or whatever into .tmp and the Exception is happening on that line because the program tries to shrink an invalid picture according to it because its of .tmp extension.

Averell

Highstrike This fix works :

$tmpFile = tempnam($this->app->storagePath().'/tmp', 'avatar');
$tmpFile = $tmpFile . ".jpg";

Add the line $tmpFile = $tmpFile . ".jpg"; after line 84.
Enjoy !
And it works also for gif and png files !

(Still a dirty workaround, clearly, but it shows where the problem is).

Highstrike

Averell Cool, that works

So the uploaded file will actually be "project\storage\tmp\ava08b.tmp.jpg"
But hey, it works ?

I've changed line 84 into this

$tmpFile = tempnam($this->app->storagePath().'/tmp', 'avatar') . '.jpg';

Thanks!

PS: It's a sloppy fix though so this issue is still not solved.

Doc

Averell It works!!!!!!!!!!