Flarum Discussion Views

010101

Littlegolden I personally don’t care because no one uses my forum. 😂 But, if people ever found my forum and started using it and something like this happened, I would care. At the same time, this is a great extension that @MichaelBelgium maintains for free and the update he did sets it up for cool new features in the future.

Plus, I’m mentally preparing myself for Flarum Stable. I think I’ve read hints here and there that some extensions will break again once we hit Flarum 1.0. We might have to go through many more little things like this with other extensions as they update and Flarum updates. Eventually, the way extensions are done will become more stable as Flarum core becomes more stable. Right now, it’s kind of like a new civilization. A brand new colony. There will be set backs. ✌️

010101

MichaelBelgium Thank you! And, @datitisev, thank you! Redirect bug fixed!

Although tip for others. At first I thought it still wasn’t fixed. But, then I deactivated and reactivated the extension.

MichaelBelgium

Hi 👋 update time:

v3.1.0

Full changelog

Summary:

Add list of latest visitors on a discussion page
Add new settings: max viewlist items, enable the viewlist
Add new translation keys

To update, execute:

composer update michaelbelgium/flarum-discussion-views
php flarum migrate
php flarum cache:clear

Imgur

tolgaaaltas

MichaelBelgium Add list of latest visitors on a discussion page

I prefer this this feature at end of the topic (below to new reply area)

MichaelBelgium

[deleted] How? If you have custom styling on avatars, keep it but disable the styling under the class fieldset.LastDiscussionUsers

[deleted]

MichaelBelgium Oh, i mean in general, even with the default theme, i dont like the avatars, it somehow doesnt fit.

MichaelBelgium

[deleted] You can hide it with css for example

fieldset.LastDiscussionUsers .Avatar {
    display: none;
}

Littlegolden

Thank you very much for developing this extension, really heartfelt thanks, trully!

MichaelBelgium what about the people who already updated? It's too late for them

For those who have upgraded, if they don't care if the old count is gone, then continue to use. For people who haven’t upgraded, it’s better if they can inherit the old count. This has nothing to do with fairness, but if you can avoid resetting the old count after the upgrade, it is better not to reset.

MichaelBelgium It's inaccurate data in my opinion and I have no idea if people rather want inaccurate data than no data.

I understand that even God can’t find out who has browsed the discussion before the upgrade, and I didn’t ask for this feature.

I just think it’s really necessary to have the ability to set the count, or inherit the count of the old version. I believe most people don’t really care that the data of “Latest Viewers” list does not match the number of “Discussion Views count”.

MichaelBelgium Can u elaborate on the "guest list prompts"? In what way? What do you mean exactly?

If it is for humanitarian(a bit unnecessary), we can also prompt the user in the "Latest Viewers" list:

danielunited

Congrats on your first extension 🙂

MichaelBelgium Adds 2 sorting options: popular and unpopular

I wanted to ask how do these work? Is "popular" like the most viewed discussions in the past week or so?

MichaelBelgium

danielunited
No, all time.

tolgaaaltas Not possible unfortunately (afaik)

Alshain

MichaelBelgium

Hi again 🙂

 $current_discussion->views()->save($view);

//for the (un)popular filter
$current_discussion->view_count = $current_discussion->views()->count();
$current_discussion->save();

The following code snippet exhausts the database.

Wouldn't that part be better to change?

'$ current_discussion-> view_count = $ current_discussion-> views () -> count ();'

'$ current_discussion-> view_count = $ current_discussion-> view_count + 1'

In the code you write, 150 people look at different subjects at the same time,
This means that queries are taken to calculate the number of views for 150 different questions in the database. It also means updating 150 questions in the database.
This can cause problems when experienced all day long. When you make a +1, you offer less consumption. Otherwise, you have to find the number of all viewers and print that number into the database.

I guess I could not explain very well, but if there is any place you do not understand, I will try to help with translate 🙂

MichaelBelgium

Alshain mhm i can do that, i guess. But rest in peace accurate data 🙁

Tall Thats odd, a lot of things can peak ur cpu usage, im sure a website or a small extension won't. Loading times cant increase especially on the index page as the extension isnt on that page most of the time. Only on discussonpages the magic happens

Tall

Hi,

I used this extension for a while because it's great but the latest release had too big impact on the performance of our server. Especially when loading the index.php or refreshing the pages. You could see cpu increasing to 100% with the lsphp proces of loading the index.php.
After disabling the extension performance was back to normal. 😄

I think it's great extension but I cannot use the latest version because of the performance trade off. ☹️

Tall

MichaelBelgium

On the index page are all the discussions with the amount of views. So I guess there is a query or something to load the latest amount of views from the database which causes the cpu peak.
Maybe the initial load takes longer for all the discussion on the index page.

Never the less, on our forum there are about 20 to 30 concurrent users and performance dropped with the new version of the extension. Like I said, after disabling the extension performance was back to normal. I can reproduce the issue.

Alshain

MichaelBelgium

Tall

I think I solved the problem.

The reason is: In sites with high hits and many questions, tables such as "Tags" and "Discussion Views" are filtering on the homepage as they are linked to the "discussions" table.

Finds the question, pulls the tag from the "Tags" table with the help of "Api".
Then it brings "view_count". Look, for example, when you open the single question, you will not experience a decrease in performance.

But when you bring 20 questions together with their "api" on the main page, you will experience serious slowness.

I don't know how to overcome this problem, but normally flarum has a value of 400 500 TTFB, because of these 2 plugins, my values are now between 2-3k.

MichaelBelgium

Alshain Tall The viewnumber on the index isn't a subquery or anything, it's the field "view_count" from table discussions. So that's nothing that can affect loading times or cpu load. Other than that there's the sort fields which is just showing 2 options in the sorting selectlist 🤔

Alshain

MichaelBelgium Resim

It brings 1400 records from the table 🙁

Somewhere is wrong, but I don't know where it is, I just guessed.

MichaelBelgium

Alshain On what version are you? Update 3.1.0 limits those included views to max 5 views (or something u set urself)

Alshain

MichaelBelgium Hmm, 3.0.0 version.
I will try that.

Tall

I was on 3.0.1. Maybe the same Issue. I will try the 3.1.0 also.

« Previous Page Next Page »