Flarum Discussion Views

danielunited

Congrats on your first extension 🙂

MichaelBelgium Adds 2 sorting options: popular and unpopular

I wanted to ask how do these work? Is "popular" like the most viewed discussions in the past week or so?

MichaelBelgium

danielunited
No, all time.

tolgaaaltas Not possible unfortunately (afaik)

tolgaaaltas

MichaelBelgium Add list of latest visitors on a discussion page

I prefer this this feature at end of the topic (below to new reply area)

Alshain

MichaelBelgium

Hi again 🙂

 $current_discussion->views()->save($view);

//for the (un)popular filter
$current_discussion->view_count = $current_discussion->views()->count();
$current_discussion->save();

The following code snippet exhausts the database.

Wouldn't that part be better to change?

'$ current_discussion-> view_count = $ current_discussion-> views () -> count ();'

'$ current_discussion-> view_count = $ current_discussion-> view_count + 1'

In the code you write, 150 people look at different subjects at the same time,
This means that queries are taken to calculate the number of views for 150 different questions in the database. It also means updating 150 questions in the database.
This can cause problems when experienced all day long. When you make a +1, you offer less consumption. Otherwise, you have to find the number of all viewers and print that number into the database.

I guess I could not explain very well, but if there is any place you do not understand, I will try to help with translate 🙂

MichaelBelgium

Alshain mhm i can do that, i guess. But rest in peace accurate data 🙁

Tall Thats odd, a lot of things can peak ur cpu usage, im sure a website or a small extension won't. Loading times cant increase especially on the index page as the extension isnt on that page most of the time. Only on discussonpages the magic happens

Tall

Hi,

I used this extension for a while because it's great but the latest release had too big impact on the performance of our server. Especially when loading the index.php or refreshing the pages. You could see cpu increasing to 100% with the lsphp proces of loading the index.php.
After disabling the extension performance was back to normal. 😄

I think it's great extension but I cannot use the latest version because of the performance trade off. ☹️

Tall

MichaelBelgium

On the index page are all the discussions with the amount of views. So I guess there is a query or something to load the latest amount of views from the database which causes the cpu peak.
Maybe the initial load takes longer for all the discussion on the index page.

Never the less, on our forum there are about 20 to 30 concurrent users and performance dropped with the new version of the extension. Like I said, after disabling the extension performance was back to normal. I can reproduce the issue.

Alshain

MichaelBelgium

Tall

I think I solved the problem.

The reason is: In sites with high hits and many questions, tables such as "Tags" and "Discussion Views" are filtering on the homepage as they are linked to the "discussions" table.

Finds the question, pulls the tag from the "Tags" table with the help of "Api".
Then it brings "view_count". Look, for example, when you open the single question, you will not experience a decrease in performance.

But when you bring 20 questions together with their "api" on the main page, you will experience serious slowness.

I don't know how to overcome this problem, but normally flarum has a value of 400 500 TTFB, because of these 2 plugins, my values are now between 2-3k.

MichaelBelgium

Alshain Tall The viewnumber on the index isn't a subquery or anything, it's the field "view_count" from table discussions. So that's nothing that can affect loading times or cpu load. Other than that there's the sort fields which is just showing 2 options in the sorting selectlist 🤔

Alshain

MichaelBelgium Resim

It brings 1400 records from the table 🙁

Somewhere is wrong, but I don't know where it is, I just guessed.

MichaelBelgium

Alshain On what version are you? Update 3.1.0 limits those included views to max 5 views (or something u set urself)

Alshain

MichaelBelgium Hmm, 3.0.0 version.
I will try that.

Tall

I was on 3.0.1. Maybe the same Issue. I will try the 3.1.0 also.

Tall

Quick test did not resolve my issue. That 5 views is only for the viewlist, right? I disable that and did not see any discussion anymore. Also I saw the cpu peaks back again when loading the home page.

In the evening our forum is most busy so I will not tweak around for this moment.
I will try later on a less busy moment. 🙂

MichaelBelgium

Tall Mainly for the viewlist but it also limits the included relationship views which helps a lot in stead of loading every view per discussion. Did you migrate and clear cache?

Alshain

MichaelBelgium All I need was to update 🙂

Thank you, it worked

Tall

MichaelBelgium

Yes, i did. Also i did a full clean install including

php flarum migrate:reset --extension michaelbelgium-discussion-views
php flarum cache:clear
composer remove michaelbelgium/flarum-discussion-views
php flarum cache:clear
composer require michaelbelgium/flarum-discussion-view
php flarum migrate
php flarum cache:clear

But when I play around with the option buttons no discussions are being displayed anymore and I have to reset the extension. It's not really working for my configuration I guess 😅 No problem, it was a nice to have.

amanijoseph87

Alshain I don't know how to contact you but can you share the style theme you have in your forum please if you don't mind.

MichaelBelgium

Tall no discussions are being displayed anymore

Any error server or client side?

DursunCan

Can you prevent the "guest" from appearing in the "wiewlist" option?

MichaelBelgium

DursunCan I think thats possible if you set the permission "view discussions" to "members" only, so only members can view discussions

fakruzaruret Thats not possible for now, either you hide it for everyone or show it for everyone

MichaelBelgium

fakruzaruret Yes its definitely possible, ill probably plan it together with the request of
DursunCan

Would appreciate if both requests were in a github issue

fakruzaruret

I want to hide discussion views from web users. Only members must see it. How can I do this? I could not see any permission option on settings. Do you know anything about this issue?

« Previous Page Next Page »