Hashtag

010101

@Justoverclock please don’t forget to review my latest pull request. It adds the admin setting. If you don’t mess with the setting it defaults to the current regular expression. If you want to use your own regular expression you can. The regular expression needs to be without the slashes (/) around it and without the gu part at the end because the code adds that. The setting gives an example as a placeholder so hopefully it’s pretty clear.

Justoverclock

010101 sure tomorrow I will test and review

Justoverclock

010101### 0.2.1 released

010101

Justoverclock Thank you!

FYI for anyone who uses this. I had to edit a post and refresh, and empty my cache a couple times, then it started working again. There seems to be your typical caching type issues after updating.

I thought I’d mention this in case someone updates and they think it doesn’t work. It’s more likely that something is cached. 👍

Justoverclock

010101 justoverclockl/flarum-ext-hashtag10

have you some time to check this? i'm actually working on other extensions

010101

Justoverclock I added a comment. I think the user just needed to re-edit a post or re-save the settings. I don’t know why sometimes things appear to not work right away.

justoverclockl/flarum-ext-hashtag10

Justoverclock

Fealist it says that the package is not required. So is uninstalled

Justoverclock

Fealist try

composer remove justoverclock/flarum-ext-hashtag

And post your composer.JSON pls

Fealist

I am an idiot. Wrong plugin sorry Justoverclock

HerrUU

What does this plugin do exactly? Installed it but nothing happens when I type anything with #whatever ?
Is there a manual or documentation somewhere that explains more precisely what I can do with it?

Justoverclock

HerrUU this extension replace all words #words with a search link, refresh the page to see the result maybe

010101

Justoverclock HerrUU

Quick update: I tested this again. I can confirm that you must save the settings once for the extension to work. You don’t have to input anything, just click save.

I’m not sure how to make Flarum save the settings upon activation.

@Justoverclock - For now could you add this as an installation step in the first post? 1) Activate 2) Click save

Justoverclock

010101 I usually place a default value if no one is provided

https://github.com/justoverclockl/last-users-posts/blob/main/js/src/common/components/LastUsersPosts.js#L27

feodosij

010101 you must save the settings once for the extension to work. You don’t have to input anything, just click save.

@Justoverclock Please mention it in starter post. After installation I'm also was confused
Thank you for work!!!

010101

Justoverclock Ok, I’ll let you try to debug it first. I remember that I tried doing it that way (with || default regexp here) and it wasn’t working for me. Instead it currently uses if statements. If the setting exists, use the setting, if not, use the default. And, this works… But, only after saving. Or, maybe it was the action of deactivating and reactivating that made it work. I’m actually not sure now because I did both.

Worst case, I don’t think it’s a big deal to ask the user to click save once.

010101

@Justoverclock,

If you have time would you be able to install this and fof best answer, then on a desktop, go to a discussion with a lot of replies, and try clicking either like, or the three dot options menu and click on something in the options menu. As you click, does your screen jump up a few posts?

More explanation is in a best answer issue I posted: FriendsOfFlarum/best-answer55

If I deactivate best answer the problem goes away. Or, if I deactivate hashtags, the problem goes away. It seems with both active, this strange bug appears.

Justoverclock

010101 sure i will test this later

010101

Justoverclock Never mind. I updated a bunch of my extensions and now the issue is gone.

ART994

when you hover over a hashtag, search on Flarum is added

Justoverclock

ART994 what do you mean exactly?

ART994

Justoverclock in English the phrase is normal, but in another language the phrase flarum is added
hashtag_link_tooltip: Find posts related to this hashtag

Justoverclock

ART994 oh ok, this happen because probably this extension is not translated in your language.

whats your language?

« Previous Page Next Page »