Hashtag

Justoverclock

010101 i see that is closed

010101

Justoverclock this one is open: justoverclockl/flarum-ext-hashtag8

Lautre-f

I discovered that hashtag break Fancy-box

010101

Lautre-f That extension probably does something with “#”. There’s probably a way to fix it. But, I think that there will always be a few extensions not compatible with this. Since it looks for any “#” in a post.

Justoverclock

0.2.0

improved regex, thx to 010101 for the pr

Lautre-f

I wrote this for information.
This extension works fine.
I enabled so many extension that I can't understand why there is so few conflicts. I did it for tests purpose. 😃

010101

Justoverclock Thanks! 🎉

New idea. I replied to @Pipecraft here in the last pull request: https://github.com/justoverclockl/flarum-ext-hashtag/pull/8#discussion_r737431136

The idea is, eventually, add an admin setting with the RegEx. Then people can adjust the RegEx however they want. They can include numbers, other symbols, and whatever. A disclaimer could be added saying: Only edit this if you know what you’re doing.

I don’t have a lot of experience yet creating settings for extensions. But, I’m thinking/hoping it’s relatively easy. I may try later this week. Or, if you or anyone else has time this would be the ultimate update.

We would no longer need to adjust the RegEx because people could do it themselves! 😎

Justoverclock

010101 yes this could be a definitive solution 🙂

Pipecraft

010101 Absolutely, this is a better solution. I want this feature!

Lautre-f

Great! This will help me to search and found a regexp.
I tested the 0.2.0 version and the conflict was still present.
With a form, I can try easily regex without searching in source code.

010101

@Justoverclock please don’t forget to review my latest pull request. It adds the admin setting. If you don’t mess with the setting it defaults to the current regular expression. If you want to use your own regular expression you can. The regular expression needs to be without the slashes (/) around it and without the gu part at the end because the code adds that. The setting gives an example as a placeholder so hopefully it’s pretty clear.

Justoverclock

010101 sure tomorrow I will test and review

Justoverclock

010101### 0.2.1 released

010101

Justoverclock Thank you!

FYI for anyone who uses this. I had to edit a post and refresh, and empty my cache a couple times, then it started working again. There seems to be your typical caching type issues after updating.

I thought I’d mention this in case someone updates and they think it doesn’t work. It’s more likely that something is cached. 👍

Justoverclock

010101 justoverclockl/flarum-ext-hashtag10

have you some time to check this? i'm actually working on other extensions

010101

Justoverclock I added a comment. I think the user just needed to re-edit a post or re-save the settings. I don’t know why sometimes things appear to not work right away.

justoverclockl/flarum-ext-hashtag10

Justoverclock

Fealist it says that the package is not required. So is uninstalled

Justoverclock

Fealist try

composer remove justoverclock/flarum-ext-hashtag

And post your composer.JSON pls

Fealist

I am an idiot. Wrong plugin sorry Justoverclock

HerrUU

What does this plugin do exactly? Installed it but nothing happens when I type anything with #whatever ?
Is there a manual or documentation somewhere that explains more precisely what I can do with it?

Justoverclock

HerrUU this extension replace all words #words with a search link, refresh the page to see the result maybe

010101

Justoverclock HerrUU

Quick update: I tested this again. I can confirm that you must save the settings once for the extension to work. You don’t have to input anything, just click save.

I’m not sure how to make Flarum save the settings upon activation.

@Justoverclock - For now could you add this as an installation step in the first post? 1) Activate 2) Click save

« Previous Page Next Page »