Hashtag

murdocklawless

010101 you are right, I disabled best answer and link preview start working while hashtag is on. weird situation. hope someone find solution.

murdocklawless

hashtag takes the last part of the post, shouldn't it take it from the beginning?

010101

murdocklawless This looks like it’s working to me. Although there are a few languages out there that use marks that the default regexp can’t handle.

murdocklawless

other thing if you click a created hashtag like #hello it lists all the topics which word hello included.

I put this in the regex field;

(\B#)(\w*[a-zA-Z0-9-_İÖÜŞÇĞıöüşçğ]*)

this catches all turkish characters and others beginning with # but it still lists all the topics which included word after #

it should only list topics included hashtags like #hello not list word hello which is used in topics.

Justoverclock

0.2.2

Now hashtag should work without any setting in the admin panel. simply write your word with an hashtag and go.

composer update justoverclock/flarum-ext-hashtag
php flarum cache:clear

murdocklawless

Justoverclock thanks for the fix. is there any way to create hashtags with numbers? for example, if the topic is boeing 747, could we create a hashtag like #747 ?

Justoverclock

actually is only for words, but i think that if i change the regex with something like

(^|\s)#[A-Za-z0-9]* should work

https://regex101.com/r/hfIcjN/1

010101

Justoverclock Please don’t change the default regexp because some people may not want numbers.

Of course if you do decided to change the default regexp I suppose I can just use the setting then. 😅

010101

Justoverclock [A-Za-z0-9]* should work

I think this would only work for English. We changed the regexp to what it is so that it works with most languages. Although it still may not work with languages that use a lot of special marks. And so the setting was added so that users can research and add their own regexp.

Justoverclock

010101 as always, we need to find a robust regexp for numbers and letters

010101

Justoverclock Why? Twitter, the place that made hashtags popular doesn’t allow numbers. If someone really wants that they can use the admin setting and make a custom regexp. 🙂

The current regexp is pretty robust. There’s one other better regexp, but it isn’t compatible with Safari. Remember the one you originally used? It catches a lot, but it wasn’t compatible with Safari. I researched this pretty heavily.

Justoverclock

010101 maybe https://regex101.com/r/nV6Pqf/1

works with chinese too

https://regex101.com/r/tknSCk/1

murdocklawless

Justoverclock this looks good. also working with turkish alphabet like öçşığüÖÇŞİĞÜ

010101

Justoverclock I haven’t looked closely but does this use a similar method to the original where it won’t work in Safari?

I say go for it if you want because I can change the regexp in my settings if it doesn’t work in Safari or I don’t want numbers. 🙂

murdocklawless

010101 @Justoverclock disabled custom regex field. still listing the words used in topics without # character. I think list should only include real hashtag.

010101

murdocklawless Oh. If that’s the case I’ll have to fork and go with a custom version. Because I know the version with the setting works really well for me.

010101

murdocklawless The screenshot you provided looks like it worked correctly. You have words with spaces. Those won’t be picked up. Then you have a hashtag in bold. What am I missing? Isn’t the hashtag at the end in bold what you want to be the linked hashtag?

Justoverclock

010101 i will implement again the custom regexp in the next version

Justoverclock

0.2.3

regex now works with only numbers and different languages

murdocklawless

Justoverclock no updates?

010101

Justoverclock A potential problem with this new regular expression is that it is ok if something is in front of it. This could, potentially, cause more conflicts down the road. See here how it won't ignore a URL:

https://regex101.com/r/maJc3a/1

And if I change the regex settings to JavaScript and put "gu" at the end it says error:
https://regex101.com/r/6VBWDV/1

Versus the previous regular expression... While not perfect, it was heavily researched and tested to avoid things like URLs, and required there to be 1 space, or be at the beginning of a line:

https://regex101.com/r/4pKuTT/1

Even with Turkish according to regex101, it works. But, I know a couple people have reported it doesn't, which is odd. But again, that's where the admin setting comes in. All that needed to be fixed was ensuring the setting saves upon activation. Or, simply add instructions: "Save settings once."

murdocklawless

010101 yes it's working but in hashtag list, it was taking the last part of the post, now it's starting with the begining of the post.

the other thing lets say you create a hastag #hello. when you click on this hashtag all the topics are listed the word hello included, even they are hello or #hello.

two different topics word included hello, one of the is hashtag other is not;

this is the list by clicking hastag #hello;

as you can see, it lists all the topics with the word hello.

« Previous Page Next Page »