Hashtag

murdocklawless

murdocklawless today it decided to show link previews while hashtag is on.

edit : no link preview does not work with hashtag. I think previews came from browser cache. after I made a crtl+f5 previews don't show up again.

educatedheker

SKevo well let me try and i will update this message
Edit: great job now its working thanks and congrats but please help me in smtp thing coz the mail driver is not working

educatedheker

murdocklawless Nope thanks to @SKevo though i don't use link preview, still he gave me the correct solution
https://discuss.flarum.org/d/27476-hashtag/141

murdocklawless

educatedheker clearing cache won't help me. actually hashtag is working as it should be, I wish it didn't conflict with link preview extension. maybe they fix this issue.

010101

murdocklawless Do you also use Best Answer?

I found that link previews will work with the Hashtag extension. However, once you add Best Answer or possibly some other extension then there is a conflict.

It may seem like it is solely the Hashtag extension’s fault since you can deactivate it and link previews work, but it’s really a combination of extensions. You can probably disable all extensions except Hashtag and Link Previews and they will both work.

murdocklawless

010101 yes, I'm using best answer.

010101

murdocklawless That’s it. Activate hashtag, then disable best answer, you will see link previews work. It’s a combo of the two.

No one has time or knows how to fix it right now.

https://discuss.flarum.org/d/30227-extension-conflicts-best-answer/3

murdocklawless

010101 you are right, I disabled best answer and link preview start working while hashtag is on. weird situation. hope someone find solution.

murdocklawless

hashtag takes the last part of the post, shouldn't it take it from the beginning?

010101

murdocklawless This looks like it’s working to me. Although there are a few languages out there that use marks that the default regexp can’t handle.

murdocklawless

other thing if you click a created hashtag like #hello it lists all the topics which word hello included.

I put this in the regex field;

(\B#)(\w*[a-zA-Z0-9-_İÖÜŞÇĞıöüşçğ]*)

this catches all turkish characters and others beginning with # but it still lists all the topics which included word after #

it should only list topics included hashtags like #hello not list word hello which is used in topics.

Justoverclock

0.2.2

Now hashtag should work without any setting in the admin panel. simply write your word with an hashtag and go.

composer update justoverclock/flarum-ext-hashtag
php flarum cache:clear

murdocklawless

Justoverclock thanks for the fix. is there any way to create hashtags with numbers? for example, if the topic is boeing 747, could we create a hashtag like #747 ?

Justoverclock

actually is only for words, but i think that if i change the regex with something like

(^|\s)#[A-Za-z0-9]* should work

https://regex101.com/r/hfIcjN/1

010101

Justoverclock Please don’t change the default regexp because some people may not want numbers.

Of course if you do decided to change the default regexp I suppose I can just use the setting then. 😅

010101

Justoverclock [A-Za-z0-9]* should work

I think this would only work for English. We changed the regexp to what it is so that it works with most languages. Although it still may not work with languages that use a lot of special marks. And so the setting was added so that users can research and add their own regexp.

Justoverclock

010101 as always, we need to find a robust regexp for numbers and letters

010101

Justoverclock Why? Twitter, the place that made hashtags popular doesn’t allow numbers. If someone really wants that they can use the admin setting and make a custom regexp. 🙂

The current regexp is pretty robust. There’s one other better regexp, but it isn’t compatible with Safari. Remember the one you originally used? It catches a lot, but it wasn’t compatible with Safari. I researched this pretty heavily.

Justoverclock

010101 maybe https://regex101.com/r/nV6Pqf/1

works with chinese too

https://regex101.com/r/tknSCk/1

murdocklawless

Justoverclock this looks good. also working with turkish alphabet like öçşığüÖÇŞİĞÜ

010101

Justoverclock I haven’t looked closely but does this use a similar method to the original where it won’t work in Safari?

I say go for it if you want because I can change the regexp in my settings if it doesn’t work in Safari or I don’t want numbers. 🙂

murdocklawless

010101 @Justoverclock disabled custom regex field. still listing the words used in topics without # character. I think list should only include real hashtag.

« Previous Page Next Page »