$ 100 bounty - Fix Ads extension

davwheat

Walys

You make a good point. I plan to move the ad to after the hero in the next version.

davwheat

xasharma

I can't find any issues with that extension.

xasharma

davwheat check now .... i enabled it and it broked forum

https://hacksnation.com/ open any discussion

I disabled the extension for now .... i will enable it when you come online

davwheat

xasharma

If you're on the Flarum discord, feel free to DM me so we can talk about it in a faster-paced way 😛

xasharma

davwheat enabled ..... visit as a viewer (not logged in user)

xasharma

davwheat
I don't have any link for the discord ... can you please share if you can

xasharma

davwheat

And the forum is working good for logged in users

davwheat

Justoverclock

That's to be expected. Sometimes Google can't fill an ad but it does leave an empty space for no reason.

xasharma

https://flarum.org/discord

Justoverclock

Sometimes if i scroll the posts with the right sidebar, I get a blank space instead of ads…

xasharma

Justoverclock

yes sometimes i have also seen these spaces (after a refresh it works fine) it may be a google Adsense problem

xasharma

davwheat

can I disable the extension now?

davwheat

xasharma

Sorry I haven't been able to check. Disable it for now, then message me on Discord and we can enable it/disable it as needed.

In the meantime, if you could send me the output of php flarum info, that'd be fab!

xasharma

davwheat https://hastebin.com/tinumeqofi.sql

davwheat

xasharma

Found the issue (was with guestengagement) and have made a PR: justoverclockl/flarum-ext-guestengagement3

xasharma

davwheat

you are Correct ... I have disabled guestengagement and enabled Login to see Plus and it is working fine

Thank you

Justoverclock

xasharma guest engagement 1.0.1 available. Thx!

xasharma

Justoverclock

speed 🙌 ⚡⚡

davwheat

@xasharma @MikeJones

Published v0.0.6, which should be the final version before this goes properly live.

Please let me know if you have any issues with the extension. I'll try and resolve them in the next 2 days (wedding to go to tomorrow) if you do. Also let me know if there's any other criteria I need to meet for that bounty! 😛

Hope it all goes well 🤞

I'll see what I can do for this suggestion:

Might be trickier because different sizes of device need more/less space for the sidebar to work correctly.

MikeJones

davwheat awesome man, going to try it in a couple hours. Hit me up on discord with your PayPal email address.

My discord is mikejones3#9552

xasharma

davwheat

Great extension bro, Loved it <3 ...... all ads are working great.

Me to i will ping you on Discord @davwheat

MikeJones

davwheat Published v0.0.6, which should be the final version before this goes properly live.

I just updated. I am not seeing anything in my left sidebar on desktop.

Also in the settings when the header for the sidebar says this:

Code for "davwheat.ads.lib.locations.sidebar" ad unit

All the other headings are easy readable.

MikeJones

@davwheat if it's ok with you. Can you share your discord name here in flarum so I have kinda two factor authentication and know it's you who reached out to me as well 😆

davwheat

MikeJones

Yeah of course -- I can confirm that it was me (MrJeeves#6969).

You should be able to double check via Mutual Servers and see I'm in the Flarum one as a core dev.

« Previous Page Next Page »