$ 100 bounty - Fix Ads extension

MikeJones

JUst to be clear do you want me to try putting google adsense code in there? or test your red squares?

MikeJones

I went to install and got this:

  [InvalidArgumentException]                                                                                                             
  Could not find a version of package davwheat/flarum-ext-ads matching your minimum-stability (beta). Require it with an explicit versi  
  on constraint allowing its desired stability.

I figured this is where I add the:

davwheat That should work fine. If you get a warning about minimum stability, add this to your composer.json: "minimum-stability": "dev",

But I still got the same error.

Here is snapshot of my composer.json where I added the min stability

{
    "name": "flarum/flarum",
    "description": "Delightfully simple forum software.",
    "type": "project",
    "keywords": [
        "forum",
        "discussion"
    ],
    "homepage": "https://flarum.org/",
    "license": "MIT",
    "minimum-stability": "dev",
    "require": {
        "askvortsov/flarum-pwa": "*",
        "clarkwinkelmann/flarum-ext-first-post-approval": "*",
        "davwheat/custom-sidenav-links": "*",
        "flagrow/ads": "@dev",
        "flarum/akismet": "*",
        "flarum/approval": "*",
        "flarum/bbcode": "*",
        "flarum/core": "^1.0",
        "flarum/emoji": "*",
        "flarum/flags": "*",
        "flarum/lang-english": "*",
        "flarum/likes": "*",

Darkle

MikeJones The composer.json is saved with the changes? I tried it as you have it and I don't get that error, I thought it could be "flagrow/ads":"@dev", but it doesn't seem to be the problem either.

If it still doesn't work maybe you could force it with composer require davwheat/flarum-ext-ads:"*"@dev

MikeJones

Darkle does the extension work for you?

Darkle

MikeJones I meant to install it, I haven't been able to test it with Adsense yet, I have to configure ad units and the ads.txt file on the server first. Did it work for you or at least you could install it?

MikeJones

Darkle I haven't tried again yet since I got the error earlier. May need to wait until tomorrow

davwheat

MikeJones xasharma

So I've updated the ext. Adding some test ad unit code seems to fill the spaces now.

Header, footer and discussion header are all present.

Make sure migrations are run again!

It might take a few refreshes before you see an ad because of how the scripts load.

xasharma

davwheat

I tried ... sorry but it works for only simple HTML banners not with AdSense (tried header and footer ads with both Adsense and simple HTML banners)

davwheat

xasharma

Is that with the AdSense script in the custom header, and using <ins> tags for the ad unit code?

xasharma

davwheat

<script async src="https://pagead2.googlesyndication.com/pagead/js/adsbygoogle.js?client=ca-pub-5941506786539927"
     crossorigin="anonymous"></script>
<!-- Custom center header -->
<ins class="adsbygoogle"
     style="display:block"
     data-ad-client="ca-pub-59415067865xxxxxx"
     data-ad-slot="xxxxxxxxxx"
     data-ad-format="auto"
     data-full-width-responsive="true"></ins>
<script>
     (adsbygoogle = window.adsbygoogle || []).push({});
</script>

Justoverclock

guys, i think i've done with adsense, i need @xasharma or someone to test
could u please ping me on discord?

i have a working version finally

davwheat

xasharma

If you download the latest version of my ext, it should work

Justoverclock

xasharma invitation sended

MikeJones

@davwheat I still cant install yours :-( also did you test with Adsense javascript or just static code?

@Justoverclock whats your discord so I can ping you to try it out?

davwheat

MikeJones also did you test with Adsense javascript or just static code?

I've got the AdSense code injecting blank ads into my Dev forum (not approved for any actual ads on any sites).

The minimum stability entry should be all you need to install my extension, so that's odd. I'll release v0.0.1 now which should let you install it.

composer require davwheat/flarum-ext-ads:"*"
php flarum migrate

Enter your publisher ID in the admin page, then add the <ins> code to the textbox(es). Do not add the script tags as AdSense tells you. The extension will do this for you.

xasharma

davwheat

sorry i am confused ...

<script async src="https://pagead2.googlesyndication.com/pagead/js/adsbygoogle.js?client=ca-pub-5941506786539927"
     crossorigin="anonymous"></script>
<!-- Custom center header -->
<ins class="adsbygoogle"
     style="display:block"
     data-ad-client="ca-pub-59415067865xxxxxx"
     data-ad-slot="xxxxxxxxxx"
     data-ad-format="auto"
     data-full-width-responsive="true"></ins>
<script>
     (adsbygoogle = window.adsbygoogle || []).push({});
</script>

This is a Display ad unit that works for all types of ads....
which part I have to ad to the textboxes ??

MikeJones

davwheat I just installed it, but not shoing any ads after multiple refreshes...

Its live on my website if you want to check it out right, now. I will leave it live for a little bit.

xasharma

MikeJones

Try Disabling all previous ads extensions ... install this one davwheat clear cache , migrate

it worked for me ... check your Adsense id and ad unit setting

Justoverclock

ok so i can't leave this extension.....2 hour is enough! XD

davwheat

xasharma

Just the <ins> part:

<ins class="adsbygoogle"
     style="display:block"
     data-ad-client="ca-pub-59415067865xxxxxx"
     data-ad-slot="xxxxxxxxxx"
     data-ad-format="auto"
     data-full-width-responsive="true"></ins>

davwheat

MikeJones

I'll have a look after I get home. On the Copenhagen metro at the moment. 😛

xasharma

MikeJones

yes

« Previous Page Next Page »