• Dev

  • $ 100 bounty - Fix Ads extension

davwheat

I tried ... sorry but it works for only simple HTML banners not with AdSense (tried header and footer ads with both Adsense and simple HTML banners)

      xasharma

      Is that with the AdSense script in the custom header, and using <ins> tags for the ad unit code?

          MikeJones xasharma

          So I've updated the ext. Adding some test ad unit code seems to fill the spaces now.

          Header, footer and discussion header are all present.

          Make sure migrations are run again!

          It might take a few refreshes before you see an ad because of how the scripts load.

              guys, i think i've done with adsense, i need @xasharma or someone to test
              could u please ping me on discord?

              i have a working version finally

              davwheat

              <script async src="https://pagead2.googlesyndication.com/pagead/js/adsbygoogle.js?client=ca-pub-5941506786539927"
     crossorigin="anonymous"></script>
<!-- Custom center header -->
<ins class="adsbygoogle"
     style="display:block"
     data-ad-client="ca-pub-59415067865xxxxxx"
     data-ad-slot="xxxxxxxxxx"
     data-ad-format="auto"
     data-full-width-responsive="true"></ins>
<script>
     (adsbygoogle = window.adsbygoogle || []).push({});
</script>

                  @davwheat I still cant install yours :-( also did you test with Adsense javascript or just static code?

                  @Justoverclock whats your discord so I can ping you to try it out?

                    MikeJones also did you test with Adsense javascript or just static code?

                    I've got the AdSense code injecting blank ads into my Dev forum (not approved for any actual ads on any sites).

                    The minimum stability entry should be all you need to install my extension, so that's odd. I'll release v0.0.1 now which should let you install it.

                    composer require davwheat/flarum-ext-ads:"*"
php flarum migrate

                    Enter your publisher ID in the admin page, then add the <ins> code to the textbox(es). Do not add the script tags as AdSense tells you. The extension will do this for you.

                        davwheat

                        sorry i am confused ...

                        <script async src="https://pagead2.googlesyndication.com/pagead/js/adsbygoogle.js?client=ca-pub-5941506786539927"
     crossorigin="anonymous"></script>
<!-- Custom center header -->
<ins class="adsbygoogle"
     style="display:block"
     data-ad-client="ca-pub-59415067865xxxxxx"
     data-ad-slot="xxxxxxxxxx"
     data-ad-format="auto"
     data-full-width-responsive="true"></ins>
<script>
     (adsbygoogle = window.adsbygoogle || []).push({});
</script>

                        This is a Display ad unit that works for all types of ads....
                        which part I have to ad to the textboxes ??

                            xasharma

                            Just the <ins> part:

                            <ins class="adsbygoogle"
     style="display:block"
     data-ad-client="ca-pub-59415067865xxxxxx"
     data-ad-slot="xxxxxxxxxx"
     data-ad-format="auto"
     data-full-width-responsive="true"></ins>

                              davwheat I just installed it, but not shoing any ads after multiple refreshes...

                              Its live on my website if you want to check it out right, now. I will leave it live for a little bit.

                                  Summary --

                                  ------Malago/ads -----
                                  Only between the ads are working

                                  ------- Inserto/ads ----------
                                  Only header and under tags are working (not that good)

                                  --------- Justoverclock extension -------
                                  Header + under the tags are working but after opening a discussion and going back to homepage ads leave a blank space (or it needs a refresh)

                                  Between the post ads are working great >>>

                                  ---------davwheat/flarum-ext-ads ------- (great extension many features)

                                  Between the ads are not working
                                  under the header and under the discussion header are working but a refresh
                                  side bar not working

                                  Video - https://youtu.be/TzasW6ih0Bk

                                    xasharma Between the ads are not working

                                    This and the sidebar haven't been implemented yet, which explains exactly why they don't work.

                                    If the header and footer do, that means my method does and I can implement the between posts and sidebar later today.

                                    I'll try to hide the big gaps when no ad has been shown, as well as fixing the ads on initial load, but it might prove difficult.

                                        MikeJones

                                        Try Disabling all previous ads extensions ... install this one davwheat clear cache , migrate

                                        it worked for me ... check your Adsense id and ad unit setting