$ 100 bounty - Fix Ads extension

davwheat

xasharma Between the ads are not working

This and the sidebar haven't been implemented yet, which explains exactly why they don't work.

If the header and footer do, that means my method does and I can implement the between posts and sidebar later today.

I'll try to hide the big gaps when no ad has been shown, as well as fixing the ads on initial load, but it might prove difficult.

xasharma

davwheat

Thank you we will wait >

MikeJones

xasharma any idea why @davwheat isn't showing on mine at all?

xasharma

MikeJones

Try Disabling all previous ads extensions ... install this one davwheat clear cache , migrate

it worked for me ... check your Adsense id and ad unit setting

MikeJones

xasharma SO all are disabled:

I also ran:

ubuntu@ip-172-31-92-154:/var/www/tendigitgrid.com$ sudo php flarum cache:clear
Clearing the cache...
ubuntu@ip-172-31-92-154:/var/www/tendigitgrid.com$ sudo php flarum recache:clear
ReCache cleared!

I did look in my composer.json and saw this for @davwheat extension, is this line correct:

"davwheat/flarum-ext-ads": "*",

xasharma

MikeJones

Correct

"davwheat/flarum-ext-ads": "*",

xasharma

@Justoverclock
@davwheat

When i enabled Justoverclock's extension with yours it always loads ads (header and footer) in the first time (without any refresh)

Justoverclock

xasharma 😆

MikeJones

xasharma odd nothing shows up for me 🤷‍♂️

xasharma

MikeJones

Try removing these both Ads and Flagrow Ads

composer remove command

MikeJones

xasharma Removed them all then reinstalled the one by @davwheat and still not dice even clearing cache...

Ads hate me...

Justoverclock

MikeJones its because flarum its a SPA...really hard to make ads work

xasharma

MikeJones NO idea bro

Try a simple html banner ad

<div>
 <img " src="https://i.imgur.com/oz4nnBF.png" style="width:100%">
</div>

davwheat

MikeJones

Just got home. I'm seeing the ad code on your forum, but it's showing that the spots are "unfilled" meaning Google hasn't found any ads for your site.

Are you sure that you've added your domain on AdSense and it's been approved?

xasharma

Justoverclock

True even Discourse has only under header (with discussion header) and footer ads.

MikeJones

xasharma so that works, wounder why google isnt working. WHat does your code look lthat you are using for hte ad slots?

davwheat Yes 100% sure my website is approved. I have had ads on in for over a year.

xasharma

MikeJones

<center>
<!-- Header ad Homepage -->
<ins class="adsbygoogle"
     style="display:block"
     data-ad-client="ca-pub-5941506786539927"
     data-ad-slot="xxxxxxxxxxx"
     data-ad-format="auto"
     data-full-width-responsive="true"></ins>
</center>

MikeJones

xasharma so your code

<center>
<!-- Header ad Homepage -->
<ins class="adsbygoogle"
     style="display:block"
     data-ad-client="xxxxxxxxxxx"
     data-ad-slot="xxxxxxxxxxx"
     data-ad-format="auto"
     data-full-width-responsive="true"></ins>
</center>

my code:

<ins class="adsbygoogle"
   style="display:block"
   data-ad-client="xxxxxxxxxxx"
   data-ad-slot="xxxxxxxxxxx"
   data-ad-format="auto"
   available-width="auto"
   data-full-width-responsive="true"></ins>

Your code seems to work lol. MInor change 🤷‍♂️

davwheat

MikeJones

That's... so weird...

Anyway, working on between post ads now!

xasharma

MikeJones

Happy to see this 🔥

MikeJones

davwheat just an obersrvation right now. My code in:

Code for "Discussion page (under header)" ad unit

Keeps disappearing, and I have to re-paste it in there.

MikeJones

davwheat Anyway, working on between post ads now!

Super pumped! Also really like where you dump the ad in the discussion page other then at the top above the title. Looks much better than older versions I have used for the discussion page.

« Previous Page Next Page »