$ 100 bounty - Fix Ads extension

davwheat

xasharma

If you download the latest version of my ext, it should work

MikeJones

@davwheat I still cant install yours :-( also did you test with Adsense javascript or just static code?

@Justoverclock whats your discord so I can ping you to try it out?

davwheat

MikeJones also did you test with Adsense javascript or just static code?

I've got the AdSense code injecting blank ads into my Dev forum (not approved for any actual ads on any sites).

The minimum stability entry should be all you need to install my extension, so that's odd. I'll release v0.0.1 now which should let you install it.

composer require davwheat/flarum-ext-ads:"*"
php flarum migrate

Enter your publisher ID in the admin page, then add the <ins> code to the textbox(es). Do not add the script tags as AdSense tells you. The extension will do this for you.

xasharma

davwheat

sorry i am confused ...

<script async src="https://pagead2.googlesyndication.com/pagead/js/adsbygoogle.js?client=ca-pub-5941506786539927"
     crossorigin="anonymous"></script>
<!-- Custom center header -->
<ins class="adsbygoogle"
     style="display:block"
     data-ad-client="ca-pub-59415067865xxxxxx"
     data-ad-slot="xxxxxxxxxx"
     data-ad-format="auto"
     data-full-width-responsive="true"></ins>
<script>
     (adsbygoogle = window.adsbygoogle || []).push({});
</script>

This is a Display ad unit that works for all types of ads....
which part I have to ad to the textboxes ??

MikeJones

davwheat I just installed it, but not shoing any ads after multiple refreshes...

Its live on my website if you want to check it out right, now. I will leave it live for a little bit.

xasharma

MikeJones

Try Disabling all previous ads extensions ... install this one davwheat clear cache , migrate

it worked for me ... check your Adsense id and ad unit setting

Justoverclock

ok so i can't leave this extension.....2 hour is enough! XD

davwheat

xasharma

Just the <ins> part:

<ins class="adsbygoogle"
     style="display:block"
     data-ad-client="ca-pub-59415067865xxxxxx"
     data-ad-slot="xxxxxxxxxx"
     data-ad-format="auto"
     data-full-width-responsive="true"></ins>

davwheat

MikeJones

I'll have a look after I get home. On the Copenhagen metro at the moment. 😛

xasharma

MikeJones

yes

xasharma

Summary --

------Malago/ads -----
Only between the ads are working

------- Inserto/ads ----------
Only header and under tags are working (not that good)

--------- Justoverclock extension -------
Header + under the tags are working but after opening a discussion and going back to homepage ads leave a blank space (or it needs a refresh)

Between the post ads are working great >>>

---------davwheat/flarum-ext-ads ------- (great extension many features)

Between the ads are not working
under the header and under the discussion header are working but a refresh
side bar not working

Video - https://youtu.be/TzasW6ih0Bk

davwheat

xasharma Between the ads are not working

This and the sidebar haven't been implemented yet, which explains exactly why they don't work.

If the header and footer do, that means my method does and I can implement the between posts and sidebar later today.

I'll try to hide the big gaps when no ad has been shown, as well as fixing the ads on initial load, but it might prove difficult.

MikeJones

xasharma any idea why @davwheat isn't showing on mine at all?

xasharma

davwheat

Thank you we will wait >

MikeJones

xasharma SO all are disabled:

I also ran:

ubuntu@ip-172-31-92-154:/var/www/tendigitgrid.com$ sudo php flarum cache:clear
Clearing the cache...
ubuntu@ip-172-31-92-154:/var/www/tendigitgrid.com$ sudo php flarum recache:clear
ReCache cleared!