Move Posts

wbntff

Can this be used to move posts up and down within a topic ?
I migrated one forum from MyBB to flarum Its posts within few topics are not according to posted dates

SychO

wbntff nope, you should try fixing the migration tool instead.

robinodds

Is there a way to select and move all the posts in a discussion, without doing it one by one?

PS: I know about the existence of the Merge Ext, but it rarely works in the proper way.

treyb

robinodds I’m not sure if https://discuss.flarum.org/d/30122-mass-actions would work with this or not.

robinodds

treyb don't think this can be used to move posts.

treyb

robinodds By Move, do you mean re-tag? I am able to re-tag and essentially move threads using the mass actions extension.

robinodds

treyb i mean the function this extension adds: SychO

navindra

Hello.

I have "Group sequential post moved event posts into one." on.

If I select a single post to move, it does not result in any "EventPost PostMovedPost" posts at all in the original discussion.

However, if I select two or more sequential posts, then I do get the move event logged.

Anyone else seeing this?

I don't fully understand the code but I guess I see the bug?

        if ($groupSequentialPosts) {
            foreach($posts as $post) {
                $nextPost = $posts->firstWhere('number', $post->number+1);

            if ($nextPost) {
                if (! isset($grouped[$index])) {
                    $grouped[$index] = new Collection();
                }

                $grouped[$index]->push($post);
                $grouped[$index]->push($nextPost);
                $grouped[$index] = $grouped[$index]->unique('id');
            } else {
                $index++;
            }
        }
    }

The else statement only increments the $index, but it really should do something like:

$grouped[$index++] = new Collection([$post]);

I can test the fix on a dev instance, but assuming it works, what's the safest way to deploy the fix? I could modify the PHP manually but that won't survive upgrades/moves. I could submit a PR and hope it eventually gets approved, or I could fork Move Posts and figure out how to transition to the fork?

Kind of working in the dark here, but this worked for me:

    if ($groupSequentialPosts) {
        $index = -1;
        $previousPostNumber = -10;
        $uniqueSortedPosts = $posts->unique('id')->sortBy('number');
            

        foreach ($uniqueSortedPosts as $post) {
            $currentPostNumber = $post->number;
            $isSequential = ($previousPostNumber+1) == $currentPostNumber;

            if ($isSequential) {
                $grouped[$index]->push($post);
            } else {
                $index++;
                $grouped[$index] = new Collection([$post]);
            }

            $previousPostNumber = $currentPostNumber;
        }
    }

Here's the PR:
SychO9/flarum-move-posts22

And here it's verified in production.

This sub-thread: https://forum.pianotell.com/d/781-piano/37

has spawned this thread:
https://forum.pianotell.com/d/892-fun-exotic-digital-keyboards

You can see there are several instances of single posts and grouped posts, but all the move event messages look correct! 🙂

« Previous Page