Link Preview

naxvog

Some of the things I confirmed:

[...]/api/datlechin-link-preview?url=htt[...]www.ebay.com/itm/113878224793?hash=item1a83abcf99:g:TBYAAOSwKpddci7f&...TVqJGlYQ is working as expected
app.forum.attribute("datlechin-link-preview.whitelist").split(",").map((function(t){return t.trim()})) lists www.ebay.com

Seems like the whole JS-code is not executed on pageload as I cannot see the initializer function firing

edit: included [...] to avoid linking to your site

Subarist

naxvog
I was weird too, so I went to update 1.2.1 on the backup site and it worked fine.
Then go back to the main site, first disable link preview and then purge.
Re-enabled and it looks OK now.
Tks ^^

datlechin

v1.2.2

Link caching by @naxvog in datlechin/flarum-link-preview15

Now we have cache for Link Preview, you can enable/disable cache link in admin.

Thanks to @naxvog

ernestdefoe

datlechin

I’m having sort of an issue. When I add a link it’ll load the icon and all that but the title says the site can’t be reached but yet when you click it it’ll take you to the site and link I posted. How do I fix this?

datlechin

ernestdefoe Is that link live?

ernestdefoe

datlechin yeah it’s live. Like I said you can click on it and it’ll take you to the site. Take a look at this link on my site

https://www.fbsfootball.site/d/22-updates-to-the-transfer-portal

Here is the link I posted in that post and as you can see it’s live and you can click on it from my site and read it.

https://www.on3.com/transfer-portal/news/ncaa-division-i-council-updates-portal-waiver-guidelines-for-second-time-transfers/?fbclid=IwAR2c3Zy1DCt36W6e02TWZb8pFD1W_IKBWox9l5o4Q4PfOS95OBRA62lCV0M

datlechin

ernestdefoe thanks for the feedback, it doesn't seem to work with urls with sub domain included. i will check it

naxvog

ernestdefoe Seems like your server cannot resolve https://www.on3.com as removing the www subdomain solves the issue.
The favicon is displayed because the Google API can reach the www subdomain.

ernestdefoe

naxvog if I put www.on3.com in the whitelist it doesn’t work at all and if I put just on3.com in there it loads what you see on my site. Every link does that. Is there a php extension I may need to have enabled that I don’t have enabled by chance. I’m on shared hosting but have the ability to choose php versions and some extensions.

naxvog

ernestdefoe currently the host of the link to preview (www.on3.com or on3.com in your case) is checked before the parser is run. gethostname is used to determine if a host is reachable before we start the more involved process of parsing the given url. The function is essentially a DNS check if the domain is reachable.
A failed check points to your server's address-resolution as a possible error.

I tried to resolve the domain on my own flarum install without success (with and without the www subdomain)

ernestdefoe

naxvog So that's good to know it's nothing wrong with my setup. It's even doing it for the Flarum site as well. Made a test post just to test out another site.

naxvog

ernestdefoe Tested the DNS issue further.
Might be that the server's DNS cache needs to get primed for this to work reliably. Subsequent requests seconds after the first one returned the expected result.
Tested with flarum.org and community.flarum.org. The second one failed the DNS test for the first 10 seconds or so but after that it worked like a charm. Keep in mind that I tested using a docker container most likely running a local network primed DNS 😉

ernestdefoe

naxvog Well I don't see me posting a ton of links but it would be nice for it to work right for when I do but it's no huge rush to figure out the cause of it. I'm sure others may feel different about that though.

ernestdefoe

Any update on a fix? Just curious.

datlechin

ernestdefoe you can rollback to the v1.1.2 until we have an update for your issue

naxvog

ernestdefoe Bear in mind that the gethostbyname problem will exist in prior versions too as it was introduced in v0.1.7

Dr_Sommer

DId an update to v1.2.2 and now there are no Preview images no more (no LINK-IMAGE Div!)

https://ibb.co/dMyVgGH

I removed Link Preview entirely and reinstalled it, still no preview image...
Did I do something wrong? I`m new to Flarum.. 😆

datlechin

Dr_Sommer go to Link Preview extension, active the Use Google Favicon API option

Dr_Sommer

Argh.. how stupid.. 😆
Thank You, datlechin... 👍️

jslirola

@datlechin is it possible to whitelist a domain that includes a path? e.g:

mydomain.com/profile/

In theory this case is valid, at least according to the text that will appear in the white list field before writing anything, but it doesn't work for me. The only way I have found to show previews is with the domain only without paths.

Thank you.

naxvog

jslirola this is indeed not supported at the moment. Might create a merge request to fix this issue in the coming days.

« Previous Page Next Page »