FriendsOfFlarum upload, the intelligent file attachment extension

IanM

0.12.2

Fix mimetype config retrieval FriendsOfFlarum/upload258 Nimren gython
Don't attempt to preview an uploaded image when preview is not available (ie on new discussion) FriendsOfFlarum/upload255
Fix console error when cancelling the upload dialog FriendsOfFlarum/upload256
Remove invisible input hack for the toolbar button FriendsOfFlarum/upload257

Updating

composer require fof/upload:"*"
php flarum cache:clear

Derriell

I know this is ahead of time but it would be great if sooner or later Flarum and especially this extension would support the new AVIF file format based on AV1. Ideally with the option to convert and compress all new uploaded images to AVIF. Compared to JPEG, AVIF can safe up to 50% file size and it supports tiling images, which enables multiple cores to render one image in parallel. This would enable Flarum to be faster with images.

Google Chrome supports AVIF since version 85 (August 2020) and Firefox will support it by default from version 86 on.

Links:
https://en.wikipedia.org/wiki/AV1#AV1_Image_File_Format_(AVIF)
https://aomedia.org/av1-features/

clarkwinkelmann

Derriell regarding "support", this extension should support any file type. You just need to write the correct mime type if you want to limit which file types are allowed. Any maybe you might need to update some libraries if the mime type can only be detected using particular libraries.

As for conversion/compression, the only option we currently include in the extension is based on width/height, and I think it preserves the original format (not sure though).

If the library we use for resize (Intervention) supports that file format, a PR is welcome to whitelist those files for resizing in the extension.

Derriell

clarkwinkelmann Thank you, it worked to extend the mime type, I just tried it. The resizing of AVIF images doesn't work for now, as expected.

EDIT: The AVIF file is stored as .bin file but Chrome is able to show them correctly. However if I want to open just the image in a new tab Chrome downloads it as a .bin file.

On weird behavior I encountered: When editing the mime type and clicking on the text to edit, the position of the text exchanged with the text one line below. A line swap. I only have two lines. Using beta 15

JRay

Having some issues with upload after upgrading to beta-15. Here is the debug when you try to upload an image:

IanM

JRay Did you update fof/upload after updating your forum to beta 15? Sometimes extensions do not upgrade at the same time. The current upload version is 0.12.2

JRay

IanM Did you update fof/upload after updating your forum to beta 15? Sometimes extensions do not upgrade at the same time. The current upload version is 0.12.2

Yeah I ended up having to do a fresh install of beta 15 and install fof-upload fresh as well. I'm on 0.12.2.

I did copy up my /files folder after to restore previous images. But I've set ownership back to www-data and it has read and write permissions.

Amarok

Having a big issues with this extension, did by mistake composer update and after that, website crashed. Try just activating this extension, and problem stay. :S

Logs file :

[2021-01-17 17:33:00] flarum.ERROR: InvalidArgumentException: Failed importing file due to No hint path defined for [fof-upload.templates]. in /home/naya/public_html/chat.gaymer.academy/vendor/fof/upload/src/Extenders/AddPostDownloadTags.php:52
Stack trace:
#0 /home/naya/public_html/chat.gaymer.academy/vendor/fof/upload/src/Extenders/AddPostDownloadTags.php(31): FoF\Upload\Extenders\AddPostDownloadTags->createTag(Object(s9e\TextFormatter\Configurator), 'file', Object(FoF\Upload\Templates\FileTemplate))
#1 /home/naya/public_html/chat.gaymer.academy/vendor/flarum/core/src/Formatter/Formatter.php(160): FoF\Upload\Extenders\AddPostDownloadTags->FoF\Upload\Extenders\{closure}(Object(s9e\TextFormatter\Configurator))
#2 /home/naya/public_html/chat.gaymer.academy/vendor/flarum/core/src/Formatter/Formatter.php(192): Flarum\Formatter\Formatter->getConfigurator()
#3 /home/naya/public_html/chat.gaymer.academy/vendor/illuminate/cache/Repository.php(418): Flarum\Formatter\Formatter->Flarum\Formatter\{closure}()
#4 /home/naya/public_html/chat.gaymer.academy/vendor/flarum/core/src/Formatter/Formatter.php(193): Illuminate\Cache\Repository->rememberForever('flarum.formatte...', Object(Closure))
#5 /home/naya/public_html/chat.gaymer.academy/vendor/flarum/core/src/Formatter/Formatter.php(236): Flarum\Formatter\Formatter->getComponent('js')
#6 /home/naya/public_html/chat.gaymer.academy/vendor/flarum/core/src/Forum/ForumServiceProvider.php(105): Flarum\Formatter\Formatter->getJs()
#7 [internal function]: Flarum\Forum\ForumServiceProvider->Flarum\Forum\{closure}()
#8 /home/naya/public_html/chat.gaymer.academy/vendor/flarum/core/src/Frontend/Compiler/Source/StringSource.php(35): call_user_func(Object(Closure))
#9 /home/naya/public_html/chat.gaymer.academy/vendor/flarum/core/src/Frontend/Compiler/Source/StringSource.php(46): Flarum\Frontend\Compiler\Source\StringSource->getContent()
#10 /home/naya/public_html/chat.gaymer.academy/vendor/flarum/core/src/Frontend/Compiler/RevisionCompiler.php(239): Flarum\Frontend\Compiler\Source\StringSource->getCacheDifferentiator()
#11 /home/naya/public_html/chat.gaymer.academy/vendor/flarum/core/src/Frontend/Compiler/RevisionCompiler.php(73): Flarum\Frontend\Compiler\RevisionCompiler->calculateRevision(Array)
#12 /home/naya/public_html/chat.gaymer.academy/vendor/flarum/core/src/Frontend/Compiler/RevisionCompiler.php(125): Flarum\Frontend\Compiler\RevisionCompiler->commit()
#13 /home/naya/public_html/chat.gaymer.academy/vendor/flarum/core/src/Frontend/Content/Assets.php(73): Flarum\Frontend\Compiler\RevisionCompiler->getUrl()
#14 [internal function]: Flarum\Frontend\Content\Assets->Flarum\Frontend\Content\{closure}(Object(Flarum\Frontend\Compiler\JsCompiler))
#15 /home/naya/public_html/chat.gaymer.academy/vendor/flarum/core/src/Frontend/Content/Assets.php(72): array_map(Object(Closure), Array)
#16 /home/naya/public_html/chat.gaymer.academy/vendor/flarum/core/src/Frontend/Content/Assets.php(55): Flarum\Frontend\Content\Assets->getUrls(Array)
#17 /home/naya/public_html/chat.gaymer.academy/vendor/flarum/core/src/Frontend/Frontend.php(63): Flarum\Frontend\Content\Assets->__invoke(Object(Flarum\Frontend\Document), Object(Laminas\Diactoros\ServerRequest))
#18 /home/naya/public_html/chat.gaymer.academy/vendor/flarum/core/src/Frontend/Frontend.php(55): Flarum\Frontend\Frontend->populate(Object(Flarum\Frontend\Document), Object(Laminas\Diactoros\ServerRequest))
#19 /home/naya/public_html/chat.gaymer.academy/vendor/flarum/core/src/Frontend/Controller.php(32): Flarum\Frontend\Frontend->document(Object(Laminas\Diactoros\ServerRequest))
#20 /home/naya/public_html/chat.gaymer.academy/vendor/flarum/core/src/Http/RouteHandlerFactory.php(38): Flarum\Frontend\Controller->handle(Object(Laminas\Diactoros\ServerRequest))
#21 /home/naya/public_html/chat.gaymer.academy/vendor/flarum/core/src/Http/Middleware/ExecuteRoute.php(27): Flarum\Http\RouteHandlerFactory->Flarum\Http\{closure}(Object(Laminas\Diactoros\ServerRequest), Array)
#22 /home/naya/public_html/chat.gaymer.academy/vendor/laminas/laminas-stratigility/src/Next.php(61): Flarum\Http\Middleware\ExecuteRoute->process(Object(Laminas\Diactoros\ServerRequest), Object(Closure))
#23 /home/naya/public_html/chat.gaymer.academy/vendor/datitisev/flarum-maintenance/src/Middleware/ForumMaintenance.php(33): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#24 /home/naya/public_html/chat.gaymer.academy/vendor/laminas/laminas-stratigility/src/Next.php(61): Datitisev\Maintenance\Middleware\ForumMaintenance->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#25 /home/naya/public_html/chat.gaymer.academy/vendor/flarum/core/src/Http/Middleware/ShareErrorsFromSession.php(57): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#26 /home/naya/public_html/chat.gaymer.academy/vendor/laminas/laminas-stratigility/src/Next.php(61): Flarum\Http\Middleware\ShareErrorsFromSession->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#27 /home/naya/public_html/chat.gaymer.academy/vendor/flarum/core/src/Http/Middleware/CheckCsrfToken.php(40): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#28 /home/naya/public_html/chat.gaymer.academy/vendor/laminas/laminas-stratigility/src/Next.php(61): Flarum\Http\Middleware\CheckCsrfToken->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#29 /home/naya/public_html/chat.gaymer.academy/vendor/flarum/core/src/Http/Middleware/ResolveRoute.php(67): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#30 /home/naya/public_html/chat.gaymer.academy/vendor/laminas/laminas-stratigility/src/Next.php(61): Flarum\Http\Middleware\ResolveRoute->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#31 /home/naya/public_html/chat.gaymer.academy/vendor/flarum/core/src/Http/Middleware/SetLocale.php(50): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#32 /home/naya/public_html/chat.gaymer.academy/vendor/laminas/laminas-stratigility/src/Next.php(61): Flarum\Http\Middleware\SetLocale->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#33 /home/naya/public_html/chat.gaymer.academy/vendor/flarum/core/src/Http/Middleware/AuthenticateWithSession.php(32): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#34 /home/naya/public_html/chat.gaymer.academy/vendor/laminas/laminas-stratigility/src/Next.php(61): Flarum\Http\Middleware\AuthenticateWithSession->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#35 /home/naya/public_html/chat.gaymer.academy/vendor/flarum/core/src/Http/Middleware/RememberFromCookie.php(51): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#36 /home/naya/public_html/chat.gaymer.academy/vendor/laminas/laminas-stratigility/src/Next.php(61): Flarum\Http\Middleware\RememberFromCookie->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#37 /home/naya/public_html/chat.gaymer.academy/vendor/flarum/core/src/Http/Middleware/StartSession.php(61): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#38 /home/naya/public_html/chat.gaymer.academy/vendor/laminas/laminas-stratigility/src/Next.php(61): Flarum\Http\Middleware\StartSession->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#39 /home/naya/public_html/chat.gaymer.academy/vendor/flarum/core/src/Http/Middleware/CollectGarbage.php(46): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#40 /home/naya/public_html/chat.gaymer.academy/vendor/laminas/laminas-stratigility/src/Next.php(61): Flarum\Http\Middleware\CollectGarbage->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#41 /home/naya/public_html/chat.gaymer.academy/vendor/flarum/core/src/Http/Middleware/ParseJsonBody.php(28): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#42 /home/naya/public_html/chat.gaymer.academy/vendor/laminas/laminas-stratigility/src/Next.php(61): Flarum\Http\Middleware\ParseJsonBody->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#43 /home/naya/public_html/chat.gaymer.academy/vendor/flarum/core/src/Http/Middleware/HandleErrors.php(57): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#44 /home/naya/public_html/chat.gaymer.academy/vendor/laminas/laminas-stratigility/src/Next.php(61): Flarum\Http\Middleware\HandleErrors->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#45 /home/naya/public_html/chat.gaymer.academy/vendor/laminas/laminas-stratigility/src/MiddlewarePipe.php(84): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#46 /home/naya/public_html/chat.gaymer.academy/vendor/middlewares/request-handler/src/RequestHandler.php(84): Laminas\Stratigility\MiddlewarePipe->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#47 /home/naya/public_html/chat.gaymer.academy/vendor/laminas/laminas-stratigility/src/Next.php(61): Middlewares\RequestHandler->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#48 /home/naya/public_html/chat.gaymer.academy/vendor/middlewares/base-path-router/src/BasePathRouter.php(97): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#49 /home/naya/public_html/chat.gaymer.academy/vendor/laminas/laminas-stratigility/src/Next.php(61): Middlewares\BasePathRouter->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#50 /home/naya/public_html/chat.gaymer.academy/vendor/laminas/laminas-stratigility/src/Middleware/OriginalMessages.php(42): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#51 /home/naya/public_html/chat.gaymer.academy/vendor/laminas/laminas-stratigility/src/Next.php(61): Laminas\Stratigility\Middleware\OriginalMessages->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#52 /home/naya/public_html/chat.gaymer.academy/vendor/middlewares/base-path/src/BasePath.php(53): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#53 /home/naya/public_html/chat.gaymer.academy/vendor/laminas/laminas-stratigility/src/Next.php(61): Middlewares\BasePath->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#54 /home/naya/public_html/chat.gaymer.academy/vendor/laminas/laminas-stratigility/src/MiddlewarePipe.php(84): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#55 /home/naya/public_html/chat.gaymer.academy/vendor/laminas/laminas-stratigility/src/MiddlewarePipe.php(73): Laminas\Stratigility\MiddlewarePipe->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\EmptyPipelineHandler))
#56 /home/naya/public_html/chat.gaymer.academy/vendor/laminas/laminas-httphandlerrunner/src/RequestHandlerRunner.php(96): Laminas\Stratigility\MiddlewarePipe->handle(Object(Laminas\Diactoros\ServerRequest))
#57 /home/naya/public_html/chat.gaymer.academy/vendor/datitisev/flarum-maintenance/src/Overrides/Http/Server.php(51): Laminas\HttpHandlerRunner\RequestHandlerRunner->run()
#58 /home/naya/public_html/chat.gaymer.academy/index.php(26): Flarum\Http\Server->listen()
#59 {main}

IanM

Amarok No hint path defined for [fof-upload.templates]

This is a deceptive error, unfortunately.

The problem will be with another extension that is not using the correct Extend\View method. Essentially, if an extension registers it's views using the pre-beta 14 method, it will break views for extensions which are loaded/booted after it.

IanM

JRay ok, so really to see what's going on here, you'll need to enable debug mode on your forum, as a plain 500 does not give us any clues as to what's happening

Amarok

IanM l tried with just fof/upload activated and no other that's why it's a bit strange :S

is it possible other interact with him but not actived? (really dont know :S )

vittorioeco

IanM I have same issue after install 12.10 on flarum beta.15
Error is :
InvalidArgumentException
Failed importing file due to No hint path defined for [fof-upload.templates].

How can I solve?
thanks
vittorio

JRay

IanM ok, so really to see what's going on here, you'll need to enable debug mode on your forum, as a plain 500 does not give us any clues as to what's happening

That is the output from debug mode. It just says:

POST https://golfbuzz.com/api/fof/upload

null

IanM

JRay check in /storage/logs/flarum-<date>.log for the stack trace

Amarok I believe it's possible, yes. Are you able to try on a seperate, fresh installation?

Amarok

IanM oh, ok.

Have 2 others Flarum installation, with exactly same extensions, but both are ok. The unique difference is using the composer update command on this installation :S

I could try on a fresh installation yep. Will try a bit later this solution

JRay

IanM check in /storage/logs/flarum-<date>.log for the stack trace

@IanM I'm seeing this in the stack trace:
2021/01/17 22:35:05 [error] 18600#18600: *102350 FastCGI sent in stderr: "PHP message: PHP Fatal error: Uncaught UnexpectedValueException: The stream or file "/var/www/golfbuzz.com/html/storage/logs/flarum-2021-01-17.log" could not be opened in append mode: failed to open stream: Permission denied in /var/www/golfbuzz.com/html/vendor/monolog/monolog/src/Monolog/Handler/StreamHandler.php:110
Stack trace:
#0 /var/www/golfbuzz.com/html/vendor/monolog/monolog/src/Monolog/Handler/RotatingFileHandler.php(120): Monolog\Handler\StreamHandler->write(Array)
#1 /var/www/golfbuzz.com/html/vendor/monolog/monolog/src/Monolog/Handler/AbstractProcessingHandler.php(39): Monolog\Handler\RotatingFileHandler->write(Array)
#2 /var/www/golfbuzz.com/html/vendor/monolog/monolog/src/Monolog/Logger.php(344): Monolog\Handler\AbstractProcessingHandler->handle(Array)
#3 /var/www/golfbuzz.com/html/vendor/monolog/monolog/src/Monolog/Logger.php(712): Monolog\Logger->addRecord(400, Object(InvalidArgumentException), Array)
#4 /var/www/golfbuzz.com/html/vendor/flarum/core/src/Foundation/ErrorHandling/Lo" while reading response header from upstream, client: 70.95.122.193, server: golfbuzz.com, request: "POST /api/fof/upload HTTP/1.1", upstream: "fastcgi://unix:/var/run/php/php7.3-fpm.sock:", host: "golfbuzz.com", referrer: "https://golfbuzz.com/d/8007-posting-issues"

Amarok

IanM I think it's maybe fof user directory having some bugs - removed and all seems to work again 😃

clarkwinkelmann

JRay check your filesystem permissions. It looks like the webserver user (commonly www-data, apache or nginx) is not allowed to write in the log folder of Flarum. This can be solved by changing ownership of the files (chown) or altering the permissions to allow the user/group to write to it.

This is a general issue with your Flarum installation not specific to this extension. But this prevents Flarum from logging the actual error you're encountering with this extension.

JRay

clarkwinkelmann thank you! I was able to fix permission for /storage/logs.

Now I'm getting this error for this extension (I am using local for storage, not s3)

InvalidArgumentException: Missing required client configuration options:

region: (string)

A "region" configuration value is required for the "s3" service
(e.g., "us-west-2"). A list of available public regions and endpoints can be
found at http://docs.aws.amazon.com/general/latest/gr/rande.html. in

MikeJones

Cant we get an alt tag editor for images? Or a way to add them to the code after upload?

clarkwinkelmann

MikeJones I don't think the image preview template has that feature, and I'm not sure if it can easily be added. I think there's a label that can be customized, but I'm not sure if it's applied as alt text.

If you use a custom template, you can have the image inserted as bbcode or markdown, and the alt text will be customizable by editing the markup like for external images.

IanM

Amarok thanks for that. Could you please create an issue here, I'll take a look as soon as I can 🙂

« Previous Page Next Page »