FriendsOfFlarum upload, the intelligent file attachment extension

m4v3rick

clarkwinkelmann Can you share the full error message and trace for the error? It starts on a line with the timestamp, then line #0, #1, #2 etc. It can have up to 50 lines sometimes before the next error that will again start with a timestamp. The presence of #14 makes it look like there might be more interesting information in the lines above.

Sorry, I had to update again to get the error message (I did a snapshot revert after the erros occurred.):

[2025-02-02 22:49:15] flarum.ERROR: TypeError: FoF\Upload\Adapters\Manager::instantiate(): Return value must be of type FoF\Upload\Contracts\UploadAdapter, null returned in /*/vendor/fof/upload/src/Adapters/M> Stack trace: #0 /*/vendor/fof/upload/src/Repositories/FileRepository.php(420): FoF\Upload\Adapters\Manager->instantiate() #1 /*/vendor/fof/upload/src/Formatter/ImagePreview/FormatImagePreview.php(49): FoF\Upload\Repositories\FileRepository->getUrlForFile() #2 /*/vendor/s9e/text-formatter/src/Utils.php(123): FoF\Upload\Formatter\ImagePreview\FormatImagePreview->FoF\Upload\Formatter\ImagePreview\{closure}() #3 [internal function]: s9e\TextFormatter\Utils::s9e\TextFormatter\{closure}() #4 /*/vendor/s9e/text-formatter/src/Utils.php(119): preg_replace_callback() #5 /*/vendor/fof/upload/src/Formatter/ImagePreview/FormatImagePreview.php(38): s9e\TextFormatter\Utils::replaceAttributes() #6 /*/vendor/flarum/core/src/Foundation/ContainerUtil.php(30): FoF\Upload\Formatter\ImagePreview\FormatImagePreview->__invoke() #7 /*/vendor/flarum/core/src/Formatter/Formatter.php(121): Flarum\Foundation\ContainerUtil::Flarum\Foundation\{closure}() #8 /*/vendor/flarum/core/src/Post/CommentPost.php(176): Flarum\Formatter\Formatter->render() #9 /*/vendor/flarum/core/src/Api/Serializer/BasicPostSerializer.php(63): Flarum\Post\CommentPost->formatContent() #10 /*/vendor/flarum/core/src/Api/Serializer/PostSerializer.php(21): Flarum\Api\Serializer\BasicPostSerializer->getDefaultAttributes() #11 /*/vendor/flarum/core/src/Api/Serializer/AbstractSerializer.php(88): Flarum\Api\Serializer\PostSerializer->getDefaultAttributes() #12 /*/vendor/sycho/json-api/src/Resource.php(183): Flarum\Api\Serializer\AbstractSerializer->getAttributes() #13 /*/vendor/sycho/json-api/src/Resource.php(81): Tobscure\JsonApi\Resource->getAttributes() #14 /*/vendor/sycho/json-api/src/Document.php(194): Tobscure\JsonApi\Resource->toArray() #15 [internal function]: Tobscure\JsonApi\Document->Tobscure\JsonApi\{closure}() #16 /*/vendor/sycho/json-api/src/Document.php(193): array_map() #17 /*/vendor/sycho/json-api/src/Document.php(232): Tobscure\JsonApi\Document->toArray() #18 /*/vendor/flarum/core/src/Api/JsonApiResponse.php(27): Tobscure\JsonApi\Document->jsonSerialize() #19 /*/vendor/flarum/core/src/Api/Controller/AbstractSerializeController.php(139): Flarum\Api\JsonApiResponse->__construct() #20 /*/vendor/flarum/core/src/Http/RouteHandlerFactory.php(41): Flarum\Api\Controller\AbstractSerializeController->handle() #21 /*/vendor/flarum/core/src/Http/Middleware/ExecuteRoute.php(27): Flarum\Http\RouteHandlerFactory->Flarum\Http\{closure}() #22 /*/vendor/laminas/laminas-stratigility/src/Next.php(52): Flarum\Http\Middleware\ExecuteRoute->process() #23 /*/vendor/flarum/core/src/Api/Middleware/ThrottleApi.php(33): Laminas\Stratigility\Next->handle() #24 /*/vendor/laminas/laminas-stratigility/src/Next.php(52): Flarum\Api\Middleware\ThrottleApi->process() #25 /*/vendor/flarum/core/src/Http/Middleware/CheckCsrfToken.php(36): Laminas\Stratigility\Next->handle() #26 /*/vendor/laminas/laminas-stratigility/src/Next.php(52): Flarum\Http\Middleware\CheckCsrfToken->process() #27 /*/vendor/flarum/core/src/Http/Middleware/ResolveRoute.php(69): Laminas\Stratigility\Next->handle() #28 /*/vendor/laminas/laminas-stratigility/src/Next.php(52): Flarum\Http\Middleware\ResolveRoute->process() #29 /*/vendor/datitisev/flarum-maintenance/src/Middleware/APIMaintenance.php(19): Laminas\Stratigility\Next->handle() #30 /*/vendor/laminas/laminas-stratigility/src/Next.php(52): Datitisev\Maintenance\Middleware\APIMaintenance->process() #31 /*/vendor/flarum/core/src/Http/Middleware/SetLocale.php(51): Laminas\Stratigility\Next->handle() #32 /*/vendor/laminas/laminas-stratigility/src/Next.php(52): Flarum\Http\Middleware\SetLocale->process() #33 /*/vendor/flarum/core/src/Http/Middleware/AuthenticateWithHeader.php(58): Laminas\Stratigility\Next->handle() #34 /*/vendor/laminas/laminas-stratigility/src/Next.php(52): Flarum\Http\Middleware\AuthenticateWithHeader->process() #35 /*/vendor/flarum/core/src/Http/Middleware/AuthenticateWithSession.php(31): Laminas\Stratigility\Next->handle() #36 /*/vendor/laminas/laminas-stratigility/src/Next.php(52): Flarum\Http\Middleware\AuthenticateWithSession->process() #37 /*/vendor/flarum/core/src/Http/Middleware/RememberFromCookie.php(52): Laminas\Stratigility\Next->handle() #38 /*/vendor/laminas/laminas-stratigility/src/Next.php(52): Flarum\Http\Middleware\RememberFromCookie->process() #39 /*/vendor/flarum/core/src/Http/Middleware/StartSession.php(61): Laminas\Stratigility\Next->handle() #40 /*/vendor/laminas/laminas-stratigility/src/Next.php(52): Flarum\Http\Middleware\StartSession->process() #41 /*/vendor/flarum/core/src/Api/Middleware/FakeHttpMethods.php(29): Laminas\Stratigility\Next->handle() #42 /*/vendor/laminas/laminas-stratigility/src/Next.php(52): Flarum\Api\Middleware\FakeHttpMethods->process() #43 /*/vendor/flarum/core/src/Http/Middleware/ParseJsonBody.php(28): Laminas\Stratigility\Next->handle() #44 /*/vendor/laminas/laminas-stratigility/src/Next.php(52): Flarum\Http\Middleware\ParseJsonBody->process() #45 /*/vendor/flarum/core/src/Http/Middleware/HandleErrors.php(57): Laminas\Stratigility\Next->handle() #46 /*/vendor/laminas/laminas-stratigility/src/Next.php(52): Flarum\Http\Middleware\HandleErrors->process() #47 /*/vendor/flarum/core/src/Http/Middleware/InjectActorReference.php(25): Laminas\Stratigility\Next->handle() #48 /*/vendor/laminas/laminas-stratigility/src/Next.php(52): Flarum\Http\Middleware\InjectActorReference->process() #49 /*/vendor/laminas/laminas-stratigility/src/MiddlewarePipe.php(81): Laminas\Stratigility\Next->handle() #50 /*/vendor/middlewares/request-handler/src/RequestHandler.php(84): Laminas\Stratigility\MiddlewarePipe->process() #51 /*/vendor/laminas/laminas-stratigility/src/Next.php(52): Middlewares\RequestHandler->process() #52 /*/vendor/middlewares/base-path-router/src/BasePathRouter.php(99): Laminas\Stratigility\Next->handle() #53 /*/vendor/laminas/laminas-stratigility/src/Next.php(52): Middlewares\BasePathRouter->process() #54 /*/vendor/laminas/laminas-stratigility/src/Middleware/OriginalMessages.php(36): Laminas\Stratigility\Next->handle() #55 /*/vendor/laminas/laminas-stratigility/src/Next.php(52): Laminas\Stratigility\Middleware\OriginalMessages->process() #56 /*/vendor/middlewares/base-path/src/BasePath.php(73): Laminas\Stratigility\Next->handle() #57 /*/vendor/laminas/laminas-stratigility/src/Next.php(52): Middlewares\BasePath->process() #58 /*/vendor/flarum/core/src/Http/Middleware/ProcessIp.php(24): Laminas\Stratigility\Next->handle() #59 /*/vendor/laminas/laminas-stratigility/src/Next.php(52): Flarum\Http\Middleware\ProcessIp->process() #60 /*/vendor/laminas/laminas-stratigility/src/MiddlewarePipe.php(81): Laminas\Stratigility\Next->handle() #61 /*/vendor/laminas/laminas-stratigility/src/MiddlewarePipe.php(70): Laminas\Stratigility\MiddlewarePipe->process() #62 /*/vendor/laminas/laminas-httphandlerrunner/src/RequestHandlerRunner.php(73): Laminas\Stratigility\MiddlewarePipe->handle() #63 /*/vendor/datitisev/flarum-maintenance/src/Overrides/Http/Server.php(54): Laminas\HttpHandlerRunner\RequestHandlerRunner->run() #64 /*/public/index.php(26): Flarum\Http\Server->listen() #65 {main}

Additional info: sometimes the refresh works and sometimes I don't see any posts or discussions in the discussion list.
If I don't see posts or discussion, the error message above is in the logs.

m4v3rick

Anyone?

Could i meanwhile just exclude the upload extension from updating and freeze it to the actual version extension with:
composer require fof/upload:1.5.8 ?

luceos

m4v3rick that works

I think you ran into a similar issue as mine (FriendsOfFlarum/uploadissues/431). What Upload Adapter are you using or is the Image Preview trying to resolve?

There was a change somewhere after 1.5 that changed how adapters were resolved from key to class name and that destroys some configurations.

m4v3rick

luceos What Upload Adapter are you using or is the Image Preview trying to resolve?

Here is the screenshot of my settings:

m4v3rick

luceos There was a change somewhere after 1.5 that changed how adapters were resolved from key to class name and that destroys some configurations.

Any idea how I could fix this?

And who is actually maintaining this extension?

Since @davetodave178 posted the

davetodave178 Warning

I am really looking forward to update the extension from 1.5.8 to 1.8.1.

davetodave178

1.8.0 & 1.8.1

What's Changed

chore: add tests for malicious uploads, fix issues exposed by @IanM in FriendsOfFlarum/upload429
fix: change mimetype default in admin UI by @davetodave178 in FriendsOfFlarum/upload430

Full Changelog: FriendsOfFlarum/upload1.7.1 → 1.8.1

⚠️ Warning

This release fixes security vulnerabilities related to malicious file uploads. It also changes the default MIME type configuration for images. Please see the linked PR's for details if your community requires uploading unusual image formats.

It's recommended to upgrade to version 1.8.1 at the earliest convenience:

Updating

composer update fof/upload:"*"
php flarum migrate
php flarum cache:clear

davetodave178

This update also addresses issues with ZIP uploads, which have been reported numerous times here @CyberGene

CyberGene

davetodave178 thank you, testing it right away 👍🏻

P.S. Yes, just tested it and can confirm ZIP file upload works now. Thank you so much 😊

AkarinLiu

I can`t upload jpg or jpeg photo, Is it a Bug？

davetodave178

AkarinLiu Interesting. Can you please share some more details here? https://docs.flarum.org/troubleshoot. Uploding JPG's is working fine for me on version 1.8.1

m4v3rick

Just updated to the latest version and I still have the same error.
Whenever I switch the extension off, everything else works just fine. 🙁

Capybara

Capybara Through trial and error, I found out that the automatic conversion of links into images wasn’t working because of the Fancybox — I disabled it, and everything started working

meihuak

Capybara yes, I also have this issue

V0RT3X

Works fine for me on a fresh installed forum 🙂

gobbledegook

Greetings! Is there a way for this plugin to upload .jpg and convert to .webP format (for the sake of storing images on the same server) I'm a complete newbie and want my community forum that's starting to gain traction to remain fast.

Side Note: I see that there is an ability to store in AWS S3 container.

This should keep the forums loading quickly, right?
Is there a guide or tutorial in order to set this up?
Is there a way to convert (through an extension or script) that when a user uploads image1.jpg it converts to image1.webp from the s3 bucket?

Sorry for all the noob questions, just want the community to have a pleasant experience and also learn more on how to navigate the seriously ~~complex~~ easy world of Flarum!

Silvestrus

Capybara same issue. My moderators can't delete local images from media manager. I have started with imgur and once I noticed that delete is not possible, I switched to local storage, but I'm the only one as administrator that can delete images. Moderators can't do that yet. Are we waiting on update or there is something I can do about it?

Settings

AgapeList

I've just migrated from phpBB and have managed to get the files into the database with the correct tags. I am having difficulty getting the images to show (I am just getting the tag as regular text) unless I manually touch each post. Is there a faster way to do this? I tried using

php flarum fof:upload --map

but I get this error

Command "fof:upload" is not defined.  
                                        
  Did you mean one of these?            
      fof:best-answer:notify            
      fof:best-answer:update-counts     
      fof:gamification:assign-groups    
      fof:gamification:resync          
      fof:gamification:resyncUsers      
      fof:polls:refresh                 
      fof:sitemap:build

I am using the most recent version of flarum and fof/upload

+------------------------------------------+---------+--------+
| Flarum Extensions                        |         |        |
+------------------------------------------+---------+--------+
| ID                                       | Version | Commit |
+------------------------------------------+---------+--------+
| flarum-tags                              | v1.8.3  |        |
| flarum-flags                             | v1.8.2  |        |
| flarum-suspend                           | v1.8.4  |        |
| fof-merge-discussions                    | 1.4.1   |        |
| flarum-sticky                            | v1.8.2  |        |
| fof-pages                                | 1.0.8   |        |
| fof-byobu                                | 1.4.1   |        |
| fof-user-directory                       | 1.4.0   |        |
| michaelbelgium-discussion-views          | v7.3    |        |
| afrux-forum-widgets-core                 | v0.1.7  |        |
| v17development-seo                       | v2.0.5  |        |
| the-turk-stickiest                       | 3.0.1   |        |
| splitbrain-postidredirector              | 1.0.0   |        |
| nodeloc-split-view                       | 1.0.0   |        |
| ianm-same-page-admin                     | 0.1.0   |        |
| ianm-log-viewer                          | 0.1.1   |        |
| fof-user-bio                             | 1.4.2   |        |
| fof-upload                               | 1.8.1   |        |
| fof-terms                                | 1.4.2   |        |
| fof-split                                | 1.1.1   |        |
| fof-socialprofile                        | 1.1.6   |        |
| fof-sitemap                              | 2.2.1   |        |
| fof-prevent-necrobumping                 | 1.1.2   |        |
| fof-pretty-mail                          | 1.1.2   |        |
| fof-polls                                | 2.2.12  |        |
| fof-nightmode                            | 1.6.0   |        |
| fof-masquerade                           | 2.1.6   |        |
| fof-links                                | 1.3.0   |        |
| fof-ignore-users                         | 1.2.1   |        |
| fof-gamification                         | 1.6.8   |        |
| fof-cookie-consent                       | 1.1.3   |        |
| fof-best-answer                          | 1.6.3   |        |
| fof-ban-ips                              | 1.1.2   |        |
| flarum-subscriptions                     | v1.8.1  |        |
| flarum-statistics                        | v1.8.1  |        |
| flarum-mentions                          | v1.8.5  |        |
| flarum-markdown                          | v1.8.1  |        |
| flarum-lock                              | v1.8.2  |        |
| flarum-likes                             | v1.8.1  |        |
| flarum-lang-english                      | v1.8.0  |        |
| flarum-extension-manager                 | v1.0.7  |        |
| flarum-emoji                             | v1.8.1  |        |
| flarum-bbcode                            | v1.8.0  |        |
| dhtml-composer                           | 2.1.5   |        |
| club-1-cross-references                  | v1.1.1  |        |
| clarkwinkelmann-popular-discussion-badge | 1.1.1   |        |
| clarkwinkelmann-mass-actions             | 1.1.2   |        |
| clarkwinkelmann-mailing                  | 1.1.0   |        |
| clarkwinkelmann-author-change            | 1.0.3   |        |
| askvortsov-markdown-tables               | v1.2.1  |        |
| askvortsov-discussion-templates          | v0.8.3  |        |
| afrux-online-users-widget                | v0.1.9  |        |
| afrux-news-widget                        | v0.1.1  |        |
| afrux-forum-stats-widget                 | v0.1.1  |        |
+------------------------------------------+---------+--------+
Base URL: http://flarum.local
Installation path: /Users/redacted/Sites/flarum
Queue driver: sync
Session driver: file
Scheduler status: Inactive
Mail driver: mail

CyberGene

Is this forum broken? It shows there’s a new post in this discussion but there’s no such post.

clarkwinkelmann

CyberGene there was a post awaiting approval above yours

CyberGene

clarkwinkelmann so it’s a bug then, because the discussion shouldn’t have appeared on top of the list and with a bold font (unread), as well as the author of the last (unapproved) post listed. It’s worth checking that scenario, could be a regression on all Flarum forums?

clarkwinkelmann

CyberGene it's a problem with Realtime and/or Pusher. I don't know if it's tracked anywhere but it has happened for as long as I can remember...

« Previous Page