Private discussions developer diary

luceos

yekenuk ? much appreciated!

yekenuk

luceos Least I can do... great developer (heavily use the file upload) and good support.

You also help us Beta users roll it out a little quicker!

luceos

image private-discussionsgif.gif

It's very much still a work in progress. Some stuff to do:

Fix showing user tags on private discussions in the discussion list immediately, instead of only after a refresh.
Drop requirement of Tag or add a default tag, perhaps that's possible for now.
Check what the flagging extension does with this.
Verify permission works when someone should not be able to see a discussion.
Remove already selected users from the dropdown.

staion

You could make it to auto select a tag, maybe the Private tag auto generated by the extension.

JRay

staion I was gonna say the same. A 'Private' tag might work if you have to have one.

jordanjay29

You'd want something that either the user can define, or so unique no one would have the same name already in their existing list of tags. Private might work on some boards, but it might be best if it's userdefined. Or tagless.

staion

jordanjay29 that is way I said Private Messages are not the same as Private Discussions in our case, because a PM in not related with a discussion in any way. A PM system is separated from the normal content of a website/forum...

luceos

I've created a first beta version, see the extension thread for new version announcements. I'll keep this thread as well to focus more on the development aspect of it.

Note if you installed dev-master
Make sure to delete the recipients table and under migrations any entry that belongs to flagrow/messaging or flagrow/byobu, then make sure to run php flarum migrate.

luceos

Seems I forgot about two important things, so I've soft deleted the thread for now:

Private discussions are only visible if you type is:private in search, whereas it makes more sense to have them shown in the normal listing per default.
Anyone typing the URL directly who should have no access can still see the thread and its posts, I still have to hook into that logic and block it.

jordanjay29

EDIT: No longer valid.

tlalok

Hi,

Great job, but I have some worries. I think that with the current system there is a risk of confusion with the forum discussions.

It's not very intuitive, I was lost the first time. So for people who do not use forums regularly, they risk being lost. Putting labels while it's a private discussion does not make sense.

Sorry for my english.

jordanjay29

tlalok Some of that should be resolved with the is:private search gambit, to filter out Private Discussions. I imagine a future feature would be to have a direct link to those.

HavocK

Very promising. I'll test it on my dev.

Keep it up ! :thumbup:

luceos

Reopened the extension thread. See changelog.

UaMV

Eldenroot Can you add more styling into selected users?

I actually removed styling and have found it to fit well with the rest of the Flarum UI. The darker background also allows the private messages to be a bit more identifiable, which I like. Here's what I added…

.RecipientsLabel .RecipientLabel {
    background: #222d23;
    color: white;
    border: none;
    margin-left: 1px;
}
.RecipientLabel:first-child {
    margin-left: 0;
}

Here's the result…

jordanjay29

UaMV I like it. If I were you, I'd just try to add a delimiter between the users for better legibility. The original CSS provides this with the border property, but an ASCII character between them could work too.

luceos

Currently spending some time on adding groups as recipient.

UaMV

jordanjay29 Yeah, I was trying to think on how to do that and it just came to me as I read your post. I modified the code above to add a 1px margin to each element that is not the first-child. I also updated the image to match.

UaMV

jordanjay29 I'd just try to add a delimiter between the users for better legibility.

UaMV I modified the code above to add a 1px margin to each element that is not the first-child.

After making this edit, I now notice that Flarum itself doesn't have any delimiter for multiple generic tags that might be added on a discussion. Could keep that styling out if you want to keep closer to core.

luceos

UaMV if you can make it generic I'd love to include it in the extension by default.

If I leave the background out, does it change much from my current implementation?

UaMV

luceos At this point, if you leave the background out, everything is white. For the background, I used the same color that I have defined as a background color under Admin > Appearance. I don't know if that would work for everyone, but very likely could. Apart from defining that background color, the other styles should be generic enough to fit. It does seem like the user should have some control over this background color as they do with other elements and with tags. So, (1) either pull from that background color already defined in Flarum core or (2) add a color picker somewhere or (3) define a color that users would have to override in custom CSS.

luceos

UaMV (1) either pull from that background color already defined in Flarum core

I'll use the background variable then. It still allows everyone to use custom css to override it anyway. Thanks.

Hms. Seems the label is already using @body-bg..

« Previous Page Next Page »