IanM therealsujitk If I uninstall this extension via terminal to see if it is causing the problem the private discussions data will still be there in SQL right? It won't get erassed? correct. I've just tried signing up on your forum, and can see the error. I'm investigating what might be causing this right now, I'll come back to you ASAP
hrvoje_hr For now you can downgrade with: composer require fof/byobu "0.3.4." On my side everything works great. Thank you for everything @IanM . This is the best thing that happened for Flarum in the long time.
hrvoje_hr @IanM I think I got what's wrong. If you turn off "Add private discussions to user page" setting it breaks the whole Flarum. therealsujitk in the meantime you can still access admin page and turn it on.
IanM hrvoje_hr that's a good point, actually. With these changes, I'd question if that setting is actually relevant now? After all, everything relating to private discussions is now under the user page.
hrvoje_hr IanM With these changes, I'd question if that setting is actually relevant now? After all, everything relating to private discussions is now under the user page. I think the same.
therealsujitk IanM I didn't even realize I had turned it off! ๐ . I just turned it on and the site is back to normal except that there is no Private Discussions in the session dropdown (I'm guessing this is the space above the tags).
hrvoje_hr therealsujitk I'm guessing this is the space above the tags No, it's under the profile on the top right. Though I think that (above tags) would be an even better position.
therealsujitk IanM I got it! I didn't know what the session drop down was until now. I just thought it would make sense to place private discussions here:
therealsujitk hrvoje_hr Though I think that (above tags) would be an even better position. That is true, but it would be odd if when the option is selected it takes you to your profile. So I think for now this is better unless in future it is decided to have a page like the discussion page except for private discussions.
IanM therealsujitk Not a problem! It's actually an oversight on my part when making these changes, so thank you very much for raising the issue and helping to solve it! Credit to @hrvoje_hr for finding the exact reason so quickly too! ๐
IanM 0.4.1 Removes the option from extension settings to 'add private discussions to user page'. This will now always be present, due to the UX improvements introduced in 0.4.0 Addresses the issue reported by @therealsujitk where the forum is broken if this setting is disabled. Updating composer require fof/byobu php flarum migrate php flarum cache:clear Credit to @hrvoje_hr for finding the problem!
therealsujitk IanM Bazaar still has to get refreshed... I will try this soon. Just a point to note though, removing the option completely will show the 'Private Discussion' option to everyone even if the admin of the forum doesn't intend to let non-admins use private discussions (take Discuss for example). You don't have to add this feature back now (or ever) but I thought I'd just bring this up.
IanM therealsujitk perhaps a future improvement is to add a permission check before adding the page and session dropdown link. I'll give it some thought on the best way to handle this
ScottBeeson I just installed this extension and upon enabling it I'm presented with this... Sooo... is this a test? Should I type something? lol
IanM ScottBeeson yes, it was a fast workaround for an issue with the previous release. You can safely ignore that for now, itโs being worked on as we speak ๐
