FriendsOfFlarum Byōbu, well integrated, advanced private discussions

Arnold

EvilExecutor huh! When I enabled debug mode the error disappeared and now I see "Awaiting approval" above the post 😅

Arnold

EvilExecutor I don't know if this can be helpful, but here's the server's response after posting:

Arnold

@luceos tell please, do you plan to release fixed version of Byōbu for b14 or it will be compatible with b15 and up only?

luceos

Arnold right now the plan is for b15 and up. But we're still working on some issues.

IanM

@luceos @askvortsov and I have all been contributing fixes to the updated codebase for byobu.

It's beginning to take some shape now, but will require Flarum beta 15 - so no support for beta 14 in any form I'm afraid.

So far, issues with approval of private discussions, flags and notifications have been resolved, along with some other tweaks too.

I've setup a beta 15 test site, which has many of the updated FoF extensions enabled, plus the very latest dev version of byobu enabled. If you'd like to help us test this upgrade in a central place, where I can easily access error logs, etc, please visit https://test.flarumite.com/ and send me a Private Discussion!

Note: I'll be erasing all content on this server in around 2 weeks time.

Thanks in advance for your help!

askvortsov

MartinJD beta 15 is coming out very soon, and most beta 14 extensions are beta 15 compatible. It should be quite easy to upgrade (nothing like what we saw with beta 14). In fact, even if more breaking changes do occur, I highly doubt extensions will ever have an upgrade as difficult as beta 14.

[deleted]

MartinJD that makes two of us. Easily the most complex upgrade thus far.

IanM

0.6.0-beta.3

Fixed

New private discussions required approval
'Alert' notifications were not triggered
Prevent private discussion started notifications from being delivered to the discussion author
Flagged private discussions appeared in 'All discussions'

Added

Admins can now customize the icon used for Byobu discussion badges and post events FriendsOfFlarum/byobu135
Fully translatable email notification templates
Flarum beta 15 support

Changed

Support for Flarum beta 14 dropped, minimum requirement is now beta 15

Arnold

IanM wow, great! Thanks for the work 👍️

HD3D

IanM Any chance you can update these changes for beta 13 supported version?
I'm facing 'Alert' notifications were not triggered issue for ages, been waiting for help here 😪

luceos

0.6.0 tagged which is just 0.6.0-beta.3 but stable, so during upgrades to beta 15 you won't need to do anything weird. Just set fof/byobu to * and everything will be aok when running a composer update command.

Arnold

luceos I have updated Flarum to b15 and installed Byobu 0.6.0. Still have the same "Oops" error when sending the messages. When I reload a page manually I see that the messages are there but the error doesn't allow the page to refresh normally.

Here's my flarum info (nothing fancy's there):

And these are errors from debug:

Fatal error: Uncaught InvalidArgumentException: Unable to encode data to JSON in Laminas\Diactoros\Response\JsonResponse: Malformed UTF-8 characters, possibly incorrectly encoded in \www\flarum\vendor\laminas\laminas-diactoros\src\Response\JsonResponse.php on line 165

InvalidArgumentException: Unable to encode data to JSON in Laminas\Diactoros\Response\JsonResponse: Malformed UTF-8 characters, possibly incorrectly encoded in \www\flarum\vendor\laminas\laminas-diactoros\src\Response\JsonResponse.php on line 165

IanM

HD3D

0.5.8

For beta 13 only

'Alert' notifications were not triggered

composer require fof/byobu:"*" should do the trick, and also make updating Flarum easier at a later date too 🙂

HD3D

IanM You're the best, issue has been resolved <3

IanM

HD3D No worries 🙂

FYI, it's unlikely that any more updates will be produced for beta 13, etc from now on, unless it's something critical

Arnold

Update. Previous error was spotted on my localhost server. When I updated flarum and byobu on my hosting, I found out that private messages work totally ok.

I don't know if it's connected with my localhost working in Windows environment or you guys already fixed something in the code, but I'm glad it works 🙂

[deleted]

Does this extension work correctly in beta 15 ? I am able to reproduce the same issue in beta 15 as I could in 14. I don't have access to my PC presently, but it's easily replicated (for me anyway) in the sense that if I click on private messages, open a new message, close it, then click any tag, I can't open a new discussion window.

There's definitely a console error which I'll post as soon as I can, but I wondered if anyone else has noticed this ?

[deleted]

[deleted] Console error is as below

Uncaught (in promise) TypeError: Cannot read property 'onunload' of undefined
    at r (extend.js:22)
    at addPollToDiscussion.js:57
extend.js:22 Uncaught (in promise) TypeError: Cannot read property 'onunload' of undefined
    at r (extend.js:22)
    at addPollToDiscussion.js:57
extend.js:22 Uncaught (in promise) TypeError: Cannot read property 'onunload' of undefined
    at r (extend.js:22)
    at addPollToDiscussion.js:57
extend.js:22 Uncaught (in promise) TypeError: Cannot read property 'onunload' of undefined
    at r (extend.js:22)
    at addPollToDiscussion.js:57
PrivateDiscussionComposer.js:29 Uncaught (in promise) TypeError: Cannot read property 'toArray' of undefined
    at e.n.data (PrivateDiscussionComposer.js:29)
    at t.app.initializers.add.et.a.changed (index.js:44)
    at t.<anonymous> (index.js:192)
    at t.<computed> [as preventExit] (extend.js:61)
    at t.e.load (ComposerState.js:48)
    at t.<computed> [as load] (extend.js:25)
    at IndexPage.js:298
    at new Promise (<anonymous>)
    at e.n.newDiscussionAction (IndexPage.js:296)
    at e.t.<computed> [as newDiscussionAction] (extend.js:25)

ctml

Very minor detail: The display name driver is not used for the send <username> a message button on user dropdown, it is hardcoded to username.

sylv38

It looks like there is a new notification bug : when I receive a message, a notification number appears, it's ok. But when I try to open the notifications panel, it stays in loading state and it doesn't display any notification anymore until I read the private message. Is it only in my website or anyone has the same behaviour ?

Edit : I noticed this javascript error when opening panel

TypeError: this.props is undefined href DiscussionCreatedNotification.js:10 view Notification.js:21 a render.js:30 l render.js:155 l render.js:160 l render.js:66 u render.js:50 l render.js:134 l render.js:63 u render.js:50 l render.js:134 l render.js:63 u render.js:50 l render.js:134 l render.js:63 u render.js:50 l render.js:103 l render.js:62 u render.js:50 l render.js:103 l render.js:62 f render.js:423 h render.js:302 f render.js:477 f render.js:416 h render.js:302 f render.js:477 f render.js:416 f render.js:488 f render.js:419 h render.js:302 f render.js:477 f render.js:416 h render.js:302 f render.js:477 f render.js:416 f render.js:488 f render.js:419 h render.js:302 f render.js:477 f render.js:416 h render.js:315 f render.js:477 f render.js:416 f render.js:488 f render.js:419 h render.js:302 exports render.js:964 a mount-redraw.js:14 c mount-redraw.js:25 c mount-redraw.js:23 loadMore NotificationListState.js:63 promise callback*flarum.core</Ee</e.loadMore NotificationListState.js:61 load NotificationListState.js:43 onclick NotificationsDropdown.js:50 handleEvent render.js:888 I render.js:910 k render.js:735 l render.js:730 l render.js:122 l render.js:63 u render.js:50 l render.js:134 l render.js:63 l render.js:162 l render.js:66 u render.js:50 l render.js:134 l render.js:63 u render.js:50 l render.js:134 l render.js:63 l render.js:162 l render.js:66 u render.js:50 h render.js:277 exports render.js:964 mount mount-redraw.js:45 mount ForumApplication.js:123 boot Application.js:176 <anonymous> (index):219 mount-redraw.js:15:23

IanM

sylv38 DiscussionCreatedNotification comes from fof/subscribed. This was corrected in 0.4.1, which version do you have installed?

sylv38

IanM Looks like you're right ! I updated and it solved the bug

« Previous Page Next Page »