FriendsOfFlarum Byōbu, well integrated, advanced private discussions

IanM

1.0.0-beta.4

I'm on a roll today getting byobu into shape so we can finally discard the beta tag.

Cleaned up some duplicated code
Fix broken hyperlink to group recipients (now no hyperlink is provided for groups)
Requires flarum/core version 1.0.2 or above

Installation

composer require fof/byobu:^1.0.0-beta.4
php flarum cache:clear

With your feedback, we'll get this extension into shape very soon, thank you everyone that's helped so far! 🙏

luceos

IanM thank you for your patience with Byobu.

jordanjay29

Haven't confirmed yet on other installs, but I see the inbox link [Private Discussions] on the Discussions List and other user Profiles, but not Own Profile.

Intentional?

IanM

jordanjay29 it would appear so: https://github.com/FriendsOfFlarum/byobu/blob/170259bad80875a104259736c7815021fc0bd5bb/js/src/forum/extend/User.js#L68

@luceos what was the thinking behind this change?

luceos

I'm assuming because the link already exists in the user dropdown and the index.

peopleinside

Thanks for resume sticky.
Now I see the issue is: sticky are showed in all discussion and as I cannot edit tag under private message, i cannot skip to be showed on all discussion 🙂 with an apposite tag.

FriendsOfFlarum/byobu08cb15e

jordanjay29

luceos it was removed from the user dropdown as well 🙈

luceos

jordanjay29 that could be enabled from thr admin?

peopleinside

IanM seems not work.
luceos

From admin profile I created a private message admin - users (group).
As I don't wanna all users get email about this message, i changed community mail to just use log and do not send any email.

The message has been posted in private discussion but if I log in from another normal user profile, I cannot find that message under private message.

Also if a private message is not sticky is showed in all discussion. Private message should be hidden in all discussion list
Send a message to users seems never send email and never be accessible to users

IanM

peopleinside FriendsOfFlarum/byobu08cb15e

Since private discussions no longer have tags, the edit tag modal was removed from them

JRay

@IanM I'm seeing a bug when trying to create a new discussion and add additional members:

DEBUG:

`GET https://golfbuzz.com/api/users

ParseError: syntax error, unexpected 'SearchState' (T_STRING), expecting function (T_FUNCTION) or const (T_CONST) in /var/www/golfbuzz.com/html/vendor/fof/byobu/src/Events/SearchingRecipient.php:18`

IanM

peopleinside do you have v17/support installed by any chance? I found today that extension messes with the policies and stops anyone other than admins seeing private discussions…

IanM

JRay can you post the results of php flarum info please?

JRay

IanM can you post the results of php flarum info please?

IanM

JRay I have a feeling it's your forum's cache not cleared properly

Please try:

composer require fof/byobu:^1.0.0-beta.4
php flarum cache:clear
php flarum assets:publish

JRay

IanM I have a feeling it's your forum's cache not cleared properly

Please try:

Tried that and still getting the error.

I'm able to create new private discussion via the user 3-dot menu no problem. But unable to add users via the Add recipients modal.

IanM

JRay this is very odd.

Are you doing this as a regular user, or admin, mod, etc?

JRay

IanM Are you doing this as a regular user, or admin, mod, etc?

I am an admin. But my users are reporting the same issue.

You are welcome to create an account on the site (https://golfbuzz.com/) and PM me there (screename: jrock)

[deleted]

@IanM one small issue I have noticed is that if you open a new Private Discussion, close it, then try to open another, the below appears in the console

Uncaught (in promise) TypeError: Cannot read property 'toArray' of undefined
    at e.n.data (PrivateDiscussionComposer.js:36)
    at t.app.initializers.add.st.a.changed (index.js:44)
    at t.<anonymous> (index.js:197)
    at t.forEach.t.<computed> [as preventExit] (extend.js:78)
    at t.e.load (ComposerState.js:49)
    at t.forEach.t.<computed> [as load] (extend.js:33)
    at PrivateComposing.js:24
    at new Promise (<anonymous>)
    at t.s.action (PrivateComposing.js:14)
    at $.handleEvent (render.js:888)

IanM

JRay I'm just going to try a couple of things, but yes, I'll give that a shot as well.. I'll report back when I know some more.

[deleted] Thanks for that. Fixed locally, I'll include in the next release (probably in an hour or two)

« Previous Page Next Page »