FriendsOfFlarum Byōbu, well integrated, advanced private discussions

neko

luceos Has anyone running the 0.6 beta met any issues? Otherwise I'll be tagging a stable 0.6 soon.

what do you mean? there's been a few bug reports in this thread o.o

see these about an issue with permissions that makes it so that while byobu is active, every reply to every topic requires approval for everyone:
https://discuss.flarum.org/d/4762-friendsofflarum-by-bu-well-integrated-advanced-private-discussions/743
https://discuss.flarum.org/d/4762-friendsofflarum-by-bu-well-integrated-advanced-private-discussions/746 (not sure why this says it's posted by a deleted user, i'm still here!)
https://discuss.flarum.org/d/4762-friendsofflarum-by-bu-well-integrated-advanced-private-discussions/752
https://discuss.flarum.org/d/4762-friendsofflarum-by-bu-well-integrated-advanced-private-discussions/753

i was unable to replicate this one:
https://discuss.flarum.org/d/4762-friendsofflarum-by-bu-well-integrated-advanced-private-discussions/754

luceos

neko thanks, I missed the approval one I guess.

If someone is able to give this a spin with composer require fof/byobu:dev-master --prefer-dist that would be bliss. Once tested I can tag a new version.

sylv38

luceos It seems that the permissions bug is solved, I can now send private messages.

I noticed something strange after sending a PM : the notification counter displays "1" in red when sending a PM (for the sender), but there is no notification written under. The only way to remove the number 1 is to open the private discussion.

The same for the receiver, the notification number indicates "2" notifications whereas only one notification is listed below.

Scolasticus

luceos I tried but I still experience the same issue as mentioned by @neko (every reply to every topic requires approval for everyone). I just installed via dev-master so should have the current version.

luceos

sylv38 I noticed something strange after sending a PM : the notification counter displays "1" in red when sending a PM (for the sender), but there is no notification written under. The only way to remove the number 1 is to open the private discussion.

The same for the receiver, the notification number indicates "2" notifications whereas only one notification is listed below.

But do you get notifications? I'll have to double check that I guess.

IanM

0.5.7

(beta 13 only)

Fully translatable email notification templates

Language pack maintainers will need to add support for the email notification body, and email subject keys - OR - use fof/linguist

Installing

composer require fof/byobu:^0.5.7
php flarum clear cache:

Note

I'll add the translatable templates into the 0.6.0-beta branch for beta 14+ at a later date, for now, this is the only version of byobu to support this.

sylv38

luceos Yes, I get a notification for receiver in notifications panel and by email, it works !
I simply get also a ghost notification for sender, and a second ghost notification for receiver.

Ouraios

Same as @Scolasticus and @neko i still have to approve all messages posted by my members and even my own messages, even if the approval setting is disabled, i have disabled Byobu for now and waiting for this fix

luceos

There still seems to be an approval issue that has to be tackled.

Arnold

I don't know if this is connected with an approval issue, but every time I'm trying to post a new message in private topic I see "Oops, something went wrong" window. When I reload a page I see that the post is there though. I've tried to post as a user and as admin as well, the error is still pops out. Here's my flarum info.

EvilExecutor

Arnold can you post what the debug says?

Arnold

EvilExecutor huh! When I enabled debug mode the error disappeared and now I see "Awaiting approval" above the post 😅

Arnold

EvilExecutor I don't know if this can be helpful, but here's the server's response after posting:

Arnold

@luceos tell please, do you plan to release fixed version of Byōbu for b14 or it will be compatible with b15 and up only?

luceos

Arnold right now the plan is for b15 and up. But we're still working on some issues.

IanM

@luceos @askvortsov and I have all been contributing fixes to the updated codebase for byobu.

It's beginning to take some shape now, but will require Flarum beta 15 - so no support for beta 14 in any form I'm afraid.

So far, issues with approval of private discussions, flags and notifications have been resolved, along with some other tweaks too.

I've setup a beta 15 test site, which has many of the updated FoF extensions enabled, plus the very latest dev version of byobu enabled. If you'd like to help us test this upgrade in a central place, where I can easily access error logs, etc, please visit https://test.flarumite.com/ and send me a Private Discussion!

Note: I'll be erasing all content on this server in around 2 weeks time.

Thanks in advance for your help!

askvortsov

MartinJD beta 15 is coming out very soon, and most beta 14 extensions are beta 15 compatible. It should be quite easy to upgrade (nothing like what we saw with beta 14). In fact, even if more breaking changes do occur, I highly doubt extensions will ever have an upgrade as difficult as beta 14.

[deleted]

MartinJD that makes two of us. Easily the most complex upgrade thus far.

IanM

0.6.0-beta.3

Fixed

New private discussions required approval
'Alert' notifications were not triggered
Prevent private discussion started notifications from being delivered to the discussion author
Flagged private discussions appeared in 'All discussions'

Added

Admins can now customize the icon used for Byobu discussion badges and post events FriendsOfFlarum/byobu135
Fully translatable email notification templates
Flarum beta 15 support

Changed

Support for Flarum beta 14 dropped, minimum requirement is now beta 15

Arnold

IanM wow, great! Thanks for the work 👍️

HD3D

IanM Any chance you can update these changes for beta 13 supported version?
I'm facing 'Alert' notifications were not triggered issue for ages, been waiting for help here 😪

« Previous Page Next Page »