Flagrow Ads, bombarding your users with ads everywhere, if you want..

luceos

It would help including this <script async src="//pagead2.googlesyndication.com/pagead/js/adsbygoogle.js"></script> globally maybe as part of the "custom footer" in the admin area. This might need to go there as well:

<script>(adsbygoogle = window.adsbygoogle || []).push({});</script>

Then use the <ins> elements to show the ads.

MikeJones

luceos So I tried this and it didn't work. I think there might be an issue with the plugin itself.

MikeJones

copelandarell if you are responding to the update I put in this post here could you explain a little more on what you mean by clicking the logo?

I shouldn't have to navigate back to the home page to get the top bar ad to show when you directly go to a discussion page from a direct link.

With how it works now, no users will see the ads if they come from any place other than the home page.

luceos

Tagged a new version 0.2; after so long it's time for a stable. In addition @Kyrne added some functionality which improves handling of adsense.

MikeJones

@Kyrne assuming that means that I can disable the one you gave me yesterday and update this one?

luceos

MikeJones yes.

matteocontrini

So this line needs to be removed in the ad slot code?

<script>(adsbygoogle = window.adsbygoogle || []).push({});</script>

Thanks

luceos

matteocontrini Yes.

YusufYldrm

Gives the following error during setup

root@sunucu:/var/www/flarum# composer require flagrow/ads
Do not run Composer as root/super user! See https://getcomposer.org/root for details
Using version ^0.2.0@beta for flagrow/ads
./composer.json has been updated
Loading composer repositories with package information
Updating dependencies (including require-dev)
Package operations: 2 installs, 0 updates, 0 removals
As there is no 'unzip' command installed zip files are being unpacked using the PHP zip extension.
This may cause invalid reports of corrupted archives. Besides, any UNIX permissions (e.g. executable) defined in the archives will be lost.
Installing 'unzip' may remediate them.
  - Installing flagrow/ads (0.2.0-beta.1): Loading from cache
  - Installing cdk2020/ads (0.2.0-beta.4): Downloading (failed)    Failed to download cdk2020/ads from dist: The "https://api.github.com/repos/CDK2020/ads/zipball/62738c0d820f32ff4ffdbbb99d3d76eaa5d6a803" file could not be downloaded (HTTP/1.1 404 Not Found)
    Now trying to download from source
  - Installing cdk2020/ads (0.2.0-beta.4): Cloning 62738c0d82


  [RuntimeException]
  Failed to clone https://github.com/CDK2020/ads.git via https, ssh protocols
  , aborting.

  - https://github.com/CDK2020/ads.git
    Cloning into '/var/www/flarum/vendor/cdk2020/ads'...
    remote: Invalid username or password.
    fatal: Authentication failed for 'https://github.com/CDK2020/ads.git/'

  - git@github.com:CDK2020/ads.git
    Cloning into '/var/www/flarum/vendor/cdk2020/ads'...
    git@github.com: Permission denied (publickey).
    fatal: Could not read from remote repository.

    Please make sure you have the correct access rights
    and the repository exists.


require [--dev] [--prefer-source] [--prefer-dist] [--no-progress] [--no-suggest] [--no-update] [--no-scripts] [--update-no-dev] [--update-with-dependencies] [--update-with-all-dependencies] [--ignore-platform-reqs] [--prefer-stable] [--prefer-lowest] [--sort-packages] [-o|--optimize-autoloader] [-a|--classmap-authoritative] [--apcu-autoloader] [--] [<packages>]...

root@sunucu:/var/www/flarum#

luceos

YusufYldrm please post the contents of your composer.json.

MikeJones

should the version be 0.2.0-beta.1 ? I tried updating to get back to this extension and not use the repo that @Kyrne made me while creating the AdSense fix. Right now it says I have version 0.2.0-beta.1 and when I tried it my ads did not show so I went back to @Kyrne version and turned that back on which is version 0.2.0-beta.4 for me.

matteocontrini

@luceos 0.2 hasn't been picked up by Packagist, there's still the beta from last November

luceos

matteocontrini updated, looks like this one needs to be moved to FoF still 😊

YusufYldrm

luceos After updating 0.2.0, admin menu does not open while on main page.
Flarum version: Beta 9
Edit: Also the start new discussion button has stopped working.
@clarkwinkelmann

matteocontrini

YusufYldrm if you use AdSense, make sure you removed this line from your ad slots code:

<script>(adsbygoogle = window.adsbygoogle || []).push({});</script>

AdSense doesn't behave nicely if you execute that more than you should.

MikeJones

matteocontrini assuming that this is why the upgrade didn't fix my issues before?

qurse

luceos This extension is very important for those who use adsense in production. So I believe this plugin needs to be updated quickly. It should be updated and moved to FOF as soon as possible.

luceos

qurse I understand. And it is updated. If you're that concerned about this (and other 3rd party) extension being updated I suggest support our cause by backing Friends of Flarum on Open Collective 😉

matteocontrini

Honestly I'm not sure the last update improved the situation. I'm seeing a lot of blank slots after updating, something I never noticed before. It seems that the push() thing for AdSense isn't actually called when it should.

Looking at the source it seems that the HTML code for the slot is left untouched, so the ad slot isn't actually loaded.

I think I'm going to downgrade to the previous version if this keeps happening...

MikeJones

matteocontrini @Kyrne would the troubleshooting you did last night with me fix this?

« Previous Page Next Page »