Flagrow Ads, bombarding your users with ads everywhere, if you want..

JAC

Does this extension fit ads to size especially in mobile view? Or does it go out of line etc.

Thanks

clarkwinkelmann

JAC the extension just inserts the HTML you give to it.

Responsiveness must be handled by yourself, or ideally the ad service you use should ship with responsive styling out of the box.

matteocontrini

JAC if you use AdSense there are responsive ad units

MikeJones

I tried putting in custom amazon Affiliate banners and I get this error when trying to use them:

3onejs?MarketPlace=US:1 Uncaught TypeError: Cannot read property 'getBoundingClientRect' of null at Object.v.getAAXUrl (onejs?MarketPlace=US:1) at Object.render (onejs?MarketPlace=US:1) at onejs?MarketPlace=US:1

clarkwinkelmann

MikeJones did you copy some code provided by Amazon verbatim? Can you maybe share that code or additional details?

It's very difficult to tell whether the problem is with the extension or simply with the code with just that.

You could also try pasting the same code in Flarum footer HTML to see whether the problem is related to this extension / Mithril or just a general problem with the code / hosting / headers.

MikeJones

clarkwinkelmann

<script type="text/javascript">
amzn_assoc_tracking_id = "myID";
amzn_assoc_ad_mode = "manual";
amzn_assoc_ad_type = "smart";
amzn_assoc_marketplace = "amazon";
amzn_assoc_region = "US";
amzn_assoc_design = "enhanced_links";
amzn_assoc_asins = "asins#";
amzn_assoc_placement = "adunit";
amzn_assoc_linkid = "linkid#";
</script>
<script src="//z-na.amazon-adsystem.com/widgets/onejs?MarketPlace=US"></script>

kevinexit

luceos the in between posts, is it working now? sorry am new here

clarkwinkelmann

kevinexit I have not seen any recent report about that specifically. There are however regular issues with various types of ads that aren't compatible with this extension so the best is to try and see how it goes.

You can share any issue or javascript error message here for us to take a look at 🙂

wloot

clarkwinkelmann kevinexit The in between posts ad slots are added before post stream completely loaded(https://github.com/flarum/core/blob/master/js/src/forum/components/PostStream.js#L243) which may leading to slot disappears or completely white randomly. I tried to hook core PostStream.js to add slot only when post loaded, but there is another issues: in discussions have many posts,flarum will unload posts currently non-visible.

userb

for the add your code here; is anyone able to alternate different code per refresh or a future update provide alternating code option?

huuduy216

so Google gave me a code snippet, I put it in the extension, google detected it on my site and verified it. But I don't see any ads pop up, any idea?
<script data-ad-client="ca-pub-7324694294872308" async src="https://pagead2.googlesyndication.com/pagead/js/adsbygoogle.js"></script>

MikeJones

huuduy216 if no errors in the console sometimes it takes some time before you start getting served ads. Ever so often one or two of my spots will be blank.

huuduy216

Bump... @luceos any idea? Anyone? 🙁

clarkwinkelmann

huuduy216 any javascript error in the browser console? Anything (in)visible with the inspect tool of the browser?

huuduy216

clarkwinkelmann
"Only one Adsense head tag supported per page. The second tag is ignore"

I look at my page source code, can only find one reference to google adsense.
My page is https://talkie.vn/

MikeJones

Is there a reason why this extension does not show in Extiverse?

clarkwinkelmann

MikeJones Extiverse hides extensions that aren't compatible with the latest Flarum version by default. You can see there's (currently) only two pages of results for beta 14, instead of the 26 pages for beta 13.

It's possible to select another Flarum version via a query parameter. But it seems like @luceos did not add any control on the page to change it.

Direct link https://extiverse.com/extension/flagrow/ads

MikeJones

clarkwinkelmann that makes sense thanks!

I am makign a chart for all my exstensions that I have with links to their discuss discussion so I can track when I can upgrade.

KolaBilewu

luceos is there a way to make ads rotate between themself

MikeJones

KolaBilewu What do you mean by rotate?

I created some of my Own ads to place into my flarum and I have them in a list and each time it loads it picks a random number and picks a different ad each time. YOu can basically insert any javascript with this extension

KolaBilewu

MikeJones can i see a sample code how you did yours please

« Previous Page