FriendsOfFlarum Pretty Mail

datitisev · Sep 25, 2019

VanillaScent You're not on 0.1.3, you are on 0.1.2 or below (I can see some code that is used in the views I removed). Run composer require fof/pretty-mail to update.

tankerkiller125 · Sep 25, 2019

datitisev I enabled this plugin and I am now seeing the following error: https://sentry.kilgoretech.com/share/issue/7d89bab0304240ed8de900fc2810777e/ when I attempt to update my email address on my account. I'm using Beta 10 and I have the latest version of this extension. Any ideas?

VanillaScent · Sep 25, 2019

Just checked using flarum info, it does say now I am on 0.1.3
Same error as above, using smtp
new error:

iPurpl3x · Sep 25, 2019

VanillaScent @datitisev I have the same error. It happens when emails settings are on "stmp". Not when they are on "log".

datitisev · Sep 25, 2019

tankerkiller125 VanillaScent iPurpl3x Ok, I apologize. Thanks for the reports, I will try to fix this later today.

Likqez · Sep 26, 2019

If you edit the default template, does it also change the First regestration mail?
Thx in advance Likqez

iPurpl3x · Sep 26, 2019

Likqez I think it doesn't because the Flarum\User\AccountActivationMailer didn't get an Override. This can be added as new feature I think.

datitisev · Sep 26, 2019

Likqez iPurpl3x It should, as the extension also replaces the Mail used by Flarum to add the "prettified view " (using default template) for messages that send raw text (see https://github.com/flarum/core/blob/master/src/User/AccountActivationMailer.php#L69 and https://github.com/FriendsOfFlarum/pretty-mail/blob/master/src/Mailer.php#L26)

chrisonline · Oct 1, 2019

datitisev
I get the same error using "mail" driver.
Did you have time to check this issue? Or did I miss a new version?

datitisev · Oct 1, 2019

chrisonline sorry, haven't had the time to yet.

iPurpl3x · Oct 7, 2019

datitisev I fixed the bug, here is my PR

datitisev · Oct 8, 2019

iPurpl3x Thanks

0.1.4

Hopefully fix from & forum title errors

Updating

composer update fof/pretty-mail

chrisonline · Oct 8, 2019

It works now. Thanks for the fix.

[deleted] · Oct 8, 2019

@datitisev
Thanks for this wonderful Flarum extension!
I was able to almost completely localize this extension, but cannot find where to edit Email subject, i.e., email about "(username) replied to your post in (discussion title)". Once again, this is email subject line.

datitisev · Oct 8, 2019

[deleted] One can edit that by using fof/linguist .

[deleted] · Oct 8, 2019

datitisev One can edit that by using fof/linguist

One shall try.

collins · Oct 10, 2019

Since i updated to ver 10 and added some plugings I keep getting strange feedbacks while trying to post.
When i try to post a discusision, First it says "Oops! Something went wrong. Please reload the page and try again." Then it posts anyway without closing the error dialog. I try multiple times and reload the page then i see all my previous tries as new posts discussions. Now i have to manually delete each duplicate.
This is quite frustrating. Anyone knows what the problem is?

Here is an output

[2019-10-10 21:02:21] production.ERROR: Swift_TransportException: Cannot send message without a sender address in /home/huddioat/public_html/vendor/swiftmailer/swiftmailer/lib/classes/Swift/Transport/AbstractSmtpTransport.php:195
Stack trace:
#0 /home/huddioat/public_html/vendor/swiftmailer/swiftmailer/lib/classes/Swift/Transport/SendmailTransport.php(142): Swift_Transport_AbstractSmtpTransport->send(Object(Swift_Message), Array)
#1 /home/huddioat/public_html/vendor/swiftmailer/swiftmailer/lib/classes/Swift/Mailer.php(71): Swift_Transport_SendmailTransport->send(Object(Swift_Message), Array)
#2 /home/huddioat/public_html/vendor/illuminate/mail/Mailer.php(483): Swift_Mailer->send(Object(Swift_Message), Array)
#3 /home/huddioat/public_html/vendor/illuminate/mail/Mailer.php(259): Illuminate\Mail\Mailer->sendSwiftMessage(Object(Swift_Message))
#4 /home/huddioat/public_html/vendor/illuminate/mail/Mailer.php(171): Illuminate\Mail\Mailer->send(Object(Illuminate\Support\HtmlString), Array, Object(Closure))
#5 /home/huddioat/public_html/vendor/fof/pretty-mail/src/Overrides/NotificationMailer.php(98): Illuminate\Mail\Mailer->html('<html>\n    <hea...', Object(Closure))
#6 /home/huddioat/public_html/vendor/flarum/core/src/Notification/NotificationSyncer.php(202): FoF\PrettyMail\Overrides\NotificationMailer->send(Object(Flarum\Mentions\Notification\UserMentionedBlueprint), Object(Flarum\User\User))
#7 /home/huddioat/public_html/vendor/flarum/core/src/Notification/NotificationSyncer.php(188): Flarum\Notification\NotificationSyncer->mailNotifications(Object(Flarum\Mentions\Notification\UserMentionedBlueprint), Array)
#8 /home/huddioat/public_html/vendor/flarum/core/src/Notification/NotificationSyncer.php(120): Flarum\Notification\NotificationSyncer->sendNotifications(Object(Flarum\Mentions\Notification\UserMentionedBlueprint), Array)
#9 /home/huddioat/public_html/vendor/flarum/mentions/src/Listener/UpdateMentionsMetadataWhenVisible.php(68): Flarum\Notification\NotificationSyncer->sync(Object(Flarum\Mentions\Notification\UserMentionedBlueprint), Array)
#10 /home/huddioat/public_html/vendor/flarum/mentions/src/Listener/UpdateMentionsMetadataWhenVisible.php(48): Flarum\Mentions\Listener\UpdateMentionsMetadataWhenVisible->syncUserMentions(Object(Flarum\Post\CommentPost), Array)
#11 [internal function]: Flarum\Mentions\Listener\UpdateMentionsMetadataWhenVisible->handle(Object(Flarum\Post\Event\Posted))
#12 /home/huddioat/public_html/vendor/illuminate/events/Dispatcher.php(379): call_user_func_array(Array, Array)
#13 /home/huddioat/public_html/vendor/illuminate/events/Dispatcher.php(209): Illuminate\Events\Dispatcher->Illuminate\Events\{closure}('Flarum\\Post\\Eve...', Array)
#14 /home/huddioat/public_html/vendor/flarum/core/src/Foundation/DispatchEventsTrait.php(35): Illuminate\Events\Dispatcher->dispatch('Flarum\\Post\\Eve...')
#15 /home/huddioat/public_html/vendor/flarum/core/src/Post/Command/PostReplyHandler.php(108): Flarum\Post\Command\PostReplyHandler->dispatchEventsFor(Object(Flarum\Post\CommentPost), Object(Flarum\User\User))
#16 /home/huddioat/public_html/vendor/flarum/core/src/Notification/NotificationSyncer.php(158): Flarum\Post\Command\PostReplyHandler->Flarum\Post\Command\{closure}()
#17 /home/huddioat/public_html/vendor/flarum/core/src/Post/Command/PostReplyHandler.php(109): Flarum\Notification\NotificationSyncer->onePerUser(Object(Closure))
#18 /home/huddioat/public_html/vendor/illuminate/bus/Dispatcher.php(90): Flarum\Post\Command\PostReplyHandler->handle(Object(Flarum\Post\Command\PostReply))
#19 /home/huddioat/public_html/vendor/illuminate/pipeline/Pipeline.php(128): Illuminate\Bus\Dispatcher->Illuminate\Bus\{closure}(Object(Flarum\Post\Command\PostReply))
#20 /home/huddioat/public_html/vendor/illuminate/pipeline/Pipeline.php(104): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}(Object(Flarum\Post\Command\PostReply))
#21 /home/huddioat/public_html/vendor/illuminate/bus/Dispatcher.php(98): Illuminate\Pipeline\Pipeline->then(Object(Closure))
#22 /home/huddioat/public_html/vendor/illuminate/bus/Dispatcher.php(76): Illuminate\Bus\Dispatcher->dispatchNow(Object(Flarum\Post\Command\PostReply))
#23 /home/huddioat/public_html/vendor/flarum/core/src/Api/Controller/CreatePostController.php(75): Illuminate\Bus\Dispatcher->dispatch(Object(Flarum\Post\Command\PostReply))
#24 /home/huddioat/public_html/vendor/flarum/core/src/Api/Controller/AbstractSerializeController.php(98): Flarum\Api\Controller\CreatePostController->data(Object(Zend\Diactoros\ServerRequest), Object(Tobscure\JsonApi\Document))
#25 /home/huddioat/public_html/vendor/flarum/core/src/Api/Controller/AbstractCreateController.php(24): Flarum\Api\Controller\AbstractSerializeController->handle(Object(Zend\Diactoros\ServerRequest))
#26 /home/huddioat/public_html/vendor/flarum/core/src/Http/RouteHandlerFactory.php(40): Flarum\Api\Controller\AbstractCreateController->handle(Object(Zend\Diactoros\ServerRequest))
#27 /home/huddioat/public_html/vendor/flarum/core/src/Http/Middleware/DispatchRoute.php(67): Flarum\Http\RouteHandlerFactory->Flarum\Http\{closure}(Object(Zend\Diactoros\ServerRequest), Array)
#28 /home/huddioat/public_html/vendor/zendframework/zend-stratigility/src/Next.php(60): Flarum\Http\Middleware\DispatchRoute->process(Object(Zend\Diactoros\ServerRequest), Object(Closure))
#29 /home/huddioat/public_html/vendor/fof/stopforumspam/src/Middleware/RegisterMiddleware.php(94): Zend\Stratigility\Next->handle(Object(Zend\Diactoros\ServerRequest))
#30 /home/huddioat/public_html/vendor/zendframework/zend-stratigility/src/Next.php(60): FoF\StopForumSpam\Middleware\RegisterMiddleware->process(Object(Zend\Diactoros\ServerRequest), Object(Zend\Stratigility\Next))
#31 /home/huddioat/public_html/vendor/flagrow/terms/src/Middlewares/RegisterMiddleware.php(59): Zend\Stratigility\Next->handle(Object(Zend\Diactoros\ServerRequest))
#32 /home/huddioat/public_html/vendor/zendframework/zend-stratigility/src/Next.php(60): Flagrow\Terms\Middlewares\RegisterMiddleware->process(Object(Zend\Diactoros\ServerRequest), Object(Zend\Stratigility\Next))
#33 /home/huddioat/public_html/vendor/flarum/core/src/Http/Middleware/SetLocale.php(52): Zend\Stratigility\Next->handle(Object(Zend\Diactoros\ServerRequest))
#34 /home/huddioat/public_html/vendor/zendframework/zend-stratigility/src/Next.php(60): Flarum\Http\Middleware\SetLocale->process(Object(Zend\Diactoros\ServerRequest), Object(Zend\Stratigility\Next))
#35 /home/huddioat/public_html/vendor/flarum/core/src/Http/Middleware/CheckCsrfToken.php(33): Zend\Stratigility\Next->handle(Object(Zend\Diactoros\ServerRequest))
#36 /home/huddioat/public_html/vendor/zendframework/zend-stratigility/src/Next.php(60): Flarum\Http\Middleware\CheckCsrfToken->process(Object(Zend\Diactoros\ServerRequest), Object(Zend\Stratigility\Next))
#37 /home/huddioat/public_html/vendor/flarum/core/src/Http/Middleware/AuthenticateWithHeader.php(57): Zend\Stratigility\Next->handle(Object(Zend\Diactoros\ServerRequest))
#38 /home/huddioat/public_html/vendor/zendframework/zend-stratigility/src/Next.php(60): Flarum\Http\Middleware\AuthenticateWithHeader->process(Object(Zend\Diactoros\ServerRequest), Object(Zend\Stratigility\Next))
#39 /home/huddioat/public_html/vendor/flarum/core/src/Http/Middleware/AuthenticateWithSession.php(34): Zend\Stratigility\Next->handle(Object(Zend\Diactoros\ServerRequest))
#40 /home/huddioat/public_html/vendor/zendframework/zend-stratigility/src/Next.php(60): Flarum\Http\Middleware\AuthenticateWithSession->process(Object(Zend\Diactoros\ServerRequest), Object(Zend\Stratigility\Next))
#41 /home/huddioat/public_html/vendor/flarum/core/src/Http/Middleware/RememberFromCookie.php(53): Zend\Stratigility\Next->handle(Object(Zend\Diactoros\ServerRequest))
#42 /home/huddioat/public_html/vendor/zendframework/zend-stratigility/src/Next.php(60): Flarum\Http\Middleware\RememberFromCookie->process(Object(Zend\Diactoros\ServerRequest), Object(Zend\Stratigility\Next))
#43 /home/huddioat/public_html/vendor/flarum/core/src/Http/Middleware/StartSession.php(63): Zend\Stratigility\Next->handle(Object(Zend\Diactoros\ServerRequest))
#44 /home/huddioat/public_html/vendor/zendframework/zend-stratigility/src/Next.php(60): Flarum\Http\Middleware\StartSession->process(Object(Zend\Diactoros\ServerRequest), Object(Zend\Stratigility\Next))
#45 /home/huddioat/public_html/vendor/flarum/core/src/Api/Middleware/FakeHttpMethods.php(31): Zend\Stratigility\Next->handle(Object(Zend\Diactoros\ServerRequest))
#46 /home/huddioat/public_html/vendor/zendframework/zend-stratigility/src/Next.php(60): Flarum\Api\Middleware\FakeHttpMethods->process(Object(Zend\Diactoros\ServerRequest), Object(Zend\Stratigility\Next))
#47 /home/huddioat/public_html/vendor/flarum/core/src/Http/Middleware/ParseJsonBody.php(30): Zend\Stratigility\Next->handle(Object(Zend\Diactoros\ServerRequest))
#48 /home/huddioat/public_html/vendor/zendframework/zend-stratigility/src/Next.php(60): Flarum\Http\Middleware\ParseJsonBody->process(Object(Zend\Diactoros\ServerRequest), Object(Zend\Stratigility\Next))
#49 /home/huddioat/public_html/vendor/flarum/core/src/Http/Middleware/HandleErrors.php(59): Zend\Stratigility\Next->handle(Object(Zend\Diactoros\ServerRequest))
#50 /home/huddioat/public_html/vendor/zendframework/zend-stratigility/src/Next.php(60): Flarum\Http\Middleware\HandleErrors->process(Object(Zend\Diactoros\ServerRequest), Object(Zend\Stratigility\Next))
#51 /home/huddioat/public_html/vendor/zendframework/zend-stratigility/src/MiddlewarePipe.php(83): Zend\Stratigility\Next->handle(Object(Zend\Diactoros\ServerRequest))
#52 /home/huddioat/public_html/vendor/middlewares/request-handler/src/RequestHandler.php(84): Zend\Stratigility\MiddlewarePipe->process(Object(Zend\Diactoros\ServerRequest), Object(Zend\Stratigility\Next))
#53 /home/huddioat/public_html/vendor/zendframework/zend-stratigility/src/Next.php(60): Middlewares\RequestHandler->process(Object(Zend\Diactoros\ServerRequest), Object(Zend\Stratigility\Next))
#54 /home/huddioat/public_html/vendor/middlewares/base-path-router/src/BasePathRouter.php(97): Zend\Stratigility\Next->handle(Object(Zend\Diactoros\ServerRequest))
#55 /home/huddioat/public_html/vendor/zendframework/zend-stratigility/src/Next.php(60): Middlewares\BasePathRouter->process(Object(Zend\Diactoros\ServerRequest), Object(Zend\Stratigility\Next))
#56 /home/huddioat/public_html/vendor/zendframework/zend-stratigility/src/Middleware/OriginalMessages.php(41): Zend\Stratigility\Next->handle(Object(Zend\Diactoros\ServerRequest))
#57 /home/huddioat/public_html/vendor/zendframework/zend-stratigility/src/Next.php(60): Zend\Stratigility\Middleware\OriginalMessages->process(Object(Zend\Diactoros\ServerRequest), Object(Zend\Stratigility\Next))
#58 /home/huddioat/public_html/vendor/middlewares/base-path/src/BasePath.php(53): Zend\Stratigility\Next->handle(Object(Zend\Diactoros\ServerRequest))
#59 /home/huddioat/public_html/vendor/zendframework/zend-stratigility/src/Next.php(60): Middlewares\BasePath->process(Object(Zend\Diactoros\ServerRequest), Object(Zend\Stratigility\Next))
#60 /home/huddioat/public_html/vendor/zendframework/zend-stratigility/src/MiddlewarePipe.php(83): Zend\Stratigility\Next->handle(Object(Zend\Diactoros\ServerRequest))
#61 /home/huddioat/public_html/vendor/zendframework/zend-stratigility/src/MiddlewarePipe.php(72): Zend\Stratigility\MiddlewarePipe->process(Object(Zend\Diactoros\ServerRequest), Object(Zend\Stratigility\EmptyPipelineHandler))
#62 /home/huddioat/public_html/vendor/zendframework/zend-httphandlerrunner/src/RequestHandlerRunner.php(95): Zend\Stratigility\MiddlewarePipe->handle(Object(Zend\Diactoros\ServerRequest))
#63 /home/huddioat/public_html/vendor/flarum/core/src/Http/Server.php(46): Zend\HttpHandlerRunner\RequestHandlerRunner->run()
#64 /home/huddioat/public_html/public/index.php(24): Flarum\Http\Server->listen()
#65 {main}

collins · Oct 10, 2019

I think i've found the culprit fof/prettymail

datitisev · Oct 10, 2019

collins Yep, that's an error with fof/pretty-mail. Try updating to the latest version, I think I released a version with someone's fix for it a few days ago.