Version 1.1.2

  • Fix "alert on homepage" and "see rankings" settings not working correctly together
  • Fix duplicated ranking entries
  • Fix background colors in dark mode
  • Let Flarum pick between GD and Imagick driver to resize images
  • Update to Webpack 5

You need to run php flarum migrate or disable and re-enable the extension for the duplicate fix to apply. Existing duplicate entries will be merged and scores summed.

I assume the reason duplicated entries could exist was a race condition if you catch 2 fish very quickly and the webserver or database temporarily experiences a slow down. I have now added a missing UNIQUE constraint to the database, which means that if the same situation is experienced again, the second request should now result in a 500 error instead of creating a duplicate entry. This is likely the same situation that can also happen with other Flarum unique values, like post numbers on high traffic forums. I expect this to be incredibly rare.

    a month later

    clarkwinkelmann Just wanted to let you know that Catch the Fish is a big hit at the moment on my forum. Competitors are stumbling over each other to catch as many fish as possible, a lot of fun and a lot of extra attention to the forum itself. Thanks Clark 😉

      4 days later

      @clarkwinkelmann Dear Clark, as stated above, Catch the Fish is up and running on my forum but unfortunately we did come across a small bug:

      • On mobile (Safari) it's not possible to hide a fish yourself.
      • On a PC with Firefox it is possible to hide a fish yourself. But on Chrome and Edge it is not. On an iPad it's also not working.

      Could this be fixed?

      Ed

      Version 1.1.3

      • Improve drag and drop compatibility in Chrome and other browsers

      Drag and drop across browser tabs/windows is still possible but now intentionally doesn't provide any feedback.

      Visual feedback for the drop area is only provided when dragging fish inside of the same tab.

      I'm not sure about drag and drop support on mobile though. I have not yet have the opportunity to test the extension on mobile.

        Where are the rankings after a round has finished? It's now empty and we can't see it, that's very embarrassing 😞

          OK, the good news is it's in the DB:
          SELECT users.username, catchthefish_rankings.catch_count FROM catchthefish_rankings, users WHERE catchthefish_rankings.user_id = users.id AND catchthefish_rankings.round_id = 1 ORDER BY catch_count DESC

          I'm saved from being publicly lynched 😮‍💨

          CyberGene The rankings are still there but don't show any more when the round is finished. Best workaround I've found: extend the end time and prohibit the users from catching more fishes or prohibit users from participating in the round completely and make a screenshot which can be published on your forum.

            Thanks, that’s a good suggestion. But it would be nice to have links to past rankings displayed on the rankings page, so hopefully they can be added in a next version 👍🏻

              I was planning to add a page for past rounds, as well as maybe lifetime stats on user profiles, but haven't found the time yet. Maybe for next year 😉

                CyberGene I've got a better workaround:

                • Go to settings, delete all the fishes in that round and set the end time far in the future. Don't delete the round itself.

                Now the ranking of a closed round will show in the rankings page.

                  2 months later

                  Man, you did find a nice way to gamify a forum!

                  Looking forward to test it.

                  5 months later
                  a year later

                  The following error appears after creating a new round (ref.: Durtdawber):

                  flarum.ERROR: TypeError: ClarkWinkelmann\CatchTheFish\Repositories\Placement::randomDiscussion(): Return value must be of type Flarum\Discussion\Discussion, null returned in /data/host/skeleton/vendor/clarkwinkelmann/catch-the-fish/src/Repositories/Placement.php:226

                  clarkwinkelmann/catch-the-fishblob/ab7ace05d37eb0e74f8ef4fc2590ceddeeef407d/src/Repositories/Placement.php#L226

                  It seems that the DB query doesn't return any results, but the forum does have discussions that are older than the configured amount of days in extension's settings. Any idea what could be causing this?

                      SKevo do you have the full backtrace? Do you know if that forum has the tags restriction/probability set up?

                      The discussions need to be more recent than the configured value! The setting is made so only recently active content can get fish. If there are no recent discussions, the setting value should be manually increased.

                          clarkwinkelmann Thank you for the response. I'm the owner of the forum that @SKevo was inquiring about the issue. I read the settings as the discussion / post had to be Older than the configured value. I've changed the settings to a large number since traffic on my new forum is slow and also removed all the forum tags from the whitelist. That seems to have fixed the issue, but...

                          Whenever I setup a new round, the first time a member catches a fish, the forum seems to lock up and clicks on any fish / buttons / controls stop responding and the popup notification about the fish does not come up.. If I do a page refresh, then everything starts working again and the notification of a fish caught pops up on the next fish and all fish thereafter. This only happens on the first fish caught. I have deleted and re-created rounds to reproduce this issue each time. My forum is at https://mytreasurespot.flarum.cloud if you want to create a login and try it.

                          Also, If you set the probability of the fish showing in profiles to 0, will this keep the fish out of the profiles?

                          Thanks!

                            15 days later

                            Quick question, after the round is over, how does the admin go back to see the results. I ran a test tournament and when the end of the round came, all the info for the round disappeared on the rankings page.

                              Durtdawber unfortunately I don't really remember. If it's not visible on that page it might no longer be visible at all. You could temporarily change the end date to make it appear again I think.