Catch The Fish

Lukeman

clarkwinkelmann Thank you ever so much! 👍️

CyberGene

Where are the rankings after a round has finished? It's now empty and we can't see it, that's very embarrassing 😞

Lukeman

CyberGene The rankings are still there but don't show any more when the round is finished. Best workaround I've found: extend the end time and prohibit the users from catching more fishes or prohibit users from participating in the round completely and make a screenshot which can be published on your forum.

CyberGene

OK, the good news is it's in the DB:
SELECT users.username, catchthefish_rankings.catch_count FROM catchthefish_rankings, users WHERE catchthefish_rankings.user_id = users.id AND catchthefish_rankings.round_id = 1 ORDER BY catch_count DESC

I'm saved from being publicly lynched 😮‍💨

CyberGene

Thanks, that’s a good suggestion. But it would be nice to have links to past rankings displayed on the rankings page, so hopefully they can be added in a next version 👍🏻

Lukeman

CyberGene I've got a better workaround:

Go to settings, delete all the fishes in that round and set the end time far in the future. Don't delete the round itself.

Now the ranking of a closed round will show in the rankings page.

clarkwinkelmann

I was planning to add a page for past rounds, as well as maybe lifetime stats on user profiles, but haven't found the time yet. Maybe for next year 😉

Lukeman

clarkwinkelmann Just wanted to let you know that the combination of Catch the Fish and Linguist is top-notch! 😉

juanlanteri

Man, you did find a nice way to gamify a forum!

Looking forward to test it.

SKevo

The following error appears after creating a new round (ref.: Durtdawber):

flarum.ERROR: TypeError: ClarkWinkelmann\CatchTheFish\Repositories\Placement::randomDiscussion(): Return value must be of type Flarum\Discussion\Discussion, null returned in /data/host/skeleton/vendor/clarkwinkelmann/catch-the-fish/src/Repositories/Placement.php:226

clarkwinkelmann/catch-the-fishblob/ab7ace05d37eb0e74f8ef4fc2590ceddeeef407d/src/Repositories/Placement.php#L226

It seems that the DB query doesn't return any results, but the forum does have discussions that are older than the configured amount of days in extension's settings. Any idea what could be causing this?

clarkwinkelmann

SKevo do you have the full backtrace? Do you know if that forum has the tags restriction/probability set up?

The discussions need to be more recent than the configured value! The setting is made so only recently active content can get fish. If there are no recent discussions, the setting value should be manually increased.

Durtdawber

clarkwinkelmann Thank you for the response. I'm the owner of the forum that @SKevo was inquiring about the issue. I read the settings as the discussion / post had to be Older than the configured value. I've changed the settings to a large number since traffic on my new forum is slow and also removed all the forum tags from the whitelist. That seems to have fixed the issue, but...

Whenever I setup a new round, the first time a member catches a fish, the forum seems to lock up and clicks on any fish / buttons / controls stop responding and the popup notification about the fish does not come up.. If I do a page refresh, then everything starts working again and the notification of a fish caught pops up on the next fish and all fish thereafter. This only happens on the first fish caught. I have deleted and re-created rounds to reproduce this issue each time. My forum is at https://mytreasurespot.flarum.cloud if you want to create a login and try it.

Also, If you set the probability of the fish showing in profiles to 0, will this keep the fish out of the profiles?

Thanks!

Durtdawber

Quick question, after the round is over, how does the admin go back to see the results. I ran a test tournament and when the end of the round came, all the info for the round disappeared on the rankings page.

clarkwinkelmann

Durtdawber unfortunately I don't really remember. If it's not visible on that page it might no longer be visible at all. You could temporarily change the end date to make it appear again I think.

« Previous Page