clarkwinkelmann A tag restriction would do the job for me and I'll be more than happy to sponsor this addition. Our game starts in march 2022 so no hurry 😉.

Edit: I noticed that on the rankings page somewhere along the way "place" has been renamed to "name". In my opinion "place" fits better,

    a month later

    clarkwinkelmann

    I gave the registered user the right to fish anywhere in the permissions, but the test still only has management and can release fish anywhere, is this the case, or am I doing something wrong?

        Blind I'm not sure I understand what you're describing. Can you maybe post a screenshot of the extension settings and permissions page?

            clarkwinkelmann

            No, I found that Chrome or Edge can't drag the fish in the fish basket, let the fish out; Firefox can work normally.

            The login account I used for testing is on Edge, and the administrator is Firefox...

                Blind can you try to connect each account in the opposite browser to confirm if it's a permission issue or a browser issue?

                If the user doesn't have the permission to choose fish placement, the fish shouldn't end up in the basket. But if it's already in the basket and can't be moved out, it might just be a browser issue. If it was a permission issue, the fish could be dragged and dropped, and an error would appear.

                    Google Chrome 93.0.4577.63 is also this problem.
                    Firefox 92 Also use the account, but there is no problem.

                    2 months later

                    Version 1.1.0

                    • Added discussion tag whitelist setting
                    • Added probability setting for each type of placement as well as individual discussion tags
                    • Added current location of fish on moderation page
                    • Fixed moderation page showing wrong last placement author

                    Update sponsored by @Lukeman

                      2 months later

                      clarkwinkelmann Hi Clark, I noticed on extiverse that Catch the Fish isn't compatibel with Flarum 1.2.0. Any change this will change somewhere in the near future?

                          Lukeman do you receive any error message? Or is something not showing up?

                          I was not anticipating anything to break with 1.2, but I'll take a look if I have some hint of what might be wrong.

                          EDIT: I missed the word "Extiverse" in your sentence 🤦‍♂️ Well it does show compatible when I check right now so not sure what was up.

                              clarkwinkelmann I have not updated Flarum yet because I wanted to be sure Catch the Fish would still be working, Yesterday it showed not-compatible on Extiverse but now it shows compatible. Thanks for your answer, will update this weekend.

                                22 days later

                                @clarkwinkelmann although not gamebreaking but it looks like a little bug crept into "Catch the Fish":

                                When the alert with the round name is removed from the homepage through the settings, the rankingspage states that there is no active round. The fishes are shown though and can still be caught.

                                Would you be so kind to have a look at this?

                                  Lukeman reading through the source code, maybe the catchthefish.visible permission is not being applied to fishes on the forum? From the code it looks like:

                                  • Rankings show all active rounds, but only if actor has catchthefish.visible permission
                                  • Fishes are shown on the forum if their round is active, ignoring catchthefish.visible permission

                                  So maybe it's due to this?

                                  The homepage alert logic doesn't seem to be connected to the rankings page.

                                      clarkwinkelmann

                                      clarkwinkelmann maybe the catchthefish.visible permission is not being applied to fishes on the forum

                                      Hm, I'm not sure if I follow you correctly. How do I apply the catchthefish.visible permission to the fishes?

                                      As an admin I have all six permission levels for Catch the Fish and I am the only one allowed to see the rankings page. The moment you switch on the alert the rankings page becomes available again and the other way around.

                                          5 days later

                                          Anyone else seeing repeated users on ranking page ? I tried clearing cache of Flarum but it didn't correct page for me

                                            jaypatelani My rankings page shows properly. I've got one active round configured (and still have to turn on the alert on the homepage though).

                                              Version 1.1.2

                                              • Fix "alert on homepage" and "see rankings" settings not working correctly together
                                              • Fix duplicated ranking entries
                                              • Fix background colors in dark mode
                                              • Let Flarum pick between GD and Imagick driver to resize images
                                              • Update to Webpack 5

                                              You need to run php flarum migrate or disable and re-enable the extension for the duplicate fix to apply. Existing duplicate entries will be merged and scores summed.

                                              I assume the reason duplicated entries could exist was a race condition if you catch 2 fish very quickly and the webserver or database temporarily experiences a slow down. I have now added a missing UNIQUE constraint to the database, which means that if the same situation is experienced again, the second request should now result in a 500 error instead of creating a duplicate entry. This is likely the same situation that can also happen with other Flarum unique values, like post numbers on high traffic forums. I expect this to be incredibly rare.