FriendsOfFlarum Subscribed

Ralkage

0.1.1

This security related bug fix should stop user information (such as passwords and email addresses) from being added to the email subject's meta info which was reported here https://discuss.flarum.org/d/20917-friendsofflarum-subscribed/24.

For those of you that have this extension installed, it is advised that you update it ASAP.

Updating

composer require fof/subscribed

ctx

Ralkage 0.1.1
This security related bug fix should stop user information (such as passwords and email addresses) from being added to the email subject

Thank you! I have re-tested and can confirm this issue has been resolved with v0.1.1 on Flarum v0.1.0-beta.10

ctx

Greetings. On your next development pass, please consider updating the subject line for new user subscriptions to include the forum name. This may help those who maintain multiple-forums quickly know where the new user request came from. Understood, the forum name is included in the body, but having it in the subject too would be icing on the cake.

Currently: [New User] CrashTestDummy
Proposed: [Oakhurst at Kingwood] New User CrashTestDummy

Thank you for everything that you do.

Respectfully submitted, Eric

Ralkage

ctx does the following subject line work? 🙂

Proposed: [Forum Name] New User Registration

This should keep things generic (something I think WordPress does?) and simple, leaving the body of the email to include additional useful information and links.

We can also try for:

[Forum Name] New User - ExampleUsername
[Forum Name] New User Registration - ExampleUsername
[Forum Name] New User Just Registered - ExampleUsername

Others that use this extension as well, please let me hear your thoughts! I am considering adding more translations in the future, especially for the email templates so that you can freely edit with fof/linguist (if at all possible 😉).

ctx

Ralkage Proposed: [Forum Name] New User Registration

I think that is acceptable. I don't necessarily wish to know "Who" registered. Knowing which forum is a big help while administrating several. Thanks for the consideration and feedback!

Pollux

Ralkage Others that use this extension as well, please let me hear your thoughts! I am considering adding more translations in the future, especially for the email templates so that you can freely edit with fof/linguist (if at all possible 😉).

What about providing a template system, so admins can freely chose a text for the subject and the body using placeholders like [username], [email], [time] etc. So it would be up to the admin to choose the information provided in the subject line and in the body of the e-mail.

This approach would also provide the necessary means for translations. Of course the extension could offer suggestions for the wording in different languages, but your own phrases will always be possible, so missing translations wouldn't matter a lot.

Ralkage

ctx great! I'll probably whip this up as a translation and if I can't figure out how to tie this in with Flarum settings to get the forum name, I'll just keep the hard-coded text for now 🙂

Pollux that could be arranged, will probably look into it once I get more feedback on other useful notifications that can be added 🙂

brian85 like this one! Could make some room for post deletions as well and possibly discussion approvals 😉

brian85

Hello, it could be more usefull to be noticed that a moderator or an admin has modified your post for example.

dexif

Members doesn't receive notifications because
$recipient->can('viewDiscussions', $discussion) returns false for all registered users except admins. How can i fix it?
Beta 10.

Ralkage

dexif we'll look into it 🙂 feel free to submit a PR if you happen to find a fix before we do!

rob006

dexif Probably the same story as in "follow tags" extension: https://discuss.flarum.org/d/20525-friendsofflarum-follow-tags/32

nitaaikumar

dexif Members doesn't receive notifications because
$recipient->can('viewDiscussions', $discussion) returns false for all registered users except admins. How can i fix it?
Beta 10.

Does this mean that it is incompatible with Beta10 till this is fixed? And does this work along side Flarum's own Subscriptions extension or replaces it? I know it has a few more options like new users and new discussion notifications. Not clear about it. Thanks.

Ralkage

nitaaikumar as far as I know and have tested, it works for Beta 10 🙂 I could not reproduce the bug @dexif indicated. Subscribed is completely independent of Subscriptions and has the two new notification types for new users and newly created discussions.

If you do run into any bugs, please feel free to report it in the GitHub repo for this project 😉

nitaaikumar

Ralkage The emails for new discussions show this message but there are no contents of the first post, only the 3 dashes. Same issue like the pretty email extension. Is it the expected behavior or a bug? It would be good if the whole contents of the first of a new discussion are included in the sent email. Just like the full content shown in default reply emails. Thanks.


Additionally, you can find the contents of the first post in this new discussion below
--

Ralkage

nitaaikumar possibly a bug, would need to investigate 🙂

What email provider are you using to receive email?

nitaaikumar

Ralkage What email provider are you using to receive email?

Yes please. Gmail. The full benefit of having the new subscription option for all all new discussions in this extension is if we receive the full first post by email. It would make it so convenient of not having to come to the forum to read it. I am using the Amazon SES php mail driver. Should I change it to the default mail and check too? Most probably it may be happening for that to. Thanks.

nitaaikumar

Ralkage possibly a bug, would need to investigate

@datitisev has found and fixed the issue for the Pretty Mail extension. Beta 9 removed the contentHtml attribute which is used in the post content for the Subscribed emails. Could you also please replace it with the default attribute found in Flarums's non-html emails which show the full content ie: $blueprint->post->contentHtml to $blueprint->post->formatContent() in the Subscribe extension templates too please?

As per my request here and @jordanjay29's suggestion, can you please add an option to subscribe by email to new posts which go into the approval queue also? It will a great boon to us the admins and mods of forums who have users who post via approval.

Ok @datitisev is kindly doing this now. Thanks.

datitisev

0.2.0

!! REQUIRES FLARUM BETA 10
Subscribe to unapproved posts - receive notifications when a post is created that needs approval
- requires flarum/approval
- notifications disappear when post is approved/deleted
Move notifications to queues
Fix discussion & post visibility issues (hopefully)
Use display name for notifications instead of username
Do not send discussion created notifications to users that have already read the first post
- for e.g. mods that approve discussions, this would result in a notification of a discussion they had already looked at
Properly show post content in emails

Updating

composer require fof/subscribed

nitaaikumar

datitisev Thanks so much. Where is this setting to subscribe by email to the unapproved posts for the admins or mods? I can't see in the Profile or Permissions. Or is it automatically switched on for admins and mods which is great if it is. Will check if the unapproved new discussion emails will stop going to the users who have subscribed to receive all discussions by email and whether they get its full text by email. Please do fix the Follow Tags extension also so that unapproved posts emails don't go the users who have followed a tag at your convenience. Thanks again.

nitaaikumar

datitisev Ok I have tested your kind updates. Now we are receiving the full text of the new discussion first posts by email. And also after this first post of a new discussion is approved, the other users who have subscribed to all new discussions are also getting its full text by email. Approval emails are coming to the admin with full text of both new discussions and new posts. It is so perfect now.

There is only one bug now with approval. When a reply post is approved, the follow tag users subscribed to all the posts in the discussions of the tag they follow are no longer getting that approved post by email, not even an email. Just like they get when the first post in a new discussion is approved. So the Subscribed extension is fixed now. But there is this bug remaining in the Follow Tags extension with regards to approval.

nitaaikumar

datitisev A further follow up. Actually, with Follow Tags 0.3.1 update, all email notfications to other users of the posts in the dicussions of the followed tag have stopped, including even the ones which don't go into the approval queue. Sorry if I am posting in the wrong extension thread, but since these new updates to both the extensions are approval related, I thought it will be easier to post here itself.

« Previous Page Next Page »