FriendsOfFlarum Subscribed

Leanna

Ralkage Is the problem I mentioned solved?

Ralkage

Pollux possibly a planned feature 😉 this is continued work and I mainly just worked on completing the implementation of the initial features/events as well as the update to Beta 9.

Leanna you seem to be the only one having this issue and @katos previously replied to it. Unless someone else reports something similar, even I myself cannot reproduce your issue.

katos

Leanna can you please provide steps to reproduce, as well as more details on your hosting environment. I will have to attempt to replicate this myself and see if I get the same issue.
/ CC @Ralkage

ctx

Greetings. Well done on this extension! I'm seeing a little issue with the subject line content. Rather than some generic subject, I'm seeing what appears to be metadata in the subject line.

Is this perhaps by design? Seeing this on beta.9 and beta.10 - thoughts?

Example ( --- = redacted by me):

Date: Sun, 22 Sep 2019 16:43:28 +0000
Subject: {"username":"Mike","email":"----@---.com","password":"$2y$10$TGOvI9cxgsXB---","joined_at":"2019-09-22
16:43:28","id":12}
From: FLUM --- --- <noreply@---.---.com>
To: arborist <---@---.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Environment:

Flarum 0.1.0-beta.10
PHP 7.2.21
MySQL 10.4.7-MariaDB

Flarum core 0.1.0-beta.10
PHP version: 7.2.21
Loaded extensions: Core, date, libxml, openssl, pcre, sqlite3, zlib, bcmath, calendar, ctype, curl, dom, hash, fileinfo, filter, ftp, gd, gettext, SPL, iconv, intl, json, mbstring, session, standard, mysqlnd, PDO, pdo_mysql, pdo_sqlite, Phar, posix, Reflection, mysqli, SimpleXML, soap, sockets, sodium, exif, tokenizer, xml, xmlreader, xmlwriter, xsl, zip, apcu
+----------------------+----------------+--------+
| Flarum Extensions | | |
+----------------------+----------------+--------+
| ID | Version | Commit |
+----------------------+----------------+--------+
| flarum-lang-english | v0.1.0-beta.10 | |
| flarum-approval | v0.1.0-beta.8 | |
| flarum-bbcode | v0.1.0-beta.8 | |
| flarum-emoji | v0.1.0-beta.10 | |
| flagrow-sitemap | 0.2.0 | |
| flagrow-terms | 0.3.1 | |
| flarum-flags | v0.1.0-beta.9 | |
| fof-ban-ips | 0.1.0 | |
| fof-ignore-users | 0.1.4 | |
| fof-subscribed | 0.1.0 | |
| fof-user-directory | 0.3.3 | |
| flarum-likes | v0.1.0-beta.9 | |
| flarum-lock | v0.1.0-beta.9 | |
| flarum-markdown | v0.1.0-beta.10 | |
| flarum-mentions | v0.1.0-beta.10 | |
| v17development-seo | 1.0.2 | |
| flarum-statistics | v0.1.0-beta.9 | |
| flarum-sticky | v0.1.0-beta.9 | |
| flarum-subscriptions | v0.1.0-beta.9 | |
| flarum-suspend | v0.1.0-beta.9 | |
| flarum-tags | v0.1.0-beta.10 | |
| flagrow-upload | 0.7.1 | |
+----------------------+----------------+--------+

datitisev

ctx That's not good 🙈. Looks like this code is the issue, there was never an actual subject set for the email it seems:

    /**
     * Get the subject line for a notification email.
     *
     * @return string
     */
    public function getEmailSubject()
    {
        return $this->user;
    }

Ralkage

datitisev whoops 🙈

0.1.1

This security related bug fix should stop user information (such as passwords and email addresses) from being added to the email subject's meta info which was reported here https://discuss.flarum.org/d/20917-friendsofflarum-subscribed/24.

For those of you that have this extension installed, it is advised that you update it ASAP.

Updating

composer require fof/subscribed

ctx

Ralkage 0.1.1
This security related bug fix should stop user information (such as passwords and email addresses) from being added to the email subject

Thank you! I have re-tested and can confirm this issue has been resolved with v0.1.1 on Flarum v0.1.0-beta.10

ctx

Greetings. On your next development pass, please consider updating the subject line for new user subscriptions to include the forum name. This may help those who maintain multiple-forums quickly know where the new user request came from. Understood, the forum name is included in the body, but having it in the subject too would be icing on the cake.

Currently: [New User] CrashTestDummy
Proposed: [Oakhurst at Kingwood] New User CrashTestDummy

Thank you for everything that you do.

Respectfully submitted, Eric

Ralkage

ctx does the following subject line work? 🙂

Proposed: [Forum Name] New User Registration

This should keep things generic (something I think WordPress does?) and simple, leaving the body of the email to include additional useful information and links.

We can also try for:

[Forum Name] New User - ExampleUsername
[Forum Name] New User Registration - ExampleUsername
[Forum Name] New User Just Registered - ExampleUsername

Others that use this extension as well, please let me hear your thoughts! I am considering adding more translations in the future, especially for the email templates so that you can freely edit with fof/linguist (if at all possible 😉).

ctx

Ralkage Proposed: [Forum Name] New User Registration

I think that is acceptable. I don't necessarily wish to know "Who" registered. Knowing which forum is a big help while administrating several. Thanks for the consideration and feedback!

Pollux

Ralkage Others that use this extension as well, please let me hear your thoughts! I am considering adding more translations in the future, especially for the email templates so that you can freely edit with fof/linguist (if at all possible 😉).

What about providing a template system, so admins can freely chose a text for the subject and the body using placeholders like [username], [email], [time] etc. So it would be up to the admin to choose the information provided in the subject line and in the body of the e-mail.

This approach would also provide the necessary means for translations. Of course the extension could offer suggestions for the wording in different languages, but your own phrases will always be possible, so missing translations wouldn't matter a lot.

Ralkage

ctx great! I'll probably whip this up as a translation and if I can't figure out how to tie this in with Flarum settings to get the forum name, I'll just keep the hard-coded text for now 🙂

Pollux that could be arranged, will probably look into it once I get more feedback on other useful notifications that can be added 🙂

brian85 like this one! Could make some room for post deletions as well and possibly discussion approvals 😉

brian85

Hello, it could be more usefull to be noticed that a moderator or an admin has modified your post for example.

dexif

Members doesn't receive notifications because
$recipient->can('viewDiscussions', $discussion) returns false for all registered users except admins. How can i fix it?
Beta 10.

Ralkage

dexif we'll look into it 🙂 feel free to submit a PR if you happen to find a fix before we do!

rob006

dexif Probably the same story as in "follow tags" extension: https://discuss.flarum.org/d/20525-friendsofflarum-follow-tags/32

nitaaikumar

dexif Members doesn't receive notifications because
$recipient->can('viewDiscussions', $discussion) returns false for all registered users except admins. How can i fix it?
Beta 10.

Does this mean that it is incompatible with Beta10 till this is fixed? And does this work along side Flarum's own Subscriptions extension or replaces it? I know it has a few more options like new users and new discussion notifications. Not clear about it. Thanks.

Ralkage

nitaaikumar as far as I know and have tested, it works for Beta 10 🙂 I could not reproduce the bug @dexif indicated. Subscribed is completely independent of Subscriptions and has the two new notification types for new users and newly created discussions.

If you do run into any bugs, please feel free to report it in the GitHub repo for this project 😉

nitaaikumar

Ralkage The emails for new discussions show this message but there are no contents of the first post, only the 3 dashes. Same issue like the pretty email extension. Is it the expected behavior or a bug? It would be good if the whole contents of the first of a new discussion are included in the sent email. Just like the full content shown in default reply emails. Thanks.


Additionally, you can find the contents of the first post in this new discussion below
--

« Previous Page Next Page »