Show Password

therealsujitk

askvortsov I agree, might have to ask @luceos about this.

tankerkiller125

therealsujitk I would recommend making the PR, we can then have a discussion about it on Github where that kind of discussion normally takes place.

therealsujitk

tankerkiller125 Alright! But will the checkbox be better or an eye icon?

therealsujitk

tankerkiller125 The issue is fixed now. Just needed a little more experience with Flarum to figure it out. Is it a good idea to submit a PR to core? Or is it better if people just install this extension.

Ralkage

Kylo could just have a setting to allow one or the other or both 👀

Kylo

Ralkage well, it's an option 😄 but i don't think you will add this setting to the core though.

tankerkiller125

therealsujitk I'd say stick to the checkbox for right now and that can be something that gets discussed in the pull request.

therealsujitk

tankerkiller125 Alright! I'll do it tomorrow because it's getting late here.

Littlegolden

Like this site,(See video below) the eye is on the right side of the password box, long press the eyes to show the password.

therealsujitk

Littlegolden the thing is in all of these examples, the text boxes are left-aligned. But Flarum text boxes are centre-aligned. It would odd if I change only the LogIn and SignUp Modals to left-aligned. I'll try a few and see which looks best.

goodmuyis

therealsujitk
Here is a beautiful css that will work without tampering with the text input. I make use of the font-awesome to add the fa-eye icon. re-position the show password element .

The Only problem is on the signup modal, the eye-icon is not well position because i cannot find any unique css selection for either of the login or signup form to use in styling it.
See live demo here https://afoa.ga/

.Form--centered {position:relative}
.Form--centered > label.checkbox {
    position:absolute;
    font-size:0px;
    right: 0px;
    bottom: 117px;
    visibility: hidden;
}
.SignUpModal .Form--centered > label.checkbox {bottom: 80px;} /*fixed Signupmodal*/
.Form--centered > label.checkbox:after{
    content: "\f06e";
    display: inline-block;
    font-size: inherit;
    text-rendering: auto;
    -webkit-font-smoothing: antialiased;
    -moz-osx-font-smoothing: grayscale;
    font-family: 'Font Awesome 5 Free';
    font-weight: 900;
    font-size: 28px;
    position:absolute;
    right: 10px;
    visibility:visible !important;
}

This is my fist public post on Flarum

yhuchs

therealsujitk You can try adding custom CSS, which leaves the text to the left.
.Form--centered .FormControl[type=text], .Form--centered .FormControl[type=email], .Form--centered .FormControl[type=password] { text-align: left; }

Kylo

goodmuyis You could try LogInModal & SignUpModal classes.

tankerkiller125

goodmuyis The login one looks great, but the register one appears quite low (actually lower than the input)

goodmuyis

Kylo Thanks I missed that.

therealsujitk

v1.0.2

Fixed therealsujitk/flarum-ext-show-password#1: Password box automatically changes it's type back to "password" even when the 'Show Password' box is checked.

Updating

Use Bazaar or update manually with composer.

composer update therealsujitk/flarum-ext-show-password

Littlegolden

therealsujitk Due to the old constraints, composer cannot be used to update. we need to modify the old constraint of composer.json to run composer update command.

therealsujitk

Littlegolden I think there's something wrong with your composer. Me and several others were able to update this successfully.

Littlegolden

therealsujitk Yeah, maybe

therealsujitk

Littlegolden were you able to update it in the end?

Littlegolden

therealsujitk I removed and reinstalled~ It was succeed.

« Previous Page Next Page »