Show Password

tankerkiller125

goodmuyis The login one looks great, but the register one appears quite low (actually lower than the input)

goodmuyis

Kylo Thanks I missed that.

therealsujitk

v1.0.2

Fixed therealsujitk/flarum-ext-show-password#1: Password box automatically changes it's type back to "password" even when the 'Show Password' box is checked.

Updating

Use Bazaar or update manually with composer.

composer update therealsujitk/flarum-ext-show-password

Littlegolden

therealsujitk Due to the old constraints, composer cannot be used to update. we need to modify the old constraint of composer.json to run composer update command.

therealsujitk

tankerkiller125 The issue is fixed now. Just needed a little more experience with Flarum to figure it out. Is it a good idea to submit a PR to core? Or is it better if people just install this extension.

therealsujitk

Littlegolden I think there's something wrong with your composer. Me and several others were able to update this successfully.

Littlegolden

therealsujitk Yeah, maybe

therealsujitk

Littlegolden were you able to update it in the end?

Littlegolden

therealsujitk I removed and reinstalled~ It was succeed.

therealsujitk

Littlegolden Ok cool!

henryonsoftware

Don't you think we should add an eye at password input instead of checkbox? Just my humble opinion.

therealsujitk

henryonsoftware Don't you think we should add an eye at password input instead of checkbox? Just my humble opinion.

I currently don't have a lot of time on my hands, studying for entrance exams to get into a good college, but when I do (soon hopefully) I will definitely add a feature to have the icon and let admins choose whether they want the check box or the eye.

Littlegolden

Just found a missing issue. In Create User module, the problem of showing the password still exists.

therealsujitk

Littlegolden Just found a missing issue. In Create User module, the problem of showing the password still exists.

I have no idea what 'Create User' is. I'm guessing it uses one of the modals from Flarum itself. I have a guess of what the issue might be though let me publish a new release in like 5 minutes.

therealsujitk

tankerkiller125 Yes, that's what I though.
Littlegolden The issue should probably be fixed now.

tankerkiller125

therealsujitk "Create User" is probably the registration page.

clarkwinkelmann

therealsujitk I have no idea what 'Create User' is

Create user is one of my extensions which provides a modal that extends SignUpModal https://github.com/clarkwinkelmann/flarum-ext-create-user-modal/blob/master/js/src/forum/modals/CreateUserModal.js

Good to know that the fix worked.

therealsujitk

v1.0.3

Fixed possible issue with SignUp modal.

Updating

Use Bazaar or update manually with composer.

composer update therealsujitk/flarum-ext-show-password

Littlegolden

therealsujitk I wish you a triumphant return in the entrance exam!

therealsujitk Yeah, it fixed. Thank you~

henryonsoftware

therealsujitk Love to hear that! 😃

therealsujitk

Littlegolden Thankyou!!! 😊

therealsujitk

clarkwinkelmann Oh cool!

« Previous Page Next Page »