Diff for Flarum

Littlegolden

theportablegeek Yeah, that issur has been fixed.

Yalfoosh

theportablegeek I still have the issue as well, we have to wait until the stable release I guess 🙂

theportablegeek

Yalfoosh not sure if you are running the Nickname Changer Extension but if you are - disable it and it should work for you!

Kylo

theportablegeek Yeah, just saw that but I won't support it. Because it seems pointless to put effort into it, we all already have an username on Flarum but that extension adds a secondary username called nickname. If you're not happy with your username what's the point of covering it with a nickname? What if I'm not happy with my nickname either? Should I cover it with a secondary nickname, too? I recommend you to use Username Request by FriendsOfFlarum instead.

theportablegeek

Kylo Totally makes sense - and glad I was able to figure out what was going on 😄

Happy to drop the Nickname extension for this awesome extension - especially with the planned changes!

Kylo

`1.0.0`

Diff Collage

From now on, I won't touch your revisions again (unless a vital issue reported 🤐).

I've changed lots of things. See changelog for full list. Here are some important notes:

This extension conflicts with dem13n/nickname-changer package. Use fof/username-request instead.

If you're using the-turk/flarum-edit-notifications extension, you should update it to v0.1.4

composer update the-turk/flarum-edit-notifications:0.1.4

New layout may not work for some browsers. Click here to see supported ones (including IE10+).

You need to update s9e/text-formatter to v2.3.7 for syntax highlighting in revision previews (skip this step if you didn't update flarum/core to beta 12 yet).

composer update s9e/text-formatter:2.3.7

There are new lines & few changes for translators. You can check the en.yml's history on GitHub to find out what's been changed (it's a bit much, sorry for that).

Updating

It's a fresh start so, get rid of the previous version and install the new one. 😏

composer remove the-turk/flarum-diff
composer require the-turk/flarum-diff:1.0.0
php flarum migrate
php flarum cache:clear

theportablegeek

🙌

Littlegolden

seems the bug comes back

Kylo

Littlegolden I can't reproduce it, there might be an another confliction.

Could you check https://yourflarum.org/api/diff?id={post-id} ? You can get the post's id using mentions (@Littlegolden#125160 (post-id: 125160)).

Littlegolden

Kylo okay, my bad, I didn't close the NickName Changer plugin.
Now find another problem, ToolTip won't disappear after clicking the button (unless the mouse hover once)

Kylo

Littlegolden which browser are you on? Do you have any js errors?

Littlegolden

Kylo I'm using Google Chrome 80.0.3987.149, and no js erroes. (https://bbs.itnt.xyz/d/4-test)

Kylo

Littlegolden Okay, let me check it. You can hide them in the meantime:

.diffTooltip { display:none; }

Kylo

Littlegolden

`1.0.1`

Fix tooltips won't disappear on Chrome.

composer update the-turk/flarum-diff

Littlegolden

Kylo Thank you!

Kylo

Some non-utf8 chars may cause "No Revisions" message in dropdown list (happens scarcely). This was a bug on jfcherng/php-diff repository and he solved it on v6.6.2. I don't want to tag a new release just for this so please update it if you're using an older version:

composer update jfcherng/php-diff

Kylo

After few messages I received, I've decided to force users to remove/update packages which are causing some problems. These packages will not be allowed to be installed together with this package anymore.

`1.0.2`

Fix duplicated variable definition in DiffList Component.
Fix a char-level typo (thanks to @Csineneo).
Use static variable scope to store old post's content.
Set conflictions.
Update dependencies.

composer update the-turk/flarum-diff

HD3D

Kylo I'm stuck on v1.0.0
Composer says noting to install or update

tolgaaaltas

HD3D Try this:
composer require the-turk/flarum-diff:1.0.2

Kylo

HD3D I'm 99% sure you either have dem13n/nickname-changer or the-turk/flarum-edit-notifications < 0.1.4 installed but (maybe) not activated

run to see what's wrong:

composer why-not the-turk/flarum-diff 1.0.2

HD3D

Kylo ☹️

flarum/flarum         -      requires          the-turk/flarum-diff (1.0.1)
the-turk/flarum-diff  1.0.2  conflicts         dem13n/nickname-changer (>=0.1.0)
the-turk/flarum-diff  1.0.2  conflicts         the-turk/flarum-edit-notifications (<0.1.4)
the-turk/flarum-diff  1.0.2  requires          s9e/text-formatter (^2.3.7)
flarum/flarum         -      does not require  s9e/text-formatter (but 1.4.5 is installed)

DursunCan

Kylo

root@localhost:/var/www/sourceturk/forum# composer require the-turk/flarum-diff:1.0.2
Do not run Composer as root/super user! See https://getcomposer.org/root for details
./composer.json has been updated
Loading composer repositories with package information
Updating dependencies (including require-dev)
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - Can only install one of: jfcherng/php-diff[6.7.1, 6.6.4].
    - Can only install one of: jfcherng/php-diff[6.7.1, 6.6.4].
    - Can only install one of: jfcherng/php-diff[6.7.1, 6.6.4].
    - the-turk/flarum-diff 1.0.2 requires jfcherng/php-diff ^6.7.1 -> satisfiable by jfcherng/php-diff[6.7.1].
    - Installation request for the-turk/flarum-diff 1.0.2 -> satisfiable by the-turk/flarum-diff[1.0.2].
    - Installation request for jfcherng/php-diff (locked at 6.6.4) -> satisfiable by jfcherng/php-diff[6.6.4].


Installation failed, reverting ./composer.json to its original content.

« Previous Page Next Page »