Diff for Flarum

Littlegolden

seems the bug comes back

Kylo

Littlegolden I can't reproduce it, there might be an another confliction.

Could you check https://yourflarum.org/api/diff?id={post-id} ? You can get the post's id using mentions (@Littlegolden#125160 (post-id: 125160)).

Littlegolden

Kylo okay, my bad, I didn't close the NickName Changer plugin.
Now find another problem, ToolTip won't disappear after clicking the button (unless the mouse hover once)

Kylo

Littlegolden which browser are you on? Do you have any js errors?

Littlegolden

Kylo I'm using Google Chrome 80.0.3987.149, and no js erroes. (https://bbs.itnt.xyz/d/4-test)

Kylo

Littlegolden Okay, let me check it. You can hide them in the meantime:

.diffTooltip { display:none; }

Kylo

Littlegolden

`1.0.1`

Fix tooltips won't disappear on Chrome.

composer update the-turk/flarum-diff

Littlegolden

Kylo Thank you!

Kylo

Some non-utf8 chars may cause "No Revisions" message in dropdown list (happens scarcely). This was a bug on jfcherng/php-diff repository and he solved it on v6.6.2. I don't want to tag a new release just for this so please update it if you're using an older version:

composer update jfcherng/php-diff

Kylo

After few messages I received, I've decided to force users to remove/update packages which are causing some problems. These packages will not be allowed to be installed together with this package anymore.

`1.0.2`

Fix duplicated variable definition in DiffList Component.
Fix a char-level typo (thanks to @Csineneo).
Use static variable scope to store old post's content.
Set conflictions.
Update dependencies.

composer update the-turk/flarum-diff

HD3D

Kylo I'm stuck on v1.0.0
Composer says noting to install or update

tolgaaaltas

HD3D Try this:
composer require the-turk/flarum-diff:1.0.2

Kylo

HD3D I'm 99% sure you either have dem13n/nickname-changer or the-turk/flarum-edit-notifications < 0.1.4 installed but (maybe) not activated

run to see what's wrong:

composer why-not the-turk/flarum-diff 1.0.2

HD3D

Kylo ☹️

flarum/flarum         -      requires          the-turk/flarum-diff (1.0.1)
the-turk/flarum-diff  1.0.2  conflicts         dem13n/nickname-changer (>=0.1.0)
the-turk/flarum-diff  1.0.2  conflicts         the-turk/flarum-edit-notifications (<0.1.4)
the-turk/flarum-diff  1.0.2  requires          s9e/text-formatter (^2.3.7)
flarum/flarum         -      does not require  s9e/text-formatter (but 1.4.5 is installed)

Kylo

HD3D

composer remove dem13n/nickname-changer
composer update the-turk/flarum-edit-notifications
composer update the-turk/flarum-diff

DursunCan

Kylo

root@localhost:/var/www/sourceturk/forum# composer require the-turk/flarum-diff:1.0.2
Do not run Composer as root/super user! See https://getcomposer.org/root for details
./composer.json has been updated
Loading composer repositories with package information
Updating dependencies (including require-dev)
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - Can only install one of: jfcherng/php-diff[6.7.1, 6.6.4].
    - Can only install one of: jfcherng/php-diff[6.7.1, 6.6.4].
    - Can only install one of: jfcherng/php-diff[6.7.1, 6.6.4].
    - the-turk/flarum-diff 1.0.2 requires jfcherng/php-diff ^6.7.1 -> satisfiable by jfcherng/php-diff[6.7.1].
    - Installation request for the-turk/flarum-diff 1.0.2 -> satisfiable by the-turk/flarum-diff[1.0.2].
    - Installation request for jfcherng/php-diff (locked at 6.6.4) -> satisfiable by jfcherng/php-diff[6.6.4].


Installation failed, reverting ./composer.json to its original content.

Kylo

DursunCan It's weird and I'm not sure why is that happening but try to update dependency first, using:

composer update jfcherng/php-diff:6.7.1

then try again with

composer update the-turk/flarum-diff:1.0.2

HD3D

Kylo
Removed nickname changer
Updated edit notifications

But still getting this error:

flarum/flarum         -      requires          the-turk/flarum-diff (1.0.1)
the-turk/flarum-diff  1.0.2  requires          s9e/text-formatter (^2.3.7)
flarum/flarum         -      does not require  s9e/text-formatter (but 1.4.5 is installed)

Kylo

HD3D ohhh which Flarum version are you on? I completely forgot the fact that TextFormatter updated on beta12

HD3D

Kylo Oh yeah I didn't update to beta12 yet 😕

« Previous Page Next Page »