Diff for Flarum

Kylo

After few messages I received, I've decided to force users to remove/update packages which are causing some problems. These packages will not be allowed to be installed together with this package anymore.

`1.0.2`

Fix duplicated variable definition in DiffList Component.
Fix a char-level typo (thanks to @Csineneo).
Use static variable scope to store old post's content.
Set conflictions.
Update dependencies.

composer update the-turk/flarum-diff

HD3D

Kylo I'm stuck on v1.0.0
Composer says noting to install or update

tolgaaaltas

HD3D Try this:
composer require the-turk/flarum-diff:1.0.2

Kylo

HD3D I'm 99% sure you either have dem13n/nickname-changer or the-turk/flarum-edit-notifications < 0.1.4 installed but (maybe) not activated

run to see what's wrong:

composer why-not the-turk/flarum-diff 1.0.2

HD3D

Kylo ☹️

flarum/flarum         -      requires          the-turk/flarum-diff (1.0.1)
the-turk/flarum-diff  1.0.2  conflicts         dem13n/nickname-changer (>=0.1.0)
the-turk/flarum-diff  1.0.2  conflicts         the-turk/flarum-edit-notifications (<0.1.4)
the-turk/flarum-diff  1.0.2  requires          s9e/text-formatter (^2.3.7)
flarum/flarum         -      does not require  s9e/text-formatter (but 1.4.5 is installed)

DursunCan

Kylo

root@localhost:/var/www/sourceturk/forum# composer require the-turk/flarum-diff:1.0.2
Do not run Composer as root/super user! See https://getcomposer.org/root for details
./composer.json has been updated
Loading composer repositories with package information
Updating dependencies (including require-dev)
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - Can only install one of: jfcherng/php-diff[6.7.1, 6.6.4].
    - Can only install one of: jfcherng/php-diff[6.7.1, 6.6.4].
    - Can only install one of: jfcherng/php-diff[6.7.1, 6.6.4].
    - the-turk/flarum-diff 1.0.2 requires jfcherng/php-diff ^6.7.1 -> satisfiable by jfcherng/php-diff[6.7.1].
    - Installation request for the-turk/flarum-diff 1.0.2 -> satisfiable by the-turk/flarum-diff[1.0.2].
    - Installation request for jfcherng/php-diff (locked at 6.6.4) -> satisfiable by jfcherng/php-diff[6.6.4].


Installation failed, reverting ./composer.json to its original content.

Kylo

HD3D

composer remove dem13n/nickname-changer
composer update the-turk/flarum-edit-notifications
composer update the-turk/flarum-diff

HD3D

Kylo
Removed nickname changer
Updated edit notifications

But still getting this error:

flarum/flarum         -      requires          the-turk/flarum-diff (1.0.1)
the-turk/flarum-diff  1.0.2  requires          s9e/text-formatter (^2.3.7)
flarum/flarum         -      does not require  s9e/text-formatter (but 1.4.5 is installed)

Kylo

DursunCan It's weird and I'm not sure why is that happening but try to update dependency first, using:

composer update jfcherng/php-diff:6.7.1

then try again with

composer update the-turk/flarum-diff:1.0.2

DursunCan

Kylo

root@localhost:/var/www/sourceturk/forum# composer update jfcherng/php-diff:6.7.1
Do not run Composer as root/super user! See https://getcomposer.org/root for details
Package "jfcherng/php-diff:6.7.1" listed for update is not installed. Ignoring.
Loading composer repositories with package information
Updating dependencies (including require-dev)
Nothing to install or update
Package mtdowling/cron-expression is abandoned, you should avoid using it. Use dragonmantank/cron-expression instead.
Generating autoload files
Carbon 1 is deprecated, see how to migrate to Carbon 2.
https://carbon.nesbot.com/docs/#api-carbon-2
    You can run './vendor/bin/upgrade-carbon' to get help in updating carbon and other frameworks and libraries that depend on it.
root@localhost:/var/www/sourceturk/forum# composer update the-turk/flarum-diff:1.0.2
Do not run Composer as root/super user! See https://getcomposer.org/root for details
Package "the-turk/flarum-diff:1.0.2" listed for update is not installed. Ignoring.
Loading composer repositories with package information
Updating dependencies (including require-dev)
Nothing to install or update
Package mtdowling/cron-expression is abandoned, you should avoid using it. Use dragonmantank/cron-expression instead.
Generating autoload files
Carbon 1 is deprecated, see how to migrate to Carbon 2.
https://carbon.nesbot.com/docs/#api-carbon-2
    You can run './vendor/bin/upgrade-carbon' to get help in updating carbon and other frameworks and libraries that depend on it.
root@localhost:/var/www/sourceturk/forum# composer info --outdated --direct
Do not run Composer as root/super user! See https://getcomposer.org/root for details
the-turk/flarum-diff                        1.0.1             1.0.2             View post edit histories.

DursunCan

Kylo solved. with composer require.

Kylo

HD3D ohhh which Flarum version are you on? I completely forgot the fact that TextFormatter updated on beta12

HD3D

Kylo Oh yeah I didn't update to beta12 yet 😕

Kylo

HD3D sorry for the inconvenience. 🙊

`1.0.3`

Drop s9e/text-formatter ^2.3.7 requirement for flarum/core < beta 12

HD3D

Kylo Perfectly working now sir, Thank you so much 🙂

Littlegolden

It seems that the wrong creator will be displayed on a long-term post.

Kylo

Littlegolden it seems like the zeroth revision (which is indicating the original post) gets wrong actor when the post edited by another user. I'll look into it, thanks for the report 😉 only thing you can do as a work-around is fixing it on db side by changing actor id for that post's zeroth revision.

Kylo

Littlegolden I fixed it among other small bugs but we need to solve the-turk/flarum-diff7 before releasing the new version and I wonder your thoughts on this too.

Kylo

`1.0.4`

Fix zeroth revision (original content) gets wrong actor when post edited by another user.
Fix post owners can't delete or rollback to revisions made by another user.
Fix misaligned grid and flex layouts for IE.
Fix tooltips won't appear on disabled buttons.
Fix some strings can't be translated to other languages properly. (issue #7)
Fix mislabeled tooltips for fa-eye and fa-columns icons when you switch to any revision from zeroth revision and vice versa.

composer update the-turk/flarum-diff

Kylo

⚠️ HEADS UP

`1.0.5`

Fix a SECURITY related issue which arises when you disable text formatting for previews.
Fix "Options" should be hidden for last revision if it's the only non-deleted revision. (issue #8)
Fix tooltip color for deleted revisions. (issue #9)
Fix can't render new lines if you disable text formatting for previews. (issue #10)

Sorry for back-to-back releases which happened in a short period of time. I'm trying to improve this extension as much as I can when time permits.

DursunCan

Kylo

EN
I get an error when I edit and save a message when the plug-in is open. Then I press it again and it saves it. Editing works fine when I close the plugin.

TR
Eklenti açık iken mesaj düzenleyip kaydet dediğimde hata alıyorum. Sonra tekrar basıyorum ve kaydediyor. Eklentiyi kapadığımda ise düzenleme sorunsuz çalışıyor.

EDIT:

EN
I think I found the problem. The plugin works with jfcherng / php-diff 6.7.1. Corrupted after updating to version 6.7.2.

TR
Sorunu galiba buldum. Eklenti jfcherng/php-diff 6.7.1 ile çalışıyor. 6.7.2 sürümüne güncelledikten sonra bozulmuş.

« Previous Page Next Page »