$ 100 bounty - Fix Ads extension

davwheat

Just got home. I'm seeing the ad code on your forum, but it's showing that the spots are "unfilled" meaning Google hasn't found any ads for your site.

Are you sure that you've added your domain on AdSense and it's been approved?

MikeJones

xasharma so that works, wounder why google isnt working. WHat does your code look lthat you are using for hte ad slots?

davwheat Yes 100% sure my website is approved. I have had ads on in for over a year.

xasharma

Justoverclock

True even Discourse has only under header (with discussion header) and footer ads.

xasharma

MikeJones

<center>
<!-- Header ad Homepage -->
<ins class="adsbygoogle"
     style="display:block"
     data-ad-client="ca-pub-5941506786539927"
     data-ad-slot="xxxxxxxxxxx"
     data-ad-format="auto"
     data-full-width-responsive="true"></ins>
</center>

MikeJones

xasharma so your code

<center>
<!-- Header ad Homepage -->
<ins class="adsbygoogle"
     style="display:block"
     data-ad-client="xxxxxxxxxxx"
     data-ad-slot="xxxxxxxxxxx"
     data-ad-format="auto"
     data-full-width-responsive="true"></ins>
</center>

my code:

<ins class="adsbygoogle"
   style="display:block"
   data-ad-client="xxxxxxxxxxx"
   data-ad-slot="xxxxxxxxxxx"
   data-ad-format="auto"
   available-width="auto"
   data-full-width-responsive="true"></ins>

Your code seems to work lol. MInor change 🤷‍♂️

davwheat

MikeJones

That's... so weird...

Anyway, working on between post ads now!

xasharma

MikeJones

Happy to see this 🔥

MikeJones

davwheat just an obersrvation right now. My code in:

Code for "Discussion page (under header)" ad unit

Keeps disappearing, and I have to re-paste it in there.

MikeJones

davwheat Anyway, working on between post ads now!

Super pumped! Also really like where you dump the ad in the discussion page other then at the top above the title. Looks much better than older versions I have used for the discussion page.

xasharma

MikeJones

yes but "Discussion page (under header) " works after disappearing

MikeJones

xasharma yes but "Discussion page (under header) " works after disappearing

Yea I noticed that too, the text would disappear in the settings but the advertisement still works 🤷‍♂️

davwheat

MikeJones xasharma

Just released 0.0.2 which should have working between post ads, and the issue with disappearing code should be gone too.

You can choose the gap between these ads on your admin control panel.

Make sure to run your migrations (again!).

davwheat

MikeJones

Ooh that sounds like a typo on my part then!

MikeJones

davwheat So to update just run:

composer update davwheat/flarum-ext-ads
php flarum migrate

I will try it out in like 45 minutes if thats it.

Also before your new version I noticed the mobile version ads were less consistent then the desktop ones, but I will re-evaluate when I try your latest version.

xasharma

davwheat

Sorry it i don't what is this -- check https://hacksnation.com/

Justoverclock

xasharma well this is broken
https://hacksnation.com/d/400-how-to-get-free-rdpvps-for-1-year

Walys

xasharma
I review this web and caution to add ads in this position in tags . View this link in mobile:
https://hacksnation.com/t/give-away-and-freebies

The ad takes up more than 50% of the screen in mobile with no text showing at first. Google doesn't like that with adsense.

Maybe better go with ads right after the label text and not at the beginning as it is now.

xasharma

It is showing only ads not posts

davwheat

xasharma

That's... very weird indeed...

Any chance you could quickly re-enable it so I can try and find the problem?

Between-post ads seem to work fine for me on your site.

xasharma

davwheat

xasharma correct .... i disabled login to see now its working

There is a extension named Login to see plus .... I have disabled the extension for the between the post ads

if i enable this it cause xasharma

xasharma

Justoverclock
Yes I disabled only between the post ... now it's fine

Justoverclock

xasharma

Working for me

Try in incognito mode .... btw in your screenshot it is showing ad under the scroll bar .... how 😅

davwheat

xasharma

That's because of how the footer ads are done. Not much can be done about that I don't think.

« Previous Page Next Page »