• Dev

  • $ 100 bounty - Fix Ads extension

MikeJones xasharma

Just released 0.0.2 which should have working between post ads, and the issue with disappearing code should be gone too.

You can choose the gap between these ads on your admin control panel.

Make sure to run your migrations (again!).

        davwheat So to update just run:

        composer update davwheat/flarum-ext-ads
php flarum migrate

        I will try it out in like 45 minutes if thats it.

        Also before your new version I noticed the mobile version ads were less consistent then the desktop ones, but I will re-evaluate when I try your latest version.

          Working for me

          Try in incognito mode .... btw in your screenshot it is showing ad under the scroll bar .... how 😅

            xasharma

            That's because of how the footer ads are done. Not much can be done about that I don't think.

              xasharma

              That's... very weird indeed...

              Any chance you could quickly re-enable it so I can try and find the problem?

              Between-post ads seem to work fine for me on your site.

                  xasharma

                  The issue seems to be with your engage message, for some reason. It doesn't have a "key", while all the other items do.

                  Also, make sure to remove the AdSense script from the custom header in the admin dashboard.

                  Actually, I missed one line of code. Let's see if that fixes it.

                      @davwheat I tried to update but it didnt see any updates...

                      ubuntu@ip-172-31-92-154:/var/www/tendigitgrid.com$ sudo composer update davwheat/flarum-ext-ads
Warning: You should avoid overwriting already defined auth settings for extiverse.com.
Do not run Composer as root/super user! See https://getcomposer.org/root for details
Continue as root/super user [yes]? yes
Loading composer repositories with package information
Updating dependencies
Nothing to modify in lock file
Installing dependencies from lock file (including require-dev)
Nothing to install, update or remove
Generating autoload files
107 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
ubuntu@ip-172-31-92-154:/var/www/tendigitgrid.com$

                        davwheat I already removed there is no script in custom header and footer

                          xasharma

                          It very much does seem like an issue with the "please log in" message, but I don't see why that would suddenly become an issue as a result of the ads.

                          Just disable between post ads for the moment while I do some local testing. Sorry!