Pallet Theme Compatibility.

Wlork

I see two bugs :

In tablet mode (horizontal), display isn't responsive
In posts, it would be nice to remove the line break

To summarize

Major bugs :

fof/nightmode. Impossible to install and to use
In tablet mode (horizontal), display isn't responsive

Minor bug :

In posts, it would be nice to remove the line break

Improvements :

To can change the primary or secondary color

After that, I think we can release a 1.0 version 🙂

adrianm

I've updated the PR with a couple more fixes. I'm not really sure what to do with this one now as @Kylo might not be around to approve/merge the PR? Not sure what happens in this situation.

Updates:

It took me a bit longer than I should admit to work out why I was able to install the theme and nightmode together locally, haha. I have it set up so it reads off a local copy and the version was "dev", there is a setting that says pallet theme conflicts with nightmode >0.1.0 so it was allowing the "dev" versions to work together fine. Anyway - I removed the "conflict" setting and that should work.
The theme is quite wide generally, especially with that right column. I just added 280px (width of the left column) to the "desktop width", so that that the desktop view kicks in a bit wider, and it seems to work out.
Not sure if you mean the lines between posts or the line-height of the text? These can be overridden in admin settings - appearance - custom styles. Might need to play around with these a bit to get it right.

Remove lines/dividers: .PostStream-item:not(:last-child) { border-bottom: none; }
Text line height: .Post-body p { line-height: 1.4rem; }
As for the colours, they pretty much have hard-coded values sprinkled around so not really a quick one to update. I will see what I can do on this one though.

Basically
Major bugs :

fof/nightmode. Impossible to install and to use - FIXED
In tablet mode (horizontal), display isn't responsive - FIXED

Minor bug :

In posts, it would be nice to remove the line break - FIX POSSIBLE WITH CSS?

Improvements :

To can change the primary or secondary color - NOT DONE

luceos

adrianm I've updated the PR with a couple more fixes. I'm not really sure what to do with this one now as @Kylo might not be around to approve/merge the PR? Not sure what happens in this situation

If the extension is published under an open source license, you can always fork it as long as you live up to the expectations of said license.

In addition to this, Kylo at one point mentioned that their availability is limited, however they also said they wanted to update extensions later on. However the most important thing they said is, at least that's what I understood from their words, that they'd abandon their extensions should an actively maintained version come along.

https://discuss.flarum.org/d/27959-prevent-double-posting/17

So, my recommendation is as follows;

you already have a fork, because you did a PR
publish this fork with a different vendor name
add a comment to the PR that you published the fork, it's up to them how to respond to that.
if @Kylo decided to abandon they should list your fork as replacement in the abandon popup on packagist

Ps, they can also offer you a maintainer position. But regardless of their choice, if the extension was MIT or similar, a fork under a different name is always legally possible, as long as you follow the requirements of the license.

Wlork

Thank for the major fixes 🙂

adrianm As for the colours, they pretty much have hard-coded values sprinkled around so not really a quick one to update. I will see what I can do on this one though.

I can imagine 🙁

I looked the dark mode (I forced it in the admin panel).

I already some issues :

banners aren't in the same color as the tags :

I have very little knowledge of JS, I don't know if that's the problem but I think there is a script that converts the main colors to (RGB code + 0.6).

For exemple :

background-color: rgba(255, 215, 0, **0.6**)

Normal mode :

Night mode :

And colour tags don't display correctly but I found the fix for this :

Remplace in extension :

.TagLabel.colored .TagLabel-text when (@config-dark-mode = true) {
  color: #212938 !important;
}

.TagLabel.colored .TagLabel-text when (@config-dark-mode = true) {
  color: var(--tag-color) !important; /*No sure if we need to put !important because is the default value */
}

Take your time for this ! 🙂

Thank you again for help 🙂

Wlork

@adrianm

Sorry for the double post

adrianm In posts, it would be nice to remove the line break - FIX POSSIBLE WITH CSS?

I found the issue ! 🙂

Remplace in extension :

.Post-body {
  line-height: 32px;
}

 .TextEditor .TextEditor-editor {
  line-height: 32px;
}

by :

.Post-body {
  line-height: 1.7;
}

 .TextEditor .TextEditor-editor {
  line-height: 1.7;
}

1.7 is the default value 😉 I think this needs to be corrected in the extension 🙂

adrianm

@Wlork
Sorry couldn't get to this one over the weekend - my weekends are a bit packed at the moment. I'm just looking at the last few issues now and think I have a better way to approach this. I'm looking at adding options for these in a settings page on admin rather than simply deleting them. I think the hard-coded tag label color being unreadable is pretty much a bug but the other things might need some flexibility.

Wlork

adrianm

Don't apologise, there's no need to worry 🙂

I suggest we continue on GitHud.

Yesterday, I posted my last two messages with more detail : the-turk/flarum-pallet-theme7#issuecomment-2106136049

It's a good idea to add options for greater flexibility 🙂

Some changes can't be made in admin (appearance), such as the banner colour or the colour of tags in night mode. That's why I've suggested returning to the default value (if that's possible).

adrianm

Wlork

I'll hopefully get a new commit for this in the morning. I didn't want to just remove stuff in case someone else wants it a bit different. It is possible to add some settings into the admin to control the colours, just working out a neat way to do it that fits in with the rest of the Flarum code/style.

adrianm

Playing around with admin settings page - it doesn't look great so trying to decide whether it's worth building some extra tooling in the settings pages to group settings and make it look a bit nicer

Wlork

adrianm

Sounds promising 🙂

In terms of CSS, it's really a custom-made theme. It's going to be difficult to put in all the options you need. I wish you all the best. Feel free to release a beta version if you want us to test it.

PS: Were you able to fix the bugs I reported this weekend ?

adrianm

@Wlork @MrHazbin these fixes have been implemented

Fixed colours for "nightmode" when site "dark mode" does not match user dark/light setting
Fixed unable to install pallet theme alongside nightmode
Fixed site width on tablets
Fixed tag label colour by removing the hard-coded override so it defaults back to the tag colour
Line heights can be set in custom CSS easily enough, I can help you out with that if you like.

The outstanding item is the colour customisation, which is a bigger job since there are hard-coded colors sprinkled throughout the code. For example, if you change the background color, the sidebar and a handful of other elements might look a bit off. Here's an example with a green background:

If you like, I can release what I have now on the fork so you can at least have a look at it, we can have a look at theme/colour customisation as admin settings for a later release? @Wlork @MrHazbin, let me know what you think.

@luceos thanks for your help.

Does this look right for re-publishing the extension?

update the details in composer.json with my own details (package name, add to authors)
update namespaces in the code (e,g, change the-turk/... to mad-eye-deer/...)
update the version number with a new tag and merge to the main branch
update the readme with new details, including a link back to original repo and credit to @Kylo, install instructions
submit the fork to packagist
add a post to the original pallet theme thread saying that I will be continuing its maintenance

luceos

adrianm Does this look right for re-publishing the extension?
update the details in composer.json with my own details (package name, add to authors)
update namespaces in the code (e,g, change the-turk/... to mad-eye-deer/...)
update the version number with a new tag and merge to the main branch
update the readme with new details, including a link back to original repo and credit to @Kylo, install instructions
submit the fork to packagist
add a post to the original pallet theme thread saying that I will be continuing its maintenance

update the details in composer.json with my own details (package name, add to authors)
update namespaces in the code (e,g, change the-turk/... to mad-eye-deer/...) and composer.json (autoload, psr4)
update the readme with new details, including a link back to original repo and credit to @Kylo, install instructions, keep Kylo referenced in LICENSE and in composer.json under authors
merge open changes into main/master and then tag a new version
submit the fork to packagist using your own repo url
create a new discussion underExtensions (so you can manage the OP) and link to that new discussion from the old one so we close it

I made some suggestions, but I think your proposal included most of the necessary changes already.

Wlork

adrianm Fixed tag label colour by removing the hard-coded override so it defaults back to the tag colour

Great ! 🙂

Have you corrected the banner color too? Sorry to bother you, but it's impossible to correct this via Admin > Appearance.

adrianm Line heights can be set in custom CSS easily enough, I can help you out with that if you like.

It doesn't bother me. But wouldn't it be simpler to put the default value (1.7) that everyone can set the height they want ?

adrianm The outstanding item is the colour customisation, which is a bigger job

Yes, I've noticed.

It looks like this theme can't be customized.... If you manage to put in all options, then I take my hat off to you ! 🙂

adrianm If you like, I can release what I have now on the fork so you can at least have a look at it, we can have a look at theme/colour customisation as admin settings for a later release?

Yes, I'd like to test it 🙂

If you upload your version of Pallet Theme, don't forget to mention that some extensions aren't compatible with it. At least for the moment 😉

adrianm

luceos

awesome, thank you!

adrianm

Wlork Have you corrected the banner color too? Sorry to bother you, but it's impossible to correct this via Admin > Appearance.

Oh yes I called it a "tag label colour"

Fixed tag label colour by removing the hard-coded override so it defaults back to the tag colour

oh I just realised I didn't remove the 0.6 "night mode" thing that makes the banner 60% opacity for night mode - I think we can just remove that? It looks a bit odd.

Wlork

adrianm oh I just realised I didn't remove the 0.6 "night mode" thing that makes the banner 60% opacity for night mode - I think we can just remove that? It looks a bit odd.

You need to test 🙂

Unlike CSS, I know very little about JS.... One thing I know for sure is that this is not the default value.

MrHazbin

im quite confused on how this works, have we a set price?

luceos

MrHazbin feels like @adrianm has been putting in a massive amount of work. Once the new extension is published, I would be okay with awarding them the bounty, meager as it is. So anything you are willing to give in addition to that would be more than justified and appreciated I think.

MrHazbin

i do say, both @Wlork && @adrianm, thank you alot for your contributions of this extension!

Wlork

@adrianm

I've just encountered a big bug that is related to FoF Byobu. The “Private Discussions” link appears in the left column. But when you go there, the “New discussion” button doesn't change. So it doesn't create a private discussion but a classic discussion.....

adrianm

Wlork

I have a feeling we will have quite a list of bugs still outstanding - especially if we start looking at other extensions.

« Previous Page