Pallet Theme Compatibility.

adrianm

Wlork Have you corrected the banner color too? Sorry to bother you, but it's impossible to correct this via Admin > Appearance.

Oh yes I called it a "tag label colour"

Fixed tag label colour by removing the hard-coded override so it defaults back to the tag colour

oh I just realised I didn't remove the 0.6 "night mode" thing that makes the banner 60% opacity for night mode - I think we can just remove that? It looks a bit odd.

Wlork

adrianm oh I just realised I didn't remove the 0.6 "night mode" thing that makes the banner 60% opacity for night mode - I think we can just remove that? It looks a bit odd.

You need to test 🙂

Unlike CSS, I know very little about JS.... One thing I know for sure is that this is not the default value.

MrHazbin

im quite confused on how this works, have we a set price?

MrHazbin

i do say, both @Wlork && @adrianm, thank you alot for your contributions of this extension!

luceos

MrHazbin feels like @adrianm has been putting in a massive amount of work. Once the new extension is published, I would be okay with awarding them the bounty, meager as it is. So anything you are willing to give in addition to that would be more than justified and appreciated I think.

Wlork

@adrianm

I've just encountered a big bug that is related to FoF Byobu. The “Private Discussions” link appears in the left column. But when you go there, the “New discussion” button doesn't change. So it doesn't create a private discussion but a classic discussion.....

adrianm

Wlork

I have a feeling we will have quite a list of bugs still outstanding - especially if we start looking at other extensions.

luceos

adrianm full compatibility with every extension should not be a requirement for marking a v1 (or whatever next version would be a major one). Though keeping track of these issues would make sense.

Wlork

adrianm

It seems to me that FoF Byobu is one of the only extensions that was made compatible by the original author, which is why I'm mentioning it 🙂

It's just the button that doesn't work if you gos in “Private Discussions”. This bug only appears in PC display. On mobile and tablet, it works because it's the default button that appears. 🙂

adrianm

I've made code changes for now and will just get the readme put together nicely with instructions etc, then will tag it, create a post in extensions, then can probably start getting a big list of items to work on, and see what the priorities are there. I don't like the idea of making code changes for each extension specifically so will need to dig into that and see what happened there and why they don't play nicely.

Wlork

adrianm

No worries.

This morning, I had fun setting the dark mode to my liking : 5 pages of CSS.

I think I can reduce it a bit, but there are a lot of parameters and little details to take into account. That's the problem with Pallet Theme : it's not flexible.

I hope the development goes well. I can't wait to see the result 🙂

adrianm

@Wlork @MrHazbin

New thread has been created here https://discuss.flarum.org/d/34569-pallet-theme-new. The version has been bumped to 0.2.1 and "beta" tag dropped.

Probably best to continue the discussion on the new thread?

« Previous Page